All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Shuah Khan <skhan@linuxfoundation.org>
Cc: Anders Roxell <anders.roxell@linaro.org>,
	shuah@kernel.org, willemb@google.com,
	linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests: Makefile: create OUTPUT dir
Date: Fri, 20 Sep 2024 12:38:27 +0200	[thread overview]
Message-ID: <20240920123827.715ff109@kernel.org> (raw)
In-Reply-To: <952aeec9-c21f-46ce-bf68-e6ffce51630c@linuxfoundation.org>

On Thu, 19 Sep 2024 09:51:47 -0600 Shuah Khan wrote:
> > @@ -261,6 +261,7 @@ ifdef INSTALL_PATH
> >   	@ret=1;	\
> >   	for TARGET in $(TARGETS) $(INSTALL_DEP_TARGETS); do \
> >   		BUILD_TARGET=$$BUILD/$$TARGET;	\
> > +		mkdir -p $$BUILD_TARGET;	\
> >   		$(MAKE) OUTPUT=$$BUILD_TARGET -C $$TARGET install \
> >   				INSTALL_PATH=$(INSTALL_PATH)/$$TARGET \
> >   				SRC_PATH=$(shell readlink -e $$(pwd)) \  
> 
> Doesn't the "all" target mkdir work for this case? Why do we need another mkdir here?

I was wondering about that, too. Looks like the code from the all
target is copy/pasted in the install target except the mkdir line.
Best fix would be to make the dependency work, I don't understand
why it doesn't already, tho.

  reply	other threads:[~2024-09-20 10:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-16  7:56 [PATCH] selftests: Makefile: create OUTPUT dir Anders Roxell
2024-09-19 15:51 ` Shuah Khan
2024-09-20 10:38   ` Jakub Kicinski [this message]
2024-09-25 17:26     ` Shuah Khan
2024-10-02  6:15       ` Anders Roxell
2024-10-04  0:01         ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240920123827.715ff109@kernel.org \
    --to=kuba@kernel.org \
    --cc=anders.roxell@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.