From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: Asaf Kahlon <asafka7@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/python-daphne: bump to version 4.1.2
Date: Fri, 20 Sep 2024 17:02:42 +0200 [thread overview]
Message-ID: <20240920170242.68e8ecb1@windsurf> (raw)
In-Reply-To: <CADvTj4pXQTNFZ+95H6Hm4euGtKrs8GeJ+-fPCcg6o_9SP+vHuQ@mail.gmail.com>
On Sun, 15 Sep 2024 15:42:22 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:
> > On this one you had forgotten to update .checkpackageignore to drop the
> > reference to the patch being removed. Suggestion: use
> > https://paste.ack.tf/bbebd2 as your .git/hooks/post-commit to catch
> > this kind of minor thing.
>
> I dropped the ./utils/docker-run part from this hook and it seems to work ok,
> was there a reason this was being run in docker?
Yes, it is important because we run flake8/shellcheck, and they don't
have the same checks from version to version, and the version in our
docker container is the reference version for Buildroot (and our
.checkpackageignore file).
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2024-09-20 15:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-15 4:41 [Buildroot] [PATCH 1/1] package/python-daphne: bump to version 4.1.2 James Hilliard
2024-09-15 8:08 ` Thomas Petazzoni via buildroot
2024-09-15 21:42 ` James Hilliard
2024-09-20 15:02 ` Thomas Petazzoni via buildroot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240920170242.68e8ecb1@windsurf \
--to=buildroot@buildroot.org \
--cc=asafka7@gmail.com \
--cc=james.hilliard1@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.