From: Greg KH <greg@kroah.com>
To: Jeff Johnson <quic_jjohnson@quicinc.com>
Cc: workflows@vger.kernel.org
Subject: Re: Are multiple Fixes Tags OK?
Date: Sat, 21 Sep 2024 11:08:03 +0200 [thread overview]
Message-ID: <2024092121-portside-impotent-2120@gregkh> (raw)
In-Reply-To: <1e86dfd8-8b69-4e51-8e39-524765a7b355@quicinc.com>
On Thu, Sep 19, 2024 at 08:07:56AM -0700, Jeff Johnson wrote:
> I'm reviewing an internal change that is fixing a memory leak of the same
> object in two different error paths. However each of the two error paths were
> introduced in separate commits, so there would be two Fixes: tags if both of
> these are fixed with the same patch.
>
> So is there any guidance on whether this should be one or two patches?
Ideally 2, if it's two different changes in the diff. But we have
patches with multiple Fixes: tags all the time, it's not unusual and if
it works for you, no objection.
thanks,
greg k-h
prev parent reply other threads:[~2024-09-21 9:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-19 15:07 Are multiple Fixes Tags OK? Jeff Johnson
2024-09-21 9:08 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024092121-portside-impotent-2120@gregkh \
--to=greg@kroah.com \
--cc=quic_jjohnson@quicinc.com \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.