From: kernel test robot <lkp@intel.com>
To: Otavio Salvador <otavio@ossystems.com.br>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [freescale-fslc:6.6-2.0.x-imx 1073/16782] drivers/video/fbdev/mxc/mxc_edid.c:190:5: warning: no previous prototype for function 'mxc_edid_fb_mode_is_equal'
Date: Sun, 22 Sep 2024 03:41:23 +0800 [thread overview]
Message-ID: <202409220314.tyltaJSg-lkp@intel.com> (raw)
tree: https://github.com/Freescale/linux-fslc 6.6-2.0.x-imx
head: d023c381fa6161a7af966abaad8e7d9a997f07e7
commit: 5186caddfc7d3885dd5dfd4c6d15caad2f900c4c [1073/16782] video: fbdev: mxc: add Northwest Logic DSI driver support
config: x86_64-kexec (https://download.01.org/0day-ci/archive/20240922/202409220314.tyltaJSg-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240922/202409220314.tyltaJSg-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409220314.tyltaJSg-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/video/fbdev/mxc/mxc_edid.c:190:5: warning: no previous prototype for function 'mxc_edid_fb_mode_is_equal' [-Wmissing-prototypes]
190 | int mxc_edid_fb_mode_is_equal(bool use_aspect,
| ^
drivers/video/fbdev/mxc/mxc_edid.c:190:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
190 | int mxc_edid_fb_mode_is_equal(bool use_aspect,
| ^
| static
1 warning generated.
vim +/mxc_edid_fb_mode_is_equal +190 drivers/video/fbdev/mxc/mxc_edid.c
184
185 /*
186 * We have a special version of fb_mode_is_equal that ignores
187 * pixclock, since for many CEA modes, 2 frequencies are supported
188 * e.g. 640x480 @ 60Hz or 59.94Hz
189 */
> 190 int mxc_edid_fb_mode_is_equal(bool use_aspect,
191 const struct fb_videomode *mode1,
192 const struct fb_videomode *mode2)
193 {
194 u32 mask;
195
196 if (use_aspect)
197 mask = ~0;
198 else
199 mask = ~FB_VMODE_ASPECT_MASK;
200
201 return (mode1->xres == mode2->xres &&
202 mode1->yres == mode2->yres &&
203 mode1->hsync_len == mode2->hsync_len &&
204 mode1->vsync_len == mode2->vsync_len &&
205 mode1->left_margin == mode2->left_margin &&
206 mode1->right_margin == mode2->right_margin &&
207 mode1->upper_margin == mode2->upper_margin &&
208 mode1->lower_margin == mode2->lower_margin &&
209 mode1->sync == mode2->sync &&
210 /* refresh check, 59.94Hz and 60Hz have the same parameter
211 * in struct of mxc_cea_mode */
212 abs(mode1->refresh - mode2->refresh) <= 1 &&
213 (mode1->vmode & mask) == (mode2->vmode & mask));
214 }
215
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2024-09-21 19:42 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202409220314.tyltaJSg-lkp@intel.com \
--to=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=otavio@ossystems.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.