From: Johannes Weiner <hannes@cmpxchg.org>
To: Paul Menzel <pmenzel@molgen.mpg.de>
Cc: Peter Zijlstra <peterz@infradead.org>,
Suren Baghdasaryan <surenb@google.com>,
Anna-Maria Behnsen <anna-maria@linutronix.de>,
Frederic Weisbecker <frederic@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
regressions@lists.linux.dev
Subject: Re: Error: psi: inconsistent task state! task=1:swapper/0 cpu=0 psi_flags=4 clear=0 set=4
Date: Sun, 22 Sep 2024 06:20:47 -0400 [thread overview]
Message-ID: <20240922102047.GA437832@cmpxchg.org> (raw)
In-Reply-To: <0bfb1dfc-bab0-45c1-9fc0-7e91266ef52a@molgen.mpg.de>
On Sun, Sep 22, 2024 at 08:53:37AM +0200, Paul Menzel wrote:
> [Cc: +PSI maintainers]
>
> Am 22.09.24 um 00:50 schrieb Paul Menzel:
> > #regzbot introduced: 2e0199df252a..54a58a787791
> >
> > Dear Peter,
> >
> >
> > With merge commit 2004cef11ea0 (Merge tag 'sched-core-2024-09-19' of
> > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip) I see the warning
> > below on the Intel Kaby Lake laptop Dell XPS 13 9360 and with QEMU.
> >
> > Dell XPS 13 9360:
> >
> > psi: inconsistent task state! task=1:swapper/0 cpu=0 psi_flags=4 clear=0 set=4
Oh, double enqueue.
It looks like the psi enqueue/dequeue callbacks need the same
treatment as the uclamp and sched_core ones for ignoring delayed
tasks. [1][2]
Do we need to reorder psi_enqueue() after ->enqueue_task() as well? I
can't quite work out why uclamp needed it, but sched_core didn't.
[1] dfa0a574cbc47bfd5f8985f74c8ea003a37fa078
[2] c662e2b1e8cfc3b6329704dab06051f8c3ec2993
next prev parent reply other threads:[~2024-09-22 10:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-21 22:50 Error: psi: inconsistent task state! task=1:swapper/0 cpu=0 psi_flags=4 clear=0 set=4 Paul Menzel
2024-09-22 6:53 ` Paul Menzel
2024-09-22 10:20 ` Johannes Weiner [this message]
2024-09-23 12:03 ` Parag W
2024-09-23 15:46 ` Johannes Weiner
2024-10-01 1:21 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240922102047.GA437832@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=anna-maria@linutronix.de \
--cc=frederic@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=pmenzel@molgen.mpg.de \
--cc=regressions@lists.linux.dev \
--cc=surenb@google.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.