Re: [RFC PATCH 3/4] use memory.low local node protection for local node reclaim

[kernel test robot <lkp@intel.com>]

Hi,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:

[auto build test WARNING on akpm-mm/mm-everything]
[also build test WARNING on linus/master next-20240920]
[cannot apply to tip/sched/core v6.11]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/kaiyang2-cs-cmu-edu/Add-get_cgroup_local_usage-for-estimating-the-top-tier-memory-usage/20240921-061404
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link:    https://lore.kernel.org/r/20240920221202.1734227-4-kaiyang2%40cs.cmu.edu
patch subject: [RFC PATCH 3/4] use memory.low local node protection for local node reclaim
config: x86_64-rhel-8.3 (https://download.01.org/0day-ci/archive/20240922/202409221032.DoTv9B0p-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240922/202409221032.DoTv9B0p-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409221032.DoTv9B0p-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> mm/memcontrol.c:4499: warning: Function parameter or struct member 'is_local' not described in 'mem_cgroup_calculate_protection'


vim +4499 mm/memcontrol.c

c077719be8e9e6 KAMEZAWA Hiroyuki   2009-01-07  4488  
241994ed8649f7 Johannes Weiner     2015-02-11  4489  /**
05395718b2fe48 Mel Gorman          2021-06-30  4490   * mem_cgroup_calculate_protection - check if memory consumption is in the normal range
34c81057927311 Sean Christopherson 2017-07-10  4491   * @root: the top ancestor of the sub-tree being checked
241994ed8649f7 Johannes Weiner     2015-02-11  4492   * @memcg: the memory cgroup to check
241994ed8649f7 Johannes Weiner     2015-02-11  4493   *
230671533d6463 Roman Gushchin      2018-06-07  4494   * WARNING: This function is not stateless! It can only be used as part
230671533d6463 Roman Gushchin      2018-06-07  4495   *          of a top-down tree iteration, not for isolated queries.
241994ed8649f7 Johannes Weiner     2015-02-11  4496   */
45c7f7e1ef17f0 Chris Down          2020-08-06  4497  void mem_cgroup_calculate_protection(struct mem_cgroup *root,
3ebe5883ec39d9 Kaiyang Zhao        2024-09-20  4498  				     struct mem_cgroup *memcg, int is_local)
241994ed8649f7 Johannes Weiner     2015-02-11 @4499  {
a8585ac6862198 Maarten Lankhorst   2024-07-03  4500  	bool recursive_protection =
a8585ac6862198 Maarten Lankhorst   2024-07-03  4501  		cgrp_dfl_root.flags & CGRP_ROOT_MEMORY_RECURSIVE_PROT;
230671533d6463 Roman Gushchin      2018-06-07  4502  
241994ed8649f7 Johannes Weiner     2015-02-11  4503  	if (mem_cgroup_disabled())
45c7f7e1ef17f0 Chris Down          2020-08-06  4504  		return;
241994ed8649f7 Johannes Weiner     2015-02-11  4505  
34c81057927311 Sean Christopherson 2017-07-10  4506  	if (!root)
34c81057927311 Sean Christopherson 2017-07-10  4507  		root = root_mem_cgroup;
22f7496f0b9012 Yafang Shao         2020-08-06  4508  
6f4c005a5f8b8f Kaiyang Zhao        2024-09-20  4509  	page_counter_calculate_protection(&root->memory, &memcg->memory,
3ebe5883ec39d9 Kaiyang Zhao        2024-09-20  4510  					recursive_protection, is_local);
241994ed8649f7 Johannes Weiner     2015-02-11  4511  }
241994ed8649f7 Johannes Weiner     2015-02-11  4512  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki