From: Leon Romanovsky <leon@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Xi Ruoyao <xry111@xry111.site>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org, iommu@lists.linux.dev,
Robin Murphy <robin.murphy@arm.com>
Subject: Re: [GIT PULL] dma-mapping updates for Linux 6.12
Date: Sun, 22 Sep 2024 13:32:36 +0300 [thread overview]
Message-ID: <20240922103236.GA11337@unreal> (raw)
In-Reply-To: <Zu_FDfHZAVzPv1lq@infradead.org>
On Sun, Sep 22, 2024 at 12:19:41AM -0700, Christoph Hellwig wrote:
> On Sun, Sep 22, 2024 at 02:56:57PM +0800, Xi Ruoyao wrote:
> > With SND disabled, b5c58b2fdc427e7958412ecb2de2804a1f7c1572 boots fine
> > (no oops), but the camera does not work.
> > f69e342eec008e1bab772d3963c3dd9979293e13 boots fine and the camera works
> > fine.
> >
> > So the first bad commit is b5c58b2fdc427e7958412ecb2de2804a1f7c1572.
>
> Thanks a lot for the bisection!
Christoph,
Another chunk that is missing according to this BZ
https://bugzilla.kernel.org/show_bug.cgi?id=219292:
diff --git a/kernel/dma/mapping.c b/kernel/dma/mapping.c
index b839683da0ba..cf3b89e681a3 100644
--- a/kernel/dma/mapping.c
+++ b/kernel/dma/mapping.c
@@ -926,7 +926,7 @@ bool dma_addressing_limited(struct device *dev)
dma_get_required_mask(dev))
return true;
- if (unlikely(ops))
+ if (unlikely(ops) || use_dma_iommu(dev)
return false;
return !dma_direct_all_ram_mapped(dev);
}
Sorry for such a mess.
Thanks
next prev parent reply other threads:[~2024-09-22 10:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-19 7:54 [GIT PULL] dma-mapping updates for Linux 6.12 Christoph Hellwig
2024-09-19 9:40 ` pr-tracker-bot
2024-09-19 21:41 ` Xi Ruoyao
2024-09-20 11:26 ` Christoph Hellwig
2024-09-20 14:06 ` Christoph Hellwig
2024-09-20 17:15 ` Xi Ruoyao
2024-09-20 17:48 ` Xi Ruoyao
2024-09-21 5:12 ` Christoph Hellwig
2024-09-21 7:56 ` Xi Ruoyao
2024-09-21 13:51 ` Christoph Hellwig
2024-09-21 17:49 ` Xi Ruoyao
2024-09-22 4:58 ` Christoph Hellwig
2024-09-22 6:56 ` Xi Ruoyao
2024-09-22 7:19 ` Christoph Hellwig
2024-09-22 10:32 ` Leon Romanovsky [this message]
2024-09-22 14:03 ` Christoph Hellwig
2024-09-22 12:40 ` Xi Ruoyao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240922103236.GA11337@unreal \
--to=leon@kernel.org \
--cc=hch@infradead.org \
--cc=iommu@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
--cc=torvalds@linux-foundation.org \
--cc=xry111@xry111.site \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.