From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 65630CF9C64 for ; Sun, 22 Sep 2024 17:06:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XMSt2Wx7F0KxSeza4o0J+HbgmLA0n90KOCzVcH0D9+Y=; b=kYFYANn3pN2yOgLO5HDshsAB/i o7+KOz5MOFsNq4+N5x6SOYDnxPQIVyksh8vuPjemgbSAcrc3+lOapoBL17pq06lPV2JHhFutKg+xf 42j5O7DmwnBdJk9IkfDIZxZvo6a+6XGqa9oOaaQFpTvLE6bJL0yfYikV4oY73QG4TtZiB8Eaqf8QN njEbuMYYkwwsib+B9rfNIE5cJWl6tQl/sw15OmDYXon9IHs6da5mrj3a2lnnSHmjjcj9OLINuiTBc nbzAvc3rkUi1ZTM1fm4IKD/rcS46/0laWNharKHQpN/kgueTbXlNJN0/JkwHpCgjuRpl8YFqvoCEB I6RnN2Xw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1ssQ2R-0000000FTVg-08pZ; Sun, 22 Sep 2024 17:06:23 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1ssQ1J-0000000FTMr-1MaH for linux-arm-kernel@lists.infradead.org; Sun, 22 Sep 2024 17:05:14 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 36B485C545B; Sun, 22 Sep 2024 17:05:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 56A0DC4CEC3; Sun, 22 Sep 2024 17:05:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727024711; bh=xslP7AXvSkVuMhvWM8OqO8/hx8E19JC6RLFtS4kykIs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Tb4geJDSEjrBGmuC/mExVwIo6ha8m2jYkGkBj6kXi1blEi1GLSYSFSqGqpmc2AI+2 hE/VCggXEajkvH8VgpSKngkjiqvndvC3W0abooMx5qm4UQKTqHdlOEtyCHecucJiMv ugt8vGVu17Y4/xUw+j8E59YCXF2ZvXkysByUFwbKmbTkxEdUKEeDoidIhqM+lrCRt3 wCi4IJOATxtu4RH1yUmnEKcVwNVUxs7PVHmtJJl6kriN8LdEDsmtyY/XgK/LykjZ9D YDgwkmB8+/bqRfPsOb+lKZVhaJ7ljk4xspNvEDsFdNsLW28wEdFhw7OX2JLtKbg4Zo PEeZzaC3VC6UQ== Date: Sun, 22 Sep 2024 18:05:07 +0100 From: Simon Horman To: Markus Elfring Cc: netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Clayton Rayment , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Michal Simek , Paolo Abeni , Radhey Shyam Pandey , LKML , Julia Lawall Subject: Re: [PATCH] net: xilinx: axienet: Use common error handling code in axienet_mdio_write() Message-ID: <20240922170507.GD3426578@kernel.org> References: <330c2b9e-9a15-4442-8288-07f66760f856@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <330c2b9e-9a15-4442-8288-07f66760f856@web.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240922_100513_432167_52D8ED0C X-CRM114-Status: GOOD ( 18.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 20, 2024 at 01:01:45PM +0200, Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 20 Sep 2024 12:43:39 +0200 > Subject: [PATCH] net: xilinx: axienet: Use common error handling code in axienet_mdio_write() > > Add a label so that a bit of exception handling can be better reused > at the end of this function implementation. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Hi Markus, This change seems reasonable to me. However, I am assuming that as a non-bug-fix, this is targeted at net-next. And net-next is currently closed for the v6.12 merge window. Please consider reposting this patch once net-next reopens. That will occur after v6.12-rc1 has been released. Which I expect to be about a week from now. Also, for networking patches please tag non-bug fixes for net-next (and bug fixes for net, being sure to include a Fixes tag). Subject: [PATCH net-next] ... Please see https://docs.kernel.org/process/maintainer-netdev.html ... > diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_mdio.c b/drivers/net/ethernet/xilinx/xilinx_axienet_mdio.c ... > @@ -153,12 +151,9 @@ static int axienet_mdio_write(struct mii_bus *bus, int phy_id, int reg, > XAE_MDIO_MCR_OP_WRITE_MASK)); > > ret = axienet_mdio_wait_until_ready(lp); > - if (ret < 0) { > - axienet_mdio_mdc_disable(lp); > - return ret; > - } Please add a blank line here. > +disable_mdc: > axienet_mdio_mdc_disable(lp); > - return 0; > + return ret; > } > > /** -- pw-bot: defer