From: Simon Horman <horms@kernel.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: netdev@vger.kernel.org,
"Christian Marangi" <ansuelsmth@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Nick Child" <nnac123@linux.ibm.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
"Taku Izumi" <izumi.taku@jp.fujitsu.com>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"Yasuaki Ishimatsu" <isimatu.yasuaki@jp.fujitsu.com>,
LKML <linux-kernel@vger.kernel.org>,
"Julia Lawall" <julia.lawall@inria.fr>,
"Yasuaki Ishimatsu" <yasu.isimatu@gmail.com>
Subject: Re: [PATCH] net: fjes: Refactor a string comparison in is_extended_socket_device()
Date: Sun, 22 Sep 2024 18:08:11 +0100 [thread overview]
Message-ID: <20240922170811.GE3426578@kernel.org> (raw)
In-Reply-To: <9ec752a8-49e9-40fd-8ed9-fed29d53f37b@web.de>
On Fri, Sep 20, 2024 at 02:24:50PM +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Fri, 20 Sep 2024 13:56:44 +0200
>
> Assign the return value from a strncmp() call to a local variable
> so that an if statement can be omitted accordingly.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Hi Markus,
This is an old driver, that doesn't appear to have been under active
development for quite some time. And I don't think that clean-ups of this
nature are worth the risk of regressions they might introduce.
If we can see bugs, let's fix them.
Else, let's leave it be.
--
pw-bot: rejected
prev parent reply other threads:[~2024-09-22 17:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-20 12:24 [PATCH] net: fjes: Refactor a string comparison in is_extended_socket_device() Markus Elfring
2024-09-22 17:08 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240922170811.GE3426578@kernel.org \
--to=horms@kernel.org \
--cc=Markus.Elfring@web.de \
--cc=ansuelsmth@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=isimatu.yasuaki@jp.fujitsu.com \
--cc=izumi.taku@jp.fujitsu.com \
--cc=julia.lawall@inria.fr \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nnac123@linux.ibm.com \
--cc=pabeni@redhat.com \
--cc=rafael.j.wysocki@intel.com \
--cc=u.kleine-koenig@baylibre.com \
--cc=yasu.isimatu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.