From: amin-amani <didi1364@gmail.com>
To: johan@kernel.org
Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, amin-amani <didi1364@gmail.com>
Subject: [PATCH] usb: serial: digi_acceleport: Enhance error handling by checkpatch.pl
Date: Mon, 23 Sep 2024 00:45:12 +0330 [thread overview]
Message-ID: <20240922211512.49273-1-didi1364@gmail.com> (raw)
- Separated null checks for port, serial and private data.
Signed-off-by: amin-amani <didi1364@gmail.com>
---
drivers/usb/serial/digi_acceleport.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/serial/digi_acceleport.c b/drivers/usb/serial/digi_acceleport.c
index d1dea3850576..d858358f94d8 100644
--- a/drivers/usb/serial/digi_acceleport.c
+++ b/drivers/usb/serial/digi_acceleport.c
@@ -1309,9 +1309,14 @@ static void digi_read_bulk_callback(struct urb *urb)
__func__, status);
return;
}
- if (port->serial == NULL ||
- (serial_priv = usb_get_serial_data(port->serial)) == NULL) {
- dev_err(&port->dev, "%s: serial is bad or serial->private "
+ if (port->serial == NULL) {
+ dev_err(&port->dev, "%s: serial is bad,"
+ " status=%d\n", __func__, status);
+ return;
+ }
+ serial_priv = usb_get_serial_data(port->serial);
+ if (serial_priv == NULL) {
+ dev_err(&port->dev, "%s:serial->private "
"is NULL, status=%d\n", __func__, status);
return;
}
--
2.25.1
next reply other threads:[~2024-09-22 21:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-22 21:15 amin-amani [this message]
2024-09-23 6:47 ` [PATCH] usb: serial: digi_acceleport: Enhance error handling by checkpatch.pl Greg KH
2024-09-23 6:49 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240922211512.49273-1-didi1364@gmail.com \
--to=didi1364@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.