From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 72CD5CF6495 for ; Sun, 29 Sep 2024 21:29:41 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6987510E3BA; Sun, 29 Sep 2024 21:29:40 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=nvidia.com header.i=@nvidia.com header.b="iuecSZ9x"; dkim-atps=neutral Received: from xvfrnhpk.outbound-mail.sendgrid.net (xvfrnhpk.outbound-mail.sendgrid.net [168.245.32.49]) by gabe.freedesktop.org (Postfix) with ESMTPS id 23C0710E08E for ; Mon, 23 Sep 2024 13:54:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; h=from:subject:in-reply-to:references:mime-version:to:cc: content-transfer-encoding:content-type:cc:content-type:from:subject:to; s=s1; bh=RbSG7t9Wbvc6nLERNuyEIbEcFl98xy78HtYg4AjxY2Q=; b=iuecSZ9x0TDvwkjOF1QtN8LijPJrPvBXp6aVNmfgfgACm6JqYc8cFRFFwYD/yjrFVODn /agz9HXLLCLKUcd9hntkCsXxQdvil+7B/BU9MvsQOzJBt3R6jL2ZuSCX8F/UiMvDjPCeFg 447ZCp2TCltjN5lhF1hd2ifZlFknpqxTnrZBo6pQeM3IijYrh/u+v3D+rQ+w/gKRU1ZVMC seFqUnSKVBmhDcE8B7AlVrN5FgRds22RY4j3Hj2G2qiAbawKI+OM9fHZ6oRwkizkDshIGQ xxQJ/Qc8P1thflEQsQnSitkh3cUq7w+Kiax6LsxM1+q/JMBywkKtPLGjEh9XVAtQ== Received: by recvd-65bdd88ff5-vgk98 with SMTP id recvd-65bdd88ff5-vgk98-1-66F17330-1A 2024-09-23 13:54:56.493438279 +0000 UTC m=+935916.731801245 Received: from mtl123.mtl.labs.mlnx (unknown) by geopod-ismtpd-3 (SG) with ESMTP id wWVp2A81Qlqe0C8ylPrUsA Mon, 23 Sep 2024 13:54:56.341 +0000 (UTC) Received: from adv-dev-804.mtl.labs.mlnx (adv-dev-804.mtl.labs.mlnx [10.237.43.220]) by mtl123.mtl.labs.mlnx (8.14.4/8.14.4) with ESMTP id 48NDste0028632; Mon, 23 Sep 2024 16:54:55 +0300 Received: from adv-dev-804.mtl.labs.mlnx (localhost [127.0.0.1]) by adv-dev-804.mtl.labs.mlnx (8.15.2/8.15.2/Debian-22ubuntu3) with ESMTP id 48NDstgq356267; Mon, 23 Sep 2024 16:54:55 +0300 Received: (from ymaman@localhost) by adv-dev-804.mtl.labs.mlnx (8.15.2/8.15.2/Submit) id 48NDst2J356266; Mon, 23 Sep 2024 16:54:55 +0300 From: Yonatan Maman Subject: [PATCH 1/2] nouveau/dmem: Fix privileged error in copy engine channel Date: Mon, 23 Sep 2024 13:54:56 +0000 (UTC) Message-Id: <20240923135449.356244-2-Ymaman@Nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240923135449.356244-1-Ymaman@Nvidia.com> References: <20240923135449.356244-1-Ymaman@Nvidia.com> MIME-Version: 1.0 X-SG-EID: =?us-ascii?Q?u001=2ELV3ZPuPfm6MEUzpJJKUmPK7bFUdOAxbw77JQHpHEsK=2FX2=2FUTlQRmqLgqk?= =?us-ascii?Q?5EHnkMyvO1KLlDiEzbuD8jfGZLnyNUommuLqoY8?= =?us-ascii?Q?fivpTIPr=2FTbwldNoH2DPD2y59n5dVgRqSyHGzTb?= =?us-ascii?Q?+t+PeqoRubypLeMLKkBk5eWbP3r6YoLl3c=2FbaXJ?= =?us-ascii?Q?b8U9KMW8r4OIg6EgIGSK4czo+KbWx7iYbKKIMgZ?= =?us-ascii?Q?xazv0dEHW5A0lWqWpafCeC49k1ni5w7Lmy5eeTH?= =?us-ascii?Q?noxn?= To: nouveau@lists.freedesktop.org Cc: Yonatan Maman , Gal Shalom X-Entity-ID: u001.9Nu+sJkq3f0LJ/tZbyfOWA== Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii X-Mailman-Approved-At: Sun, 29 Sep 2024 21:29:23 +0000 X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" When `nouveau_dmem_copy_one` is called, the following error occurs: [272146.675156] nouveau 0000:06:00.0: fifo: PBDMA9: 00000004 [HCE_PRIV] ch 1 00000300 00003386 This indicates that a copy push command triggered a Host Copy Engine Privileged error on channel 1 (Copy Engine channel). To address this issue, modify the Copy Engine channel to allow privileged push commands Fixes: 6de125383a5cc Signed-off-by: Yonatan Maman Signed-off-by: Gal Shalom --- drivers/gpu/drm/nouveau/nouveau_drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c index a58c31089613..0a75ce4c5021 100644 --- a/drivers/gpu/drm/nouveau/nouveau_drm.c +++ b/drivers/gpu/drm/nouveau/nouveau_drm.c @@ -356,7 +356,7 @@ nouveau_accel_ce_init(struct nouveau_drm *drm) return; } - ret = nouveau_channel_new(drm, device, false, runm, NvDmaFB, NvDmaTT, &drm->cechan); + ret = nouveau_channel_new(drm, device, true, runm, NvDmaFB, NvDmaTT, &drm->cechan); if (ret) NV_ERROR(drm, "failed to create ce channel, %d\n", ret); } -- 2.34.1