From: Simon Horman <horms@kernel.org>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: Jinjie Ruan <ruanjinjie@huawei.com>,
Paolo Abeni <pabeni@redhat.com>,
Jacob Keller <jacob.e.keller@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
linux-kernel@vger.kernel.org, oe-kbuild-all@lists.linux.dev,
Dan Carpenter <dan.carpenter@linaro.org>,
Rafal Romanowski <rafal.romanowski@intel.com>,
netdev@vger.kernel.org
Subject: Re: drivers/net/ethernet/intel/igb/igb_main.c:7895:6-11: ERROR: invalid reference to the index variable of the iterator on line 7890 (fwd)
Date: Mon, 23 Sep 2024 15:01:25 +0100 [thread overview]
Message-ID: <20240923140125.GG3426578@kernel.org> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2409131949580.3731@hadrien>
+ Dan Carpenter, Rafal Romanowski, netdev
On Fri, Sep 13, 2024 at 07:51:48PM +0200, Julia Lawall wrote:
> On line 7895, entry is never NULL, even if you are at the end (which is
> the same as the beginning) of the list.
>
> julia
Hi Julia, all,
Unless I am mistaken (it often happens) this is an issue
from about a year ago what was fixed within the same
time frame by Dan Carpenter in:
- 4690aea589e7 ("igb: Fix an end of loop test")
https://git.kernel.org/netdev/net/c/4690aea589e7
> ---------- Forwarded message ----------
> Date: Sat, 14 Sep 2024 01:43:11 +0800
> From: kernel test robot <lkp@intel.com>
> To: oe-kbuild@lists.linux.dev
> Cc: lkp@intel.com, Julia Lawall <julia.lawall@inria.fr>
> Subject: drivers/net/ethernet/intel/igb/igb_main.c:7895:6-11: ERROR: invalid
> reference to the index variable of the iterator on line 7890
>
> BCC: lkp@intel.com
> CC: oe-kbuild-all@lists.linux.dev
> CC: linux-kernel@vger.kernel.org
> TO: Jinjie Ruan <ruanjinjie@huawei.com>
> CC: Paolo Abeni <pabeni@redhat.com>
> CC: Jacob Keller <jacob.e.keller@intel.com>
> CC: Tony Nguyen <anthony.l.nguyen@intel.com>
> CC: Simon Horman <horms@kernel.org>
>
> Hi Jinjie,
>
> FYI, the error/warning was bisected to this commit, please ignore it if it's irrelevant.
>
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: 196145c606d0f816fd3926483cb1ff87e09c2c0b
> commit: c1fec890458ad101ddbbc52cdd29f7bba6aa2b10 ethernet/intel: Use list_for_each_entry() helper
> date: 12 months ago
> :::::: branch date: 18 hours ago
> :::::: commit date: 12 months ago
> config: microblaze-randconfig-r052-20240913 (https://download.01.org/0day-ci/archive/20240914/202409140131.Y6Qnoc6t-lkp@intel.com/config)
> compiler: microblaze-linux-gcc (GCC) 14.1.0
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Reported-by: Julia Lawall <julia.lawall@inria.fr>
> | Closes: https://lore.kernel.org/r/202409140131.Y6Qnoc6t-lkp@intel.com/
>
> cocci warnings: (new ones prefixed by >>)
> >> drivers/net/ethernet/intel/igb/igb_main.c:7895:6-11: ERROR: invalid reference to the index variable of the iterator on line 7890
> drivers/net/ethernet/intel/igb/igb_main.c:7895:15-20: ERROR: invalid reference to the index variable of the iterator on line 7890
>
> vim +7895 drivers/net/ethernet/intel/igb/igb_main.c
>
> 83c21335c87622 Yury Kylulin 2017-03-07 7854
> b476deab8f412b Colin Ian King 2017-04-27 7855 static int igb_set_vf_mac_filter(struct igb_adapter *adapter, const int vf,
> 4827cc37796a02 Yury Kylulin 2017-03-07 7856 const u32 info, const u8 *addr)
> 4827cc37796a02 Yury Kylulin 2017-03-07 7857 {
> 4827cc37796a02 Yury Kylulin 2017-03-07 7858 struct pci_dev *pdev = adapter->pdev;
> 4827cc37796a02 Yury Kylulin 2017-03-07 7859 struct vf_data_storage *vf_data = &adapter->vf_data[vf];
> 4827cc37796a02 Yury Kylulin 2017-03-07 7860 struct vf_mac_filter *entry = NULL;
> 4827cc37796a02 Yury Kylulin 2017-03-07 7861 int ret = 0;
> 4827cc37796a02 Yury Kylulin 2017-03-07 7862
> 1b8b062a99dc76 Corinna Vinschen 2018-01-17 7863 if ((vf_data->flags & IGB_VF_FLAG_PF_SET_MAC) &&
> 1b8b062a99dc76 Corinna Vinschen 2018-01-17 7864 !vf_data->trusted) {
> 4827cc37796a02 Yury Kylulin 2017-03-07 7865 dev_warn(&pdev->dev,
> 4827cc37796a02 Yury Kylulin 2017-03-07 7866 "VF %d requested MAC filter but is administratively denied\n",
> 4827cc37796a02 Yury Kylulin 2017-03-07 7867 vf);
> 4827cc37796a02 Yury Kylulin 2017-03-07 7868 return -EINVAL;
> 4827cc37796a02 Yury Kylulin 2017-03-07 7869 }
> 4827cc37796a02 Yury Kylulin 2017-03-07 7870 if (!is_valid_ether_addr(addr)) {
> 4827cc37796a02 Yury Kylulin 2017-03-07 7871 dev_warn(&pdev->dev,
> 4827cc37796a02 Yury Kylulin 2017-03-07 7872 "VF %d attempted to set invalid MAC filter\n",
> 4827cc37796a02 Yury Kylulin 2017-03-07 7873 vf);
> 4827cc37796a02 Yury Kylulin 2017-03-07 7874 return -EINVAL;
> 4827cc37796a02 Yury Kylulin 2017-03-07 7875 }
> 4827cc37796a02 Yury Kylulin 2017-03-07 7876
> 584af82154f56e Karen Sornek 2021-08-31 7877 switch (info) {
> 584af82154f56e Karen Sornek 2021-08-31 7878 case E1000_VF_MAC_FILTER_CLR:
> 584af82154f56e Karen Sornek 2021-08-31 7879 /* remove all unicast MAC filters related to the current VF */
> c1fec890458ad1 Jinjie Ruan 2023-09-19 7880 list_for_each_entry(entry, &adapter->vf_macs.l, l) {
> 584af82154f56e Karen Sornek 2021-08-31 7881 if (entry->vf == vf) {
> 584af82154f56e Karen Sornek 2021-08-31 7882 entry->vf = -1;
> 584af82154f56e Karen Sornek 2021-08-31 7883 entry->free = true;
> 584af82154f56e Karen Sornek 2021-08-31 7884 igb_del_mac_filter(adapter, entry->vf_mac, vf);
> 584af82154f56e Karen Sornek 2021-08-31 7885 }
> 584af82154f56e Karen Sornek 2021-08-31 7886 }
> 584af82154f56e Karen Sornek 2021-08-31 7887 break;
> 584af82154f56e Karen Sornek 2021-08-31 7888 case E1000_VF_MAC_FILTER_ADD:
> 4827cc37796a02 Yury Kylulin 2017-03-07 7889 /* try to find empty slot in the list */
> c1fec890458ad1 Jinjie Ruan 2023-09-19 @7890 list_for_each_entry(entry, &adapter->vf_macs.l, l) {
> 4827cc37796a02 Yury Kylulin 2017-03-07 7891 if (entry->free)
> 4827cc37796a02 Yury Kylulin 2017-03-07 7892 break;
> 4827cc37796a02 Yury Kylulin 2017-03-07 7893 }
> 4827cc37796a02 Yury Kylulin 2017-03-07 7894
> 4827cc37796a02 Yury Kylulin 2017-03-07 @7895 if (entry && entry->free) {
> 4827cc37796a02 Yury Kylulin 2017-03-07 7896 entry->free = false;
> 4827cc37796a02 Yury Kylulin 2017-03-07 7897 entry->vf = vf;
> 4827cc37796a02 Yury Kylulin 2017-03-07 7898 ether_addr_copy(entry->vf_mac, addr);
> 4827cc37796a02 Yury Kylulin 2017-03-07 7899
> 4827cc37796a02 Yury Kylulin 2017-03-07 7900 ret = igb_add_mac_filter(adapter, addr, vf);
> 4827cc37796a02 Yury Kylulin 2017-03-07 7901 ret = min_t(int, ret, 0);
> 4827cc37796a02 Yury Kylulin 2017-03-07 7902 } else {
> 4827cc37796a02 Yury Kylulin 2017-03-07 7903 ret = -ENOSPC;
> 4827cc37796a02 Yury Kylulin 2017-03-07 7904 }
> 4827cc37796a02 Yury Kylulin 2017-03-07 7905
> 4827cc37796a02 Yury Kylulin 2017-03-07 7906 if (ret == -ENOSPC)
> 4827cc37796a02 Yury Kylulin 2017-03-07 7907 dev_warn(&pdev->dev,
> 4827cc37796a02 Yury Kylulin 2017-03-07 7908 "VF %d has requested MAC filter but there is no space for it\n",
> 4827cc37796a02 Yury Kylulin 2017-03-07 7909 vf);
> 4827cc37796a02 Yury Kylulin 2017-03-07 7910 break;
> 4827cc37796a02 Yury Kylulin 2017-03-07 7911 default:
> 4827cc37796a02 Yury Kylulin 2017-03-07 7912 ret = -EINVAL;
> 4827cc37796a02 Yury Kylulin 2017-03-07 7913 break;
> 4827cc37796a02 Yury Kylulin 2017-03-07 7914 }
> 4827cc37796a02 Yury Kylulin 2017-03-07 7915
> 4827cc37796a02 Yury Kylulin 2017-03-07 7916 return ret;
> 4827cc37796a02 Yury Kylulin 2017-03-07 7917 }
> 4827cc37796a02 Yury Kylulin 2017-03-07 7918
>
> :::::: The code at line 7895 was first introduced by commit
> :::::: 4827cc37796a02ece7097e01dad8e08f537ac815 igb/igbvf: Add VF MAC filter request capabilities
>
> :::::: TO: Yury Kylulin <yury.kylulin@intel.com>
> :::::: CC: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki
>
next prev parent reply other threads:[~2024-09-23 14:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 17:51 drivers/net/ethernet/intel/igb/igb_main.c:7895:6-11: ERROR: invalid reference to the index variable of the iterator on line 7890 (fwd) Julia Lawall
2024-09-23 14:01 ` Simon Horman [this message]
2024-09-25 7:15 ` Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2024-10-06 14:48 Julia Lawall
2023-12-06 20:35 Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240923140125.GG3426578@kernel.org \
--to=horms@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=dan.carpenter@linaro.org \
--cc=jacob.e.keller@intel.com \
--cc=julia.lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=pabeni@redhat.com \
--cc=rafal.romanowski@intel.com \
--cc=ruanjinjie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.