All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Chris Mi <cmi@nvidia.com>
Cc: Florian Westphal <fw@strlen.de>,
	Pablo Neira Ayuso <pablo@netfilter.org>,
	Ali Abdallah <aabdallah@suse.de>,
	netfilter-devel@vger.kernel.org
Subject: Re: ct hardware offload ignores RST packet
Date: Mon, 23 Sep 2024 18:51:15 +0200	[thread overview]
Message-ID: <20240923165115.GA9034@breakpoint.cc> (raw)
In-Reply-To: <5edeab2c-2d36-4cef-b005-bf98a496db2c@nvidia.com>

Chris Mi <cmi@nvidia.com> wrote:
> > nf_tcp_handle_invalid() here resolves the problem as well?
> > Intent would be to reduce timeout but keep connecton state
> > as-is.
> > 
> > I don't think we should force customers to tweak sysctls to
> > make expiry work as intended.
> 
> It doesn't work. The if statement is not executed because the condition
> is not met.
> 
> [Mon Sep 23 18:41:59 2024] nf_tcp_handle_invalid: 756, last_dir: 0, dir: 0,
> last_index: 3

How about relaxing nf_tcp_handle_invalid() to no longer check dir and
last_index?

It already makes sure that timeout can only be reduced by such invalid
fin/rst.

I.e. also get rid of else clause and extra indent level.

> Even if the if statement is executed, the timeout is still not changed.

Hmm, why not? Can you elaborate? Is the timeout already below 2 minutes?
If so, what is the exact expectation?

Could you propose a patch? As I said, I dislike tying this to sysctls.

  reply	other threads:[~2024-09-23 16:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-23  9:47 ct hardware offload ignores RST packet Chris Mi
2024-09-23 10:03 ` Florian Westphal
2024-09-23 15:47   ` Chris Mi
2024-09-23 16:51     ` Florian Westphal [this message]
2024-09-23 17:41       ` Pablo Neira Ayuso
2024-09-24  1:04         ` Chris Mi
2024-09-24  1:03       ` Chris Mi
2024-09-24 19:11         ` Florian Westphal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240923165115.GA9034@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=aabdallah@suse.de \
    --cc=cmi@nvidia.com \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.