From: SeongJae Park <sj@kernel.org>
To: David Hunter <david.hunter.linux@gmail.com>
Cc: SeongJae Park <sj@kernel.org>, Shuah Khan <shuah@kernel.org>,
Allison Henderson <allison.henderson@oracle.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
damon@lists.linux.dev, linux-mm@kvack.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
rds-devel@oss.oracle.com, javier.carrasco.cruz@gmail.com
Subject: Re: [PATCH v1 1/1] selftests: set executable bit
Date: Tue, 24 Sep 2024 11:47:18 -0700 [thread overview]
Message-ID: <20240924184719.686727-1-sj@kernel.org> (raw)
In-Reply-To: <20240924175500.17212-1-david.hunter.linux@gmail.com>
Hi David,
On Tue, 24 Sep 2024 13:54:57 -0400 David Hunter <david.hunter.linux@gmail.com> wrote:
> Turn on the executable bit for the following script files. These scripts
> are set to TEST_PROGS in their respective Makefiles, but currently, when
> these tests are run, a warning occurs:
>
> # Warning: <file> is not executable
Thank you so much for finding this issue and sending this nice fix!
>
> Signed-off-by: David Hunter <david.hunter.linux@gmail.com>
> ---
> tools/testing/selftests/damon/damon_nr_regions.py | 0
> tools/testing/selftests/damon/damos_apply_interval.py | 0
> tools/testing/selftests/damon/damos_quota.py | 0
> tools/testing/selftests/damon/damos_quota_goal.py | 0
> tools/testing/selftests/damon/damos_tried_regions.py | 0
> tools/testing/selftests/damon/debugfs_target_ids_pid_leak.sh | 0
> .../damon/debugfs_target_ids_read_before_terminate_race.sh | 0
> .../selftests/damon/sysfs_update_schemes_tried_regions_hang.py | 0
> .../damon/sysfs_update_schemes_tried_regions_wss_estimation.py | 0
> tools/testing/selftests/net/rds/test.py | 0
> 10 files changed, 0 insertions(+), 0 deletions(-)
> mode change 100644 => 100755 tools/testing/selftests/damon/damon_nr_regions.py
> mode change 100644 => 100755 tools/testing/selftests/damon/damos_apply_interval.py
> mode change 100644 => 100755 tools/testing/selftests/damon/damos_quota.py
> mode change 100644 => 100755 tools/testing/selftests/damon/damos_quota_goal.py
> mode change 100644 => 100755 tools/testing/selftests/damon/damos_tried_regions.py
> mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_target_ids_pid_leak.sh
> mode change 100644 => 100755 tools/testing/selftests/damon/debugfs_target_ids_read_before_terminate_race.sh
> mode change 100644 => 100755 tools/testing/selftests/damon/sysfs_update_schemes_tried_regions_hang.py
> mode change 100644 => 100755 tools/testing/selftests/damon/sysfs_update_schemes_tried_regions_wss_estimation.py
> mode change 100644 => 100755 tools/testing/selftests/net/rds/test.py
However, a very similar fix has already posted [1] and merged [2] into the
mainline. So, apparently there was a trivial race. I'm looking forward to
your next patches for DAMON, though!
[1] https://lore.kernel.org/20240827030336.7930-4-sj@kernel.org
[2] https://github.com/torvalds/linux/commit/8c211412c5dffd090eaea5ee033cd729f8e5f873
Thanks,
SJ
[...]
next prev parent reply other threads:[~2024-09-24 18:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-24 17:54 [PATCH v1 1/1] selftests: set executable bit David Hunter
2024-09-24 18:47 ` SeongJae Park [this message]
2024-09-25 5:51 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240924184719.686727-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=allison.henderson@oracle.com \
--cc=damon@lists.linux.dev \
--cc=davem@davemloft.net \
--cc=david.hunter.linux@gmail.com \
--cc=edumazet@google.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rds-devel@oss.oracle.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.