From: Rob Herring <robh@kernel.org>
To: Amit Kumar Mahapatra <amit.kumar-mahapatra@amd.com>
Cc: broonie@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
michal.simek@amd.com, linux-spi@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, git@amd.com,
amitrkcian2002@gmail.com
Subject: Re: [PATCH] dt-bindings: spi: zynqmp-qspi: Include two 'reg' properties only for the Zynq UltraScale QSPI
Date: Tue, 24 Sep 2024 17:02:45 -0500 [thread overview]
Message-ID: <20240924220245.GA367088-robh@kernel.org> (raw)
In-Reply-To: <20240923044543.2222-1-amit.kumar-mahapatra@amd.com>
On Mon, Sep 23, 2024 at 10:15:43AM +0530, Amit Kumar Mahapatra wrote:
> Linear mode is only supported by the Zynq UltraScale QSPI controller,
> so update the bindings to include two 'reg' properties only for the
> Zynq UltraScale QSPI controller.
>
> Signed-off-by: Amit Kumar Mahapatra <amit.kumar-mahapatra@amd.com>
> ---
> BRANCH: for-next
> ---
> .../bindings/spi/spi-zynqmp-qspi.yaml | 18 +++++++++++++++---
> 1 file changed, 15 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml b/Documentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml
> index e5199b109dad..2f1fca137cd3 100644
> --- a/Documentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml
> +++ b/Documentation/devicetree/bindings/spi/spi-zynqmp-qspi.yaml
> @@ -12,15 +12,27 @@ maintainers:
> allOf:
> - $ref: spi-controller.yaml#
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: xlnx,zynqmp-qspi-1.0
> + then:
> + properties:
> + reg:
> + maxItems: 2
Change this to 'minItems: 2'.
> +
> + else:
> + properties:
> + reg:
> + maxItems: 1
> +
> properties:
> compatible:
> enum:
> - xlnx,versal-qspi-1.0
> - xlnx,zynqmp-qspi-1.0
>
> - reg:
> - maxItems: 2
Keep this and add 'minItems: 1'
> -
> interrupts:
> maxItems: 1
>
> --
> 2.34.1
>
prev parent reply other threads:[~2024-09-24 22:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-23 4:45 [PATCH] dt-bindings: spi: zynqmp-qspi: Include two 'reg' properties only for the Zynq UltraScale QSPI Amit Kumar Mahapatra
2024-09-24 22:02 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240924220245.GA367088-robh@kernel.org \
--to=robh@kernel.org \
--cc=amit.kumar-mahapatra@amd.com \
--cc=amitrkcian2002@gmail.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=git@amd.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=michal.simek@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.