From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4603B1B85DD; Wed, 25 Sep 2024 10:31:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727260283; cv=none; b=nfc4wc6jusYYWSIqxluPaIbY6RXjQWlzjy0hYpcwZpaU9/2xz+KkoodRMcpJ3BsEj/HG+2qasEgbaeMtXeDQxE02u35wZ5W9DiGgvX9zKKvNwcWfuk0wrzl1vv6DGNCc+jGHktgOC7azptWEJX71H6QMkFyRBL2MKa8Sr4d6BSM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727260283; c=relaxed/simple; bh=azYpPCRc7Fpbb2pqhBjEq/yVygWme8hOTL1tIFJNaK0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Vt2AKogIar5jOr1OJCNZXSy/61CZ+eSf7FaDCbOpOXdQFaGgl+HylawSxWryNCzzj/OZv5+pfQTnZRXocpdMpdvezv/0f6aVVhfQJpbDZTlppqcQO9LwzYoGc+E+6jDUccNkpBsyvF20yPeWeWSxIvsJTd2ncMCwDibjWWb7v/o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=U7cRb2uC; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="U7cRb2uC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D09AC4CEC3; Wed, 25 Sep 2024 10:31:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727260282; bh=azYpPCRc7Fpbb2pqhBjEq/yVygWme8hOTL1tIFJNaK0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=U7cRb2uCSSGYlrTYOMEkLkLJVOvOsQCMhJxNZE4VBoyjE7Gq9o6SrUMyXirimlK0E McSps++Q2aGwn4KdkOIuSMCsy3CbLPaeiyfRhm/l01iDsfhIhlIPhnbfFUZFeYGsKJ aKZKMFqtRCSipuRw/1WbpImuw9tKxoyA/LAiu+FUsU6K+65c0JDfa5Bwd2UnBcyd5j 3QnFPplvGm09sqRiYq5x5mC5kji/QEtY0ec6n7UoL2uLBp6C8Iy2TEB0wSIVUkMeVP uy1dTuxxY8VG6XbzT6GVhe1lO/x4nUkht3sJu2EhRJWrPe4wYn0i5oqac34vFn3Rad ktd405WzhKKSA== Date: Wed, 25 Sep 2024 13:31:18 +0300 From: Leon Romanovsky To: Eduard Zingerman , David Howells , Christian Brauner Cc: Manu Bretelle , asmadeus@codewreck.org, ceph-devel@vger.kernel.org, christian@brauner.io, ericvh@kernel.org, hsiangkao@linux.alibaba.com, idryomov@gmail.com, jlayton@kernel.org, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org, marc.dionne@auristor.com, netdev@vger.kernel.org, netfs@lists.linux.dev, pc@manguebit.com, smfrench@gmail.com, sprasad@microsoft.com, tom@talpey.com, v9fs@lists.linux.dev, willy@infradead.org Subject: Re: [PATCH v2 19/25] netfs: Speed up buffered reading Message-ID: <20240925103118.GE967758@unreal> References: <20240923183432.1876750-1-chantr4@gmail.com> <20240814203850.2240469-20-dhowells@redhat.com> <1279816.1727220013@warthog.procyon.org.uk> <4b5621958a758da830c1cf09c6f6893aed371f9d.camel@gmail.com> Precedence: bulk X-Mailing-List: ceph-devel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4b5621958a758da830c1cf09c6f6893aed371f9d.camel@gmail.com> On Tue, Sep 24, 2024 at 05:01:13PM -0700, Eduard Zingerman wrote: > On Wed, 2024-09-25 at 00:20 +0100, David Howells wrote: > > Could you try the attached? It may help, though this fixes a bug in the > > write-side, not the read-side. > > > > Hi David, > > I tried this patch on top of bpf-next but behaviour seems unchanged, > dmesg is at [1]. > > [1] https://gist.github.com/eddyz87/ce45f90453980af6a5fadeb652e109f3 BTW, I'm hitting the same issue over Linus's tree now, but unfortunately there is no WA in my case as I don't have "cache=mmap" in rootflags. https://lore.kernel.org/all/20240924094809.GA1182241@unreal/#t It came to Linus with Christian Brauner's pull request. https://lore.kernel.org/all/20240913-vfs-netfs-39ef6f974061@brauner/ Thanks > > Thanks, > Eduard > > [...] > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 57E2AC369C8 for ; Wed, 25 Sep 2024 10:31:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lists.ozlabs.org; s=201707; t=1727260289; bh=cTW+pF/WV93ivfzeK06XW/Qx7uLYqRa9AejrWV4IA9Y=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=BbIfxbxttBrmCgt6KUUl58ak/x8uRU7ArNo0R368K5sumxvDt1AmuHHlciUy60lFe tGjAnBecBz3lqBTj7lSckexquLmFDdXJ65HQObUYkQik0Q2kWjDiAG23rbTtnwhGh2 Ugy5nXIX2B/zY56cOtRvoV9TT8dDRk0knxg6FnlwWIS8/IupUEStbBtd9gY9+hBSHR rUyD4crbiU/Ljdl0zzmvgHG5wmoqDyQ/ReagipT3koHfuzN6pkUdv/8NEYANx6Nz8b ULPbx+PIJSZ5B2pytNm5d6QV9EgM0r70OGhtInh4PUf0Ww67rLH7KbYlpnfRbf5CYK qrWj1YZNQVIFw== Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4XDCh10JNvz2yYn for ; Wed, 25 Sep 2024 20:31:29 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=147.75.193.91 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1727260286; cv=none; b=JTRtXcYsIyoVNse2rVm1Vbg/mJ4wjR4bPJ9q4pxIr1n5OLi70+asPmGpOSJ0s9aVog2TcfNULy4Asla6N27PQU/qDfKL2bIMcRVze0HL+bpqNRsUY9y6tmvtfGPP4uS4ucRGyJRrNepLX93Sw0QTuV5kPhaKdXEc1Z8eds6r43I50yTThAw6rRYQFsrrq0Hpusv3n77bSpPQdcsC2A45O0K2UsQ+iFDMTZ+8RfcOn7T6VDu9YGn/2TiivCUAtESQa25zaxLkXO0u9S1yQynLIj9ff5dF6CtB135AlR4PMz2lIFcXvCfTx2ZLI5UZh1KA8e+SInmeiFFT+vW4ZHtKpg== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1727260286; c=relaxed/relaxed; bh=cTW+pF/WV93ivfzeK06XW/Qx7uLYqRa9AejrWV4IA9Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=C1qsl4Rig0ia4YFxwO7UbTsfDtKe1m1uTjfuPyQ6FLiZaT82tCe0TPtn7TAcJVzDP2nrnf/VTBLiDg/Rj6EipN2I1STn51k11QZImUJLnnt9LNODoKUeTcmq/m1adPchL3usIWSjgZxQNayHqMa7Z26kDZEi3qRInaTV8msnk6l+Ngv/dnp5moKXrGfSxuyPzkwEDZT0HhWoLIyWbN0+c2PrJJyKmPrUqjY+ClmzMPSjXgd1WXM+CjF4WdLZyUhrhbdEWGoqTgX2RdP1lW8DSAIxDxjIAsGOrisw0RqclrwWJT7Go74hnlzjGOXrW5w+ObDoQT6LHWyWtDKviyq8Rw== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=U7cRb2uC; dkim-atps=neutral; spf=pass (client-ip=147.75.193.91; helo=nyc.source.kernel.org; envelope-from=leon@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=U7cRb2uC; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=147.75.193.91; helo=nyc.source.kernel.org; envelope-from=leon@kernel.org; receiver=lists.ozlabs.org) Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4XDCgy1hvFz2y8V for ; Wed, 25 Sep 2024 20:31:26 +1000 (AEST) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 134B7A43EA6; Wed, 25 Sep 2024 10:31:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D09AC4CEC3; Wed, 25 Sep 2024 10:31:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727260282; bh=azYpPCRc7Fpbb2pqhBjEq/yVygWme8hOTL1tIFJNaK0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=U7cRb2uCSSGYlrTYOMEkLkLJVOvOsQCMhJxNZE4VBoyjE7Gq9o6SrUMyXirimlK0E McSps++Q2aGwn4KdkOIuSMCsy3CbLPaeiyfRhm/l01iDsfhIhlIPhnbfFUZFeYGsKJ aKZKMFqtRCSipuRw/1WbpImuw9tKxoyA/LAiu+FUsU6K+65c0JDfa5Bwd2UnBcyd5j 3QnFPplvGm09sqRiYq5x5mC5kji/QEtY0ec6n7UoL2uLBp6C8Iy2TEB0wSIVUkMeVP uy1dTuxxY8VG6XbzT6GVhe1lO/x4nUkht3sJu2EhRJWrPe4wYn0i5oqac34vFn3Rad ktd405WzhKKSA== Date: Wed, 25 Sep 2024 13:31:18 +0300 To: Eduard Zingerman , David Howells , Christian Brauner Subject: Re: [PATCH v2 19/25] netfs: Speed up buffered reading Message-ID: <20240925103118.GE967758@unreal> References: <20240923183432.1876750-1-chantr4@gmail.com> <20240814203850.2240469-20-dhowells@redhat.com> <1279816.1727220013@warthog.procyon.org.uk> <4b5621958a758da830c1cf09c6f6893aed371f9d.camel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4b5621958a758da830c1cf09c6f6893aed371f9d.camel@gmail.com> X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Leon Romanovsky via Linux-erofs Reply-To: Leon Romanovsky Cc: asmadeus@codewreck.org, linux-mm@kvack.org, marc.dionne@auristor.com, linux-afs@lists.infradead.org, pc@manguebit.com, linux-cifs@vger.kernel.org, Manu Bretelle , willy@infradead.org, smfrench@gmail.com, hsiangkao@linux.alibaba.com, idryomov@gmail.com, sprasad@microsoft.com, tom@talpey.com, ceph-devel@vger.kernel.org, ericvh@kernel.org, christian@brauner.io, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, v9fs@lists.linux.dev, jlayton@kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, netfs@lists.linux.dev, linux-erofs@lists.ozlabs.org Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" On Tue, Sep 24, 2024 at 05:01:13PM -0700, Eduard Zingerman wrote: > On Wed, 2024-09-25 at 00:20 +0100, David Howells wrote: > > Could you try the attached? It may help, though this fixes a bug in the > > write-side, not the read-side. > > > > Hi David, > > I tried this patch on top of bpf-next but behaviour seems unchanged, > dmesg is at [1]. > > [1] https://gist.github.com/eddyz87/ce45f90453980af6a5fadeb652e109f3 BTW, I'm hitting the same issue over Linus's tree now, but unfortunately there is no WA in my case as I don't have "cache=mmap" in rootflags. https://lore.kernel.org/all/20240924094809.GA1182241@unreal/#t It came to Linus with Christian Brauner's pull request. https://lore.kernel.org/all/20240913-vfs-netfs-39ef6f974061@brauner/ Thanks > > Thanks, > Eduard > > [...] > >