All of lore.kernel.org
 help / color / mirror / Atom feed
From: Devarsh Thakkar <devarsht@ti.com>
To: <u-boot@lists.denx.de>, <trini@konsulko.com>, <bb@ti.com>
Cc: <sjg@chromium.org>, <agust@denx.de>, <praneeth@ti.com>,
	<nm@ti.com>, <vigneshr@ti.com>, <s-jain1@ti.com>,
	<r-donadkar@ti.com>, <j-humphreys@ti.com>,
	<ilias.apalodimas@linaro.org>, <xypron.glpk@gmx.de>,
	<akashi.tkhro@gmail.com>, <mkorpershoek@baylibre.com>,
	<eajames@linux.ibm.com>, <caleb.connolly@linaro.org>,
	<quentin.schulz@cherry.de>, <martinstolpe@gmail.com>,
	<iivanov@suse.de>, <n-jain1@ti.com>, <devarsht@ti.com>
Subject: [PATCH 1/3] boot/Kconfig: Add Video Kconfig as dependency for FDT_SIMPLEFB
Date: Wed, 25 Sep 2024 20:43:52 +0530	[thread overview]
Message-ID: <20240925151354.480704-2-devarsht@ti.com> (raw)
In-Reply-To: <20240925151354.480704-1-devarsht@ti.com>

The fdt_simplefb.c APIs rely on video-uclass APIs and structures to
fill/update framebuffer information, so compile it only when VIDEO
Kconfig is enabled, as otherwise below warning can be seen if VIDEO
Kconfig is disabled:

"boot/fdt_simplefb.c:96:12: warning: fdt_simplefb_enable_existing_node
defined but not used [-Wunused-function]
96 | static int fdt_simplefb_enable_existing_node(void *blob)"

Reported-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
Signed-off-by: Devarsh Thakkar <devarsht@ti.com>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
---
 boot/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/boot/Kconfig b/boot/Kconfig
index de277d2ba50d..56f2bb59a1e5 100644
--- a/boot/Kconfig
+++ b/boot/Kconfig
@@ -1583,6 +1583,7 @@ config FDT_FIXUP_PARTITIONS
 
 config FDT_SIMPLEFB
 	bool "FDT tools for simplefb support"
+	depends on VIDEO
 	help
 	  Enable the fdt tools to manage the simple fb nodes in device tree.
 	  These functions can be used by board to indicate to the OS
-- 
2.39.1


  reply	other threads:[~2024-09-25 15:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-25 15:13 [PATCH 0/3] Simple-framebuffer node related updates Devarsh Thakkar
2024-09-25 15:13 ` Devarsh Thakkar [this message]
2024-09-25 15:13 ` [PATCH 2/3] boot: fdt_simplefb: Remove conditional compilation checks for VIDEO Kconfig Devarsh Thakkar
2024-09-25 15:13 ` [PATCH 3/3] board: ti: am62x: evm: Update simple-framebuffer node in device-tree Devarsh Thakkar
2024-10-21 15:17 ` [PATCH 0/3] Simple-framebuffer node related updates Devarsh Thakkar
2024-10-21 20:20   ` Tom Rini
2024-10-22 20:19     ` Anatolij Gustschin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240925151354.480704-2-devarsht@ti.com \
    --to=devarsht@ti.com \
    --cc=agust@denx.de \
    --cc=akashi.tkhro@gmail.com \
    --cc=bb@ti.com \
    --cc=caleb.connolly@linaro.org \
    --cc=eajames@linux.ibm.com \
    --cc=iivanov@suse.de \
    --cc=ilias.apalodimas@linaro.org \
    --cc=j-humphreys@ti.com \
    --cc=martinstolpe@gmail.com \
    --cc=mkorpershoek@baylibre.com \
    --cc=n-jain1@ti.com \
    --cc=nm@ti.com \
    --cc=praneeth@ti.com \
    --cc=quentin.schulz@cherry.de \
    --cc=r-donadkar@ti.com \
    --cc=s-jain1@ti.com \
    --cc=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=vigneshr@ti.com \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.