From: Simon Horman <horms@kernel.org>
To: Kacper Ludwinski <kacper@ludwinski.dev>
Cc: davem@davemloft.net, kuba@kernel.org, vladimir.oltean@nxp.com,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] Fix issue related with assigning two diffrent vids to the same interface.
Date: Wed, 25 Sep 2024 20:15:37 +0100 [thread overview]
Message-ID: <20240925191537.GX4029621@kernel.org> (raw)
In-Reply-To: <20240925050539.1906-1-kacper@ludwinski.dev>
On Wed, Sep 25, 2024 at 02:05:39PM +0900, Kacper Ludwinski wrote:
> Fixes: 476a4f05d9b8 ("selftests: forwarding: add a no_forwarding.sh test")
> Signed-off-by: Kacper Ludwinski <kacper@ludwinski.dev>
> ---
> tools/testing/selftests/net/forwarding/no_forwarding.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
...
Hi Kacper,
Thanks for your patch.
Some feedback in process:
* Please do not post updated versions of patches within 24h of each
other.
* Please do post new versions of patches in new threads,
with appropriate versions in the subject (v2 in this case).
And some text under the scissors ('---') describing that the change is.
b4 will handle this for you.
* Please include some text in the commit message,
in this case describing the problem that is being resolved.
* Please tag patches for Networking as being targeted at either
the net or net-next trees.
Subject: [PATCH net v2] ...
* Please refer to git history and include an appropriate prefix
in the subject of the patch. In this case it looks like
it should be 'selftests: forwarding:'
Subject: [PATCH net v2] selftests: forwarding: ...
* Please consider reading the netdev maintainers process guide
https://docs.kernel.org/process/maintainer-netdev.html
Lastly, there is a spelling error in the subject.
checkpatch.pl --codespell flagged this.
--
pw-bot: changes-requested
next prev parent reply other threads:[~2024-09-25 19:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-25 4:37 [PATCH] Fix issue related with assigning two diffrent vids to the same interface Kacper Ludwinski
2024-09-25 5:05 ` Kacper Ludwinski
2024-09-25 19:15 ` Simon Horman [this message]
2024-09-26 2:12 ` Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240925191537.GX4029621@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=kacper@ludwinski.dev \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.