From: kernel test robot <lkp@intel.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [bvanassche:scsi-remove-slave-configure 3/5] drivers/scsi/ibmvscsi/ibmvscsi.c:1872: warning: Function parameter or struct member 'lim' not described in 'ibmvscsi_device_configure'
Date: Wed, 25 Sep 2024 21:22:41 +0800 [thread overview]
Message-ID: <202409252122.HTojAxIr-lkp@intel.com> (raw)
tree: https://github.com/bvanassche/linux scsi-remove-slave-configure
head: a5fded69fb0f4a49c1de7e7b4f83bc68a1cc99d3
commit: 74de896b64c86b8ef567baeaed830a36d9cb4ba9 [3/5] scsi: Convert SCSI drivers to .device_configure()
config: powerpc-allmodconfig (https://download.01.org/0day-ci/archive/20240925/202409252122.HTojAxIr-lkp@intel.com/config)
compiler: powerpc64-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240925/202409252122.HTojAxIr-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409252122.HTojAxIr-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/scsi/ibmvscsi/ibmvscsi.c:1043: warning: Excess function parameter 'done' description in 'ibmvscsi_queuecommand_lck'
>> drivers/scsi/ibmvscsi/ibmvscsi.c:1872: warning: Function parameter or struct member 'lim' not described in 'ibmvscsi_device_configure'
--
>> drivers/scsi/ibmvscsi/ibmvfc.c:3451: warning: Function parameter or struct member 'lim' not described in 'ibmvfc_device_configure'
vim +1872 drivers/scsi/ibmvscsi/ibmvscsi.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 1861
0979c84b4affaf Robert Jennings 2007-03-29 1862 /**
74de896b64c86b Bart Van Assche 2024-07-12 1863 * ibmvscsi_device_configure: Set the "allow_restart" flag for each disk.
0979c84b4affaf Robert Jennings 2007-03-29 1864 * @sdev: struct scsi_device device to configure
0979c84b4affaf Robert Jennings 2007-03-29 1865 *
0979c84b4affaf Robert Jennings 2007-03-29 1866 * Enable allow_restart for a device if it is a disk. Adjust the
0979c84b4affaf Robert Jennings 2007-03-29 1867 * queue_depth here also as is required by the documentation for
0979c84b4affaf Robert Jennings 2007-03-29 1868 * struct scsi_host_template.
0979c84b4affaf Robert Jennings 2007-03-29 1869 */
74de896b64c86b Bart Van Assche 2024-07-12 1870 static int ibmvscsi_device_configure(struct scsi_device *sdev,
74de896b64c86b Bart Van Assche 2024-07-12 1871 struct queue_limits *lim)
0979c84b4affaf Robert Jennings 2007-03-29 @1872 {
0979c84b4affaf Robert Jennings 2007-03-29 1873 struct Scsi_Host *shost = sdev->host;
0979c84b4affaf Robert Jennings 2007-03-29 1874 unsigned long lock_flags = 0;
0979c84b4affaf Robert Jennings 2007-03-29 1875
0979c84b4affaf Robert Jennings 2007-03-29 1876 spin_lock_irqsave(shost->host_lock, lock_flags);
d1a357fcc8348d Brian King 2007-10-25 1877 if (sdev->type == TYPE_DISK) {
0979c84b4affaf Robert Jennings 2007-03-29 1878 sdev->allow_restart = 1;
e1a5ce5b88d063 Robert Jennings 2009-06-08 1879 blk_queue_rq_timeout(sdev->request_queue, 120 * HZ);
d1a357fcc8348d Brian King 2007-10-25 1880 }
0979c84b4affaf Robert Jennings 2007-03-29 1881 spin_unlock_irqrestore(shost->host_lock, lock_flags);
0979c84b4affaf Robert Jennings 2007-03-29 1882 return 0;
0979c84b4affaf Robert Jennings 2007-03-29 1883 }
0979c84b4affaf Robert Jennings 2007-03-29 1884
:::::: The code at line 1872 was first introduced by commit
:::::: 0979c84b4affaf924a894380dd0069638b64de03 [SCSI] ibmvscsi: add slave_configure to allow device restart
:::::: TO: Robert Jennings <rcj@linux.vnet.ibm.com>
:::::: CC: James Bottomley <jejb@mulgrave.il.steeleye.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2024-09-25 13:23 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202409252122.HTojAxIr-lkp@intel.com \
--to=lkp@intel.com \
--cc=bvanassche@acm.org \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.