From: kernel test robot <lkp@intel.com>
To: "Yikai Tsai" <yikai.tsai.wiwynn@gmail.com>,
patrick@stwcx.xyz, "Jean Delvare" <jdelvare@suse.com>,
"Guenter Roeck" <linux@roeck-us.net>,
"Jonathan Corbet" <corbet@lwn.net>,
"Carsten Spieß" <mail@carsten-spiess.de>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Magnus Damm" <magnus.damm@gmail.com>
Cc: oe-kbuild-all@lists.linux.dev,
Yikai Tsai <yikai.tsai.wiwynn@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v7 2/2] hwmon: (isl28022) new driver for ISL28022 power monitor
Date: Wed, 25 Sep 2024 22:24:51 +0800 [thread overview]
Message-ID: <202409252223.s09tP6IL-lkp@intel.com> (raw)
In-Reply-To: <20240925031131.14645-3-yikai.tsai.wiwynn@gmail.com>
Hi Yikai,
kernel test robot noticed the following build warnings:
[auto build test WARNING on groeck-staging/hwmon-next]
[also build test WARNING on linus/master v6.11 next-20240925]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Yikai-Tsai/dt-bindings-hwmon-add-renesas-isl28022/20240925-111332
base: https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
patch link: https://lore.kernel.org/r/20240925031131.14645-3-yikai.tsai.wiwynn%40gmail.com
patch subject: [PATCH v7 2/2] hwmon: (isl28022) new driver for ISL28022 power monitor
config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20240925/202409252223.s09tP6IL-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240925/202409252223.s09tP6IL-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409252223.s09tP6IL-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/hwmon/isl28022.c: In function 'isl28022_read_properties':
>> drivers/hwmon/isl28022.c:396:36: warning: passing argument 2 of 'dev_err_probe' makes integer from pointer without a cast [-Wint-conversion]
396 | dev_err_probe(dev, "renesas,shunt-range-microvolt invalid value %d\n", val);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| |
| char *
In file included from include/linux/device.h:15,
from include/linux/acpi.h:14,
from include/linux/i2c.h:13,
from drivers/hwmon/isl28022.c:11:
include/linux/dev_printk.h:278:64: note: expected 'int' but argument is of type 'char *'
278 | __printf(3, 4) int dev_err_probe(const struct device *dev, int err, const char *fmt, ...);
| ~~~~^~~
>> drivers/hwmon/isl28022.c:396:88: warning: passing argument 3 of 'dev_err_probe' makes pointer from integer without a cast [-Wint-conversion]
396 | dev_err_probe(dev, "renesas,shunt-range-microvolt invalid value %d\n", val);
| ^~~
| |
| u32 {aka unsigned int}
include/linux/dev_printk.h:278:81: note: expected 'const char *' but argument is of type 'u32' {aka 'unsigned int'}
278 | __printf(3, 4) int dev_err_probe(const struct device *dev, int err, const char *fmt, ...);
| ~~~~~~~~~~~~^~~
drivers/hwmon/isl28022.c:406:36: warning: passing argument 2 of 'dev_err_probe' makes integer from pointer without a cast [-Wint-conversion]
406 | dev_err_probe(dev, "renesas,average-samples invalid value %d\n", val);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| |
| char *
include/linux/dev_printk.h:278:64: note: expected 'int' but argument is of type 'char *'
278 | __printf(3, 4) int dev_err_probe(const struct device *dev, int err, const char *fmt, ...);
| ~~~~^~~
drivers/hwmon/isl28022.c:406:82: warning: passing argument 3 of 'dev_err_probe' makes pointer from integer without a cast [-Wint-conversion]
406 | dev_err_probe(dev, "renesas,average-samples invalid value %d\n", val);
| ^~~
| |
| u32 {aka unsigned int}
include/linux/dev_printk.h:278:81: note: expected 'const char *' but argument is of type 'u32' {aka 'unsigned int'}
278 | __printf(3, 4) int dev_err_probe(const struct device *dev, int err, const char *fmt, ...);
| ~~~~~~~~~~~~^~~
drivers/hwmon/isl28022.c:414:28: warning: passing argument 2 of 'dev_err_probe' makes integer from pointer without a cast [-Wint-conversion]
414 | dev_err_probe(dev, "renesas,shunt-resistor-microvolt invalid value %d\n", data->shunt);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| |
| char *
include/linux/dev_printk.h:278:64: note: expected 'int' but argument is of type 'char *'
278 | __printf(3, 4) int dev_err_probe(const struct device *dev, int err, const char *fmt, ...);
| ~~~~^~~
drivers/hwmon/isl28022.c:414:87: warning: passing argument 3 of 'dev_err_probe' makes pointer from integer without a cast [-Wint-conversion]
414 | dev_err_probe(dev, "renesas,shunt-resistor-microvolt invalid value %d\n", data->shunt);
| ~~~~^~~~~~~
| |
| u32 {aka unsigned int}
include/linux/dev_printk.h:278:81: note: expected 'const char *' but argument is of type 'u32' {aka 'unsigned int'}
278 | __printf(3, 4) int dev_err_probe(const struct device *dev, int err, const char *fmt, ...);
| ~~~~~~~~~~~~^~~
vim +/dev_err_probe +396 drivers/hwmon/isl28022.c
346
347 /*
348 * read property values and make consistency checks.
349 *
350 * following values for shunt range and resistor are allowed:
351 * 40 mV -> gain 1, shunt min. 800 micro ohms
352 * 80 mV -> gain 2, shunt min. 1600 micro ohms
353 * 160 mV -> gain 4, shunt min. 3200 micro ohms
354 * 320 mV -> gain 8, shunt min. 6400 micro ohms
355 */
356 static int isl28022_read_properties(struct device *dev, struct isl28022_data *data)
357 {
358 u32 val;
359 int err;
360
361 err = device_property_read_u32(dev, "shunt-resistor-micro-ohms", &val);
362 if (err == -EINVAL)
363 val = 10000;
364 else if (err < 0)
365 return err;
366 data->shunt = val;
367
368 err = device_property_read_u32(dev, "renesas,shunt-range-microvolt", &val);
369 if (err == -EINVAL)
370 val = 320000;
371 else if (err < 0)
372 return err;
373
374 switch (val) {
375 case 40000:
376 data->gain = 1;
377 if (data->shunt < 800)
378 goto shunt_invalid;
379 break;
380 case 80000:
381 data->gain = 2;
382 if (data->shunt < 1600)
383 goto shunt_invalid;
384 break;
385 case 160000:
386 data->gain = 4;
387 if (data->shunt < 3200)
388 goto shunt_invalid;
389 break;
390 case 320000:
391 data->gain = 8;
392 if (data->shunt < 6400)
393 goto shunt_invalid;
394 break;
395 default:
> 396 dev_err_probe(dev, "renesas,shunt-range-microvolt invalid value %d\n", val);
397 return -EINVAL;
398 }
399
400 err = device_property_read_u32(dev, "renesas,average-samples", &val);
401 if (err == -EINVAL)
402 val = 1;
403 else if (err < 0)
404 return err;
405 if (val > 128 || hweight32(val) != 1) {
406 dev_err_probe(dev, "renesas,average-samples invalid value %d\n", val);
407 return -EINVAL;
408 }
409 data->average = val;
410
411 return 0;
412
413 shunt_invalid:
414 dev_err_probe(dev, "renesas,shunt-resistor-microvolt invalid value %d\n", data->shunt);
415 return -EINVAL;
416 }
417
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2024-09-25 14:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-25 3:11 [PATCH v7 0/2] hwmon: (isl28022) new driver for ISL28022 power monitor Yikai Tsai
2024-09-25 3:11 ` [PATCH v7 1/2] dt-bindings: hwmon: add renesas,isl28022 Yikai Tsai
2024-09-25 7:37 ` Krzysztof Kozlowski
2024-10-02 6:46 ` Yikai Tsai
2024-09-25 3:11 ` [PATCH v7 2/2] hwmon: (isl28022) new driver for ISL28022 power monitor Yikai Tsai
2024-09-25 7:18 ` Geert Uytterhoeven
2024-09-25 14:24 ` kernel test robot [this message]
2024-09-25 14:35 ` kernel test robot
2024-09-26 0:50 ` kernel test robot
2024-09-27 4:47 ` kernel test robot
2024-09-27 22:08 ` kernel test robot
2024-09-25 7:35 ` [PATCH v7 0/2] " Krzysztof Kozlowski
2024-10-02 6:42 ` Yikai Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202409252223.s09tP6IL-lkp@intel.com \
--to=lkp@intel.com \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=jdelvare@suse.com \
--cc=krzk@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=magnus.damm@gmail.com \
--cc=mail@carsten-spiess.de \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=patrick@stwcx.xyz \
--cc=robh@kernel.org \
--cc=yikai.tsai.wiwynn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.