From: chenqiwu <qiwuchen55@gmail.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: chenqiwu <qiwuchen55@gmail.com>,
corbet@lwn.net, catalin.marinas@arm.com, will@kernel.org,
paulmck@kernel.org, akpm@linux-foundation.org,
linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org
Subject: Re: [PATCH v4 1/2] panic: add option to dump task maps info in panic_print
Date: Thu, 26 Sep 2024 11:30:45 +0800 [thread overview]
Message-ID: <20240926033045.GA3811@rlk> (raw)
In-Reply-To: <20240925121957.GB26882@redhat.com>
On Wed, Sep 25, 2024 at 02:19:58PM +0200, Oleg Nesterov wrote:
> On 09/25, chenqiwu wrote:
> >
> > On Tue, Sep 24, 2024 at 01:33:54PM +0200, Oleg Nesterov wrote:
> > >
> > > > + if (path) {
> > > > + name = d_path(path, name_buf, sizeof(name_buf));
> > > > + name = IS_ERR(name) ? "?" : name;
> > >
> > I think this is an easier way to get file path name which deals with IS_ERR(name) case.
> > > perhaps this needs mangle_path() ...
>
> Sorry, I don't understand your reply...
>
I means we can dump the file path name by d_path() directly without escaping "\n"
by mangle_path(). I try to test the patch in arm64 qemu, it can show the same file
path name as /proc/$pid/maps.
Thanks
Qiwu
next prev parent reply other threads:[~2024-09-26 3:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-24 7:43 [PATCH v4 1/2] panic: add option to dump task maps info in panic_print qiwu.chen
2024-09-24 7:43 ` [PATCH v4 2/2] arm64: show signal info for global init qiwu.chen
2024-09-24 18:36 ` Oleg Nesterov
2024-09-25 3:54 ` chenqiwu
2024-09-25 12:05 ` Oleg Nesterov
2024-09-26 10:12 ` chenqiwu
2024-09-24 11:33 ` [PATCH v4 1/2] panic: add option to dump task maps info in panic_print Oleg Nesterov
2024-09-25 8:27 ` chenqiwu
2024-09-25 12:19 ` Oleg Nesterov
2024-09-26 3:30 ` chenqiwu [this message]
2024-09-24 15:06 ` kernel test robot
2024-09-24 15:06 ` kernel test robot
2024-10-01 11:23 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240926033045.GA3811@rlk \
--to=qiwuchen55@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=oleg@redhat.com \
--cc=paulmck@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.