From: Claus Stovgaard <claus.stovgaard@gmail.com>
To: openembedded-core@lists.openembedded.org
Cc: Claus Stovgaard <claus.stovgaard@gmail.com>
Subject: [master][scarthgap][PATCH] lib/oe/package-manager: optimize install_complementary
Date: Thu, 26 Sep 2024 11:17:31 +0200 [thread overview]
Message-ID: <20240926091731.2008047-1-claus.stovgaard@gmail.com> (raw)
We are rewriting the globs variable, so it can't be None, but rather a
string. E.g. the lines above.
if globs is None:
globs = self.d.getVar('IMAGE_INSTALL_COMPLEMENTARY')
As globs is now a string, we need to test for empty string instead of
compare with None.
Signed-off-by: Claus Stovgaard <claus.stovgaard@gmail.com>
---
meta/lib/oe/package_manager/__init__.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/lib/oe/package_manager/__init__.py b/meta/lib/oe/package_manager/__init__.py
index d3b2317894..1d923c436e 100644
--- a/meta/lib/oe/package_manager/__init__.py
+++ b/meta/lib/oe/package_manager/__init__.py
@@ -365,7 +365,7 @@ class PackageManager(object, metaclass=ABCMeta):
for complementary_linguas in (self.d.getVar('IMAGE_LINGUAS_COMPLEMENTARY') or "").split():
globs += (" " + complementary_linguas) % lang
- if globs is None:
+ if not globs:
return
# we need to write the list of installed packages to a file because the
--
2.45.2
next reply other threads:[~2024-09-26 9:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-26 9:17 Claus Stovgaard [this message]
2024-09-26 9:51 ` [OE-core] [master][scarthgap][PATCH] lib/oe/package-manager: optimize install_complementary Alexander Kanavin
2024-09-26 15:01 ` claus.stovgaard
2024-09-26 15:12 ` Alexander Kanavin
2024-09-26 20:41 ` Claus Stovgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240926091731.2008047-1-claus.stovgaard@gmail.com \
--to=claus.stovgaard@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.