From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a17:505:5b18:b0:1be9:327d:8ee3 with SMTP id ox24csp893640njb; Thu, 26 Sep 2024 05:09:16 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCW0YbrIWPw/kj2D0sJNpCxOSTW5Zs4Jc5Kxs0DnU7gyRhY2u3IQNNk8PNcYjEgcwUGM5z4B9CiUQgf3NA==@linaro.org X-Google-Smtp-Source: AGHT+IFwwwCEWsswpf/u2Zx4WGsaoCCjWyJityEdsGzB+dKs6H6Iu81pIJIlDrzqrGWIoErIgQ4V X-Received: by 2002:a05:6a20:7490:b0:1cc:e71d:ea10 with SMTP id adf61e73a8af0-1d4ebe73f00mr4770369637.14.1727352556256; Thu, 26 Sep 2024 05:09:16 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1727352556; cv=pass; d=google.com; s=arc-20240605; b=I/cze0wOEhkN59IwZtlY3KIcgoWbIxGmMmfvKAUiRNQpF19rbsnKE+lxNetaBNIZVS DTpeuPKf58qpkIoB9FyYISbQzzYZRpw/OsdmvZf5OEtK/DMYBoWW24+qc+wQ3NQo953R QowClae6Pn2zI/DLwo9jxkopGvSbIaeVWslArAqH1ASHQpj3dZog9bBOa7Fp2ITrXLuh qjgVbxuCXdTsvIlEpSv7iD7EGOaVV6aJ4fGWZxKcXMGdkJ3cmos55TJhosUgXhv/cB2c S/8hOps3OTTu1HVf0hdfXAQFUTco4rv1Cw/HHl7pVKK27VXXNGpAceEJ2KtB44M5dXkW nCFA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:organization:references :in-reply-to:message-id:subject:cc:to:from:date; bh=8nN14meJ3iV5eqowM4vuk00tpD4pWFqzSC6rn+izipE=; fh=sk20niJjP+LyGcAC6rY5I61AlgNCIPpR6UIhxIWLYTI=; b=XLrw8kZpE+1f83cC0JwAPPlAOWFE2aYTP+e/W1483Fk2g2XWPL/Fb+QjJmobrtm5gy uEWYhN4cpsQ3sT/d9xn9hgzlgXcdtH9Ay1G9tlcUNHRJi2r2XUCah90ECs4SKFbzpMJv Nvx5LAGpmqt1s6zzfkiVuHCTxjPDCEZVJYXsqYc5vP1oBPEb5bZCysblLw2QqePLdscL vnJw6EKyCZh9NI5HBp7J6XS08hqc+JNomAOgbvakoCZ2hHrmQFNXk9YBpuD6CM7KoT4B IjAGkTV3VqjlPlBjim/6Ra3evNrTxmGWaNfsQhc7w74MYEyZENSw0oGk4CoiwSP3VQoO WmrA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=huawei.com dmarc=pass fromdomain=huawei.com); spf=pass (google.com: domain of linux-kernel+bounces-340428-alex.bennee=linaro.org@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-340428-alex.bennee=linaro.org@vger.kernel.org"; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id 41be03b00d2f7-7e6b7cbec20si6822994a12.608.2024.09.26.05.09.16 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Sep 2024 05:09:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-340428-alex.bennee=linaro.org@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=huawei.com dmarc=pass fromdomain=huawei.com); spf=pass (google.com: domain of linux-kernel+bounces-340428-alex.bennee=linaro.org@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-340428-alex.bennee=linaro.org@vger.kernel.org"; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id A5AB728467B for ; Thu, 26 Sep 2024 12:09:15 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 54377171088; Thu, 26 Sep 2024 12:09:15 +0000 (UTC) Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6BE0216DEDF for ; Thu, 26 Sep 2024 12:09:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727352555; cv=none; b=tXBHRtoRF8SFe/zYDv1fmAm7yqo6DQqGI1AmvWilyZ2bbY4M/rHD4kNUFVGYvi1i1BdZh3r6z1LQeXy+XQ4+iV3WOjgn+x+Y2864/jHjsQUaQgYVEDb8kEDYWK3XVN+kJ/ZlOnX0m+qgWa2ZgPXeUgOIWHgDwPDP8nrPOn0ggpM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727352555; c=relaxed/simple; bh=Y+NCjuqiiHimuCgBNQCCYkDtQs9asC7+ph3I9KV12zo=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=KdqLH+0Q7jZZh1PscZIauATdo+b/jeuQk7DBaGLbEp6kBc3c0ehWmn89M6OnPrA5LlTjA1ne8bCTxUnV/v+BVW67kr6ffQuNO+o5GrwughJVZAURmmO2B9ts6/83nRTefXKvno62GqTFBORykFOcotV2RAd0KEASsBDwi++Wst0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=Huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4XDsnc3Rrhz6J6dn; Thu, 26 Sep 2024 20:08:36 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 881B7140C98; Thu, 26 Sep 2024 20:09:11 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 26 Sep 2024 14:09:10 +0200 Date: Thu, 26 Sep 2024 13:09:09 +0100 From: Jonathan Cameron To: Mauro Carvalho Chehab CC: Igor Mammedov , Shiju Jose , "Michael S. Tsirkin" , Ani Sinha , Dongjiu Geng , , , Subject: Re: [PATCH 12/15] acpi/ghes: don't crash QEMU if ghes GED is not found Message-ID: <20240926130909.00006135@Huawei.com> In-Reply-To: References: Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml500004.china.huawei.com (7.191.163.9) To frapeml500008.china.huawei.com (7.182.85.71) X-TUID: qUl8CoIS5KSw On Wed, 25 Sep 2024 06:04:17 +0200 Mauro Carvalho Chehab wrote: > Instead, produce an error and continue working > > Signed-off-by: Mauro Carvalho Chehab Make sense as defense in depth. Can we actually hit this for existing systems, or is the injection stuff disabled if the ged isn't configured? Jonathan > --- > hw/acpi/ghes.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/hw/acpi/ghes.c b/hw/acpi/ghes.c > index 3af1cd16d4d7..209095f67e9a 100644 > --- a/hw/acpi/ghes.c > +++ b/hw/acpi/ghes.c > @@ -418,7 +418,10 @@ void ghes_record_cper_errors(const void *cper, size_t len, > > acpi_ged_state = ACPI_GED(object_resolve_path_type("", TYPE_ACPI_GED, > NULL)); > - g_assert(acpi_ged_state); > + if (!acpi_ged_state) { > + error_setg(errp, "Can't find ACPI_GED object"); > + return; > + } > ags = &acpi_ged_state->ghes_state; > > get_ghes_offsets(le64_to_cpu(ags->ghes_addr_le), From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CB6EACCFA1F for ; Thu, 26 Sep 2024 12:09:37 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1stnJ9-0006nL-WC; Thu, 26 Sep 2024 08:09:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stnJ5-0006T7-4X; Thu, 26 Sep 2024 08:09:15 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1stnJ3-0001P7-Lg; Thu, 26 Sep 2024 08:09:14 -0400 Received: from mail.maildlp.com (unknown [172.18.186.216]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4XDsnc3Rrhz6J6dn; Thu, 26 Sep 2024 20:08:36 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 881B7140C98; Thu, 26 Sep 2024 20:09:11 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 26 Sep 2024 14:09:10 +0200 Date: Thu, 26 Sep 2024 13:09:09 +0100 To: Mauro Carvalho Chehab CC: Igor Mammedov , Shiju Jose , "Michael S. Tsirkin" , Ani Sinha , Dongjiu Geng , , , Subject: Re: [PATCH 12/15] acpi/ghes: don't crash QEMU if ghes GED is not found Message-ID: <20240926130909.00006135@Huawei.com> In-Reply-To: References: Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml500004.china.huawei.com (7.191.163.9) To frapeml500008.china.huawei.com (7.182.85.71) Received-SPF: pass client-ip=185.176.79.56; envelope-from=jonathan.cameron@huawei.com; helo=frasgout.his.huawei.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Jonathan Cameron From: Jonathan Cameron via Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Wed, 25 Sep 2024 06:04:17 +0200 Mauro Carvalho Chehab wrote: > Instead, produce an error and continue working > > Signed-off-by: Mauro Carvalho Chehab Make sense as defense in depth. Can we actually hit this for existing systems, or is the injection stuff disabled if the ged isn't configured? Jonathan > --- > hw/acpi/ghes.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/hw/acpi/ghes.c b/hw/acpi/ghes.c > index 3af1cd16d4d7..209095f67e9a 100644 > --- a/hw/acpi/ghes.c > +++ b/hw/acpi/ghes.c > @@ -418,7 +418,10 @@ void ghes_record_cper_errors(const void *cper, size_t len, > > acpi_ged_state = ACPI_GED(object_resolve_path_type("", TYPE_ACPI_GED, > NULL)); > - g_assert(acpi_ged_state); > + if (!acpi_ged_state) { > + error_setg(errp, "Can't find ACPI_GED object"); > + return; > + } > ags = &acpi_ged_state->ghes_state; > > get_ghes_offsets(le64_to_cpu(ags->ghes_addr_le),