Re: [RFC PATCH] capabilities: remove cap_mmap_file()

["Serge E. Hallyn" <serge@hallyn.com>]

On Wed, Sep 25, 2024 at 12:45:20PM -0700, Casey Schaufler wrote:
> On 9/25/2024 12:20 PM, Paul Moore wrote:
> > The cap_mmap_file() LSM callback returns the default value for the
> > security_mmap_file() LSM hook and can be safely removed.
> >
> > Signed-off-by: Paul Moore <paul@paul-moore.com>
> 
> Reviewed-by: Casey Schaufler <casey@schaufler-ca.com>

Reviewed-by: Serge Hallyn <serge@hallyn.com>

> 
> > ---
> >  security/commoncap.c | 7 -------
> >  1 file changed, 7 deletions(-)
> >
> > diff --git a/security/commoncap.c b/security/commoncap.c
> > index cefad323a0b1..3d103069903b 100644
> > --- a/security/commoncap.c
> > +++ b/security/commoncap.c
> > @@ -1428,12 +1428,6 @@ int cap_mmap_addr(unsigned long addr)
> >  	return ret;
> >  }
> >  
> > -int cap_mmap_file(struct file *file, unsigned long reqprot,
> > -		  unsigned long prot, unsigned long flags)
> > -{
> > -	return 0;
> > -}
> > -
> >  #ifdef CONFIG_SECURITY
> >  
> >  static const struct lsm_id capability_lsmid = {
> > @@ -1453,7 +1447,6 @@ static struct security_hook_list capability_hooks[] __ro_after_init = {
> >  	LSM_HOOK_INIT(inode_killpriv, cap_inode_killpriv),
> >  	LSM_HOOK_INIT(inode_getsecurity, cap_inode_getsecurity),
> >  	LSM_HOOK_INIT(mmap_addr, cap_mmap_addr),
> > -	LSM_HOOK_INIT(mmap_file, cap_mmap_file),
> >  	LSM_HOOK_INIT(task_fix_setuid, cap_task_fix_setuid),
> >  	LSM_HOOK_INIT(task_prctl, cap_task_prctl),
> >  	LSM_HOOK_INIT(task_setscheduler, cap_task_setscheduler),