From: Jason Gunthorpe <jgg@nvidia.com>
To: Yi Liu <yi.l.liu@intel.com>
Cc: joro@8bytes.org, kevin.tian@intel.com, baolu.lu@linux.intel.com,
alex.williamson@redhat.com, eric.auger@redhat.com,
nicolinc@nvidia.com, kvm@vger.kernel.org,
chao.p.peng@linux.intel.com, iommu@lists.linux.dev,
zhenzhong.duan@intel.com, linux-kselftest@vger.kernel.org,
vasant.hegde@amd.com
Subject: Re: [PATCH v3 4/4] iommufd: Extend IOMMU_GET_HW_INFO to report PASID capability
Date: Thu, 26 Sep 2024 16:35:59 -0300 [thread overview]
Message-ID: <20240926193559.GN9417@nvidia.com> (raw)
In-Reply-To: <20240912131729.14951-5-yi.l.liu@intel.com>
On Thu, Sep 12, 2024 at 06:17:29AM -0700, Yi Liu wrote:
> @@ -1242,6 +1245,28 @@ int iommufd_get_hw_info(struct iommufd_ucmd *ucmd)
> if (device_iommu_capable(idev->dev, IOMMU_CAP_DIRTY_TRACKING))
> cmd->out_capabilities |= IOMMU_HW_CAP_DIRTY_TRACKING;
>
> + cmd->out_max_pasid_log2 = 0;
> +
> + if (dev_is_pci(idev->dev)) {
> + struct pci_dev *pdev = to_pci_dev(idev->dev);
> + int ctrl;
> +
> + if (pdev->is_virtfn)
> + pdev = pci_physfn(pdev);
Don't we do this twice now?
Let's just keep it in the pci core?
It looks Ok otherwise
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Jason
next prev parent reply other threads:[~2024-09-26 19:36 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-12 13:17 [PATCH v3 0/4] vfio-pci support pasid attach/detach Yi Liu
2024-09-12 13:17 ` [PATCH v3 1/4] ida: Add ida_find_first_range() Yi Liu
2024-09-12 15:11 ` Matthew Wilcox
2024-09-13 11:45 ` Yi Liu
2024-09-13 15:09 ` Matthew Wilcox
2024-09-14 4:16 ` Yi Liu
2024-09-26 19:11 ` Jason Gunthorpe
2024-09-30 7:49 ` Tian, Kevin
2024-09-12 13:17 ` [PATCH v3 2/4] vfio-iommufd: Support pasid [at|de]tach for physical VFIO devices Yi Liu
2024-09-26 19:13 ` Jason Gunthorpe
2024-09-12 13:17 ` [PATCH v3 3/4] vfio: Add VFIO_DEVICE_PASID_[AT|DE]TACH_IOMMUFD_PT Yi Liu
2024-09-26 19:16 ` Jason Gunthorpe
2024-09-30 7:55 ` Tian, Kevin
2024-10-01 12:11 ` Jason Gunthorpe
2024-10-12 13:49 ` Yi Liu
2024-10-14 15:49 ` Alex Williamson
2024-10-15 11:07 ` Yi Liu
2024-10-15 16:22 ` Alex Williamson
2024-10-16 3:35 ` Yi Liu
2024-10-16 16:11 ` Alex Williamson
2024-10-18 5:40 ` Yi Liu
2024-10-30 12:54 ` Yi Liu
2024-10-30 17:51 ` Alex Williamson
2024-10-31 7:23 ` Yi Liu
2024-09-12 13:17 ` [PATCH v3 4/4] iommufd: Extend IOMMU_GET_HW_INFO to report PASID capability Yi Liu
2024-09-26 19:35 ` Jason Gunthorpe [this message]
2024-09-27 3:08 ` Yi Liu
2024-09-30 8:03 ` Tian, Kevin
2024-10-22 10:08 ` Vasant Hegde
2024-10-28 6:41 ` Zhangfei Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240926193559.GN9417@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=baolu.lu@linux.intel.com \
--cc=chao.p.peng@linux.intel.com \
--cc=eric.auger@redhat.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=nicolinc@nvidia.com \
--cc=vasant.hegde@amd.com \
--cc=yi.l.liu@intel.com \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.