From: Jason Gunthorpe <jgg@nvidia.com>
To: "Margolin, Michael" <mrgolin@amazon.com>
Cc: leon@kernel.org, linux-rdma@vger.kernel.org, sleybo@amazon.com,
matua@amazon.com, gal.pressman@linux.dev,
kernel test robot <lkp@intel.com>,
Yehuda Yitschak <yehuday@amazon.com>,
Yonatan Nachum <ynachum@amazon.com>
Subject: Re: [PATCH] RDMA/efa: Fix node guid compiler warning
Date: Thu, 26 Sep 2024 19:34:00 -0300 [thread overview]
Message-ID: <20240926223400.GS9417@nvidia.com> (raw)
In-Reply-To: <08cf6d96-02f0-4974-ac69-b9a5184bfb20@amazon.com>
On Thu, Sep 26, 2024 at 11:03:57PM +0300, Margolin, Michael wrote:
>
> On 9/26/2024 5:54 PM, Jason Gunthorpe wrote:
> > CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
> >
> >
> >
> > On Thu, Sep 26, 2024 at 04:25:19PM +0300, Margolin, Michael wrote:
> >
> > > Actually that's wrong, the device always sets guid in BE order so no
> > > swap is needed in the driver in any case.
> > They you just mark it as _be64 in the struct and there is no reason
> > for the __force ?
> >
> > Jason
>
> That's probably the most correct way but I prefer to avoid introducing
> kernel specific types in a shared interface file.
?
what is a "shared interface file" ?
That doesn't sound like a linux thing
Jason
next prev parent reply other threads:[~2024-09-26 22:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-24 12:16 [PATCH] RDMA/efa: Fix node guid compiler warning Michael Margolin
2024-09-24 18:00 ` Jason Gunthorpe
2024-09-26 12:56 ` Margolin, Michael
2024-09-26 13:25 ` Margolin, Michael
2024-09-26 14:54 ` Jason Gunthorpe
2024-09-26 20:03 ` Margolin, Michael
2024-09-26 22:34 ` Jason Gunthorpe [this message]
2024-10-02 12:30 ` Margolin, Michael
2024-10-02 13:04 ` Jason Gunthorpe
2024-10-06 13:19 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240926223400.GS9417@nvidia.com \
--to=jgg@nvidia.com \
--cc=gal.pressman@linux.dev \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=lkp@intel.com \
--cc=matua@amazon.com \
--cc=mrgolin@amazon.com \
--cc=sleybo@amazon.com \
--cc=yehuday@amazon.com \
--cc=ynachum@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.