Re: [RFC PATCH] cleanup: make scoped_guard() to be return-friendly

[kernel test robot <lkp@intel.com>]

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20240926134347.19371-1-przemyslaw.kitszel@intel.com>
References: <20240926134347.19371-1-przemyslaw.kitszel@intel.com>
TO: Przemek Kitszel <przemyslaw.kitszel@intel.com>

Hi Przemek,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:

[auto build test WARNING on 151ac45348afc5b56baa584c7cd4876addf461ff]

url:    https://github.com/intel-lab-lkp/linux/commits/Przemek-Kitszel/cleanup-make-scoped_guard-to-be-return-friendly/20240926-214521
base:   151ac45348afc5b56baa584c7cd4876addf461ff
patch link:    https://lore.kernel.org/r/20240926134347.19371-1-przemyslaw.kitszel%40intel.com
patch subject: [RFC PATCH] cleanup: make scoped_guard() to be return-friendly
:::::: branch date: 20 hours ago
:::::: commit date: 20 hours ago
config: x86_64-randconfig-161-20240927 (https://download.01.org/0day-ci/archive/20240927/202409271754.FsBPrJQM-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-12) 11.3.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202409271754.FsBPrJQM-lkp@intel.com/

smatch warnings:
drivers/gpio/gpio-graniterapids.c:260 gnr_gpio_irq() warn: iterator 'i' not incremented

vim +/i +260 drivers/gpio/gpio-graniterapids.c

ecc4b1418e2399 Aapo Vienamo 2024-04-23  254  
ecc4b1418e2399 Aapo Vienamo 2024-04-23  255  static irqreturn_t gnr_gpio_irq(int irq, void *data)
ecc4b1418e2399 Aapo Vienamo 2024-04-23  256  {
ecc4b1418e2399 Aapo Vienamo 2024-04-23  257  	struct gnr_gpio *priv = data;
ecc4b1418e2399 Aapo Vienamo 2024-04-23  258  	unsigned int handled = 0;
ecc4b1418e2399 Aapo Vienamo 2024-04-23  259  
ecc4b1418e2399 Aapo Vienamo 2024-04-23 @260  	for (unsigned int i = 0; i < GNR_NUM_REGS; i++) {
ecc4b1418e2399 Aapo Vienamo 2024-04-23  261  		const void __iomem *reg = priv->reg_base + i * sizeof(u32);
ecc4b1418e2399 Aapo Vienamo 2024-04-23  262  		unsigned long pending;
ecc4b1418e2399 Aapo Vienamo 2024-04-23  263  		unsigned long enabled;
ecc4b1418e2399 Aapo Vienamo 2024-04-23  264  		unsigned int bit_idx;
ecc4b1418e2399 Aapo Vienamo 2024-04-23  265  
ecc4b1418e2399 Aapo Vienamo 2024-04-23  266  		scoped_guard(raw_spinlock, &priv->lock) {
ecc4b1418e2399 Aapo Vienamo 2024-04-23  267  			pending = readl(reg + GNR_GPI_STATUS_OFFSET);
ecc4b1418e2399 Aapo Vienamo 2024-04-23  268  			enabled = readl(reg + GNR_GPI_ENABLE_OFFSET);
ecc4b1418e2399 Aapo Vienamo 2024-04-23  269  		}
ecc4b1418e2399 Aapo Vienamo 2024-04-23  270  
ecc4b1418e2399 Aapo Vienamo 2024-04-23  271  		/* Only enabled interrupts */
ecc4b1418e2399 Aapo Vienamo 2024-04-23  272  		pending &= enabled;
ecc4b1418e2399 Aapo Vienamo 2024-04-23  273  
ecc4b1418e2399 Aapo Vienamo 2024-04-23  274  		for_each_set_bit(bit_idx, &pending, GNR_PINS_PER_REG) {
ecc4b1418e2399 Aapo Vienamo 2024-04-23  275  			unsigned int hwirq = i * GNR_PINS_PER_REG + bit_idx;
ecc4b1418e2399 Aapo Vienamo 2024-04-23  276  
ecc4b1418e2399 Aapo Vienamo 2024-04-23  277  			generic_handle_domain_irq(priv->gc.irq.domain, hwirq);
ecc4b1418e2399 Aapo Vienamo 2024-04-23  278  		}
ecc4b1418e2399 Aapo Vienamo 2024-04-23  279  
ecc4b1418e2399 Aapo Vienamo 2024-04-23  280  		handled += pending ? 1 : 0;
ecc4b1418e2399 Aapo Vienamo 2024-04-23  281  
ecc4b1418e2399 Aapo Vienamo 2024-04-23  282  	}
ecc4b1418e2399 Aapo Vienamo 2024-04-23  283  	return IRQ_RETVAL(handled);
ecc4b1418e2399 Aapo Vienamo 2024-04-23  284  }
ecc4b1418e2399 Aapo Vienamo 2024-04-23  285  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki