All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Shravya Kumbham <shravya.kumbham@xilinx.com>
Cc: oe-kbuild-all@lists.linux.dev, git@amd.com,
	Michal Simek <monstr@monstr.eu>,
	Suraj Gupta <suraj.gupta2@amd.com>,
	Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>
Subject: [xilinx-xlnx:xlnx_rebase_v6.6_LTS_2024.1_update 582/1001] drivers/net/ethernet/xilinx/xilinx_axienet_main.c:2613:5: warning: no previous prototype for 'axienet_ethtools_sset_count'
Date: Fri, 27 Sep 2024 20:18:11 +0800	[thread overview]
Message-ID: <202409272015.MBMSOG1Y-lkp@intel.com> (raw)

tree:   https://github.com/Xilinx/linux-xlnx xlnx_rebase_v6.6_LTS_2024.1_update
head:   5365c13a86998da06d845c918f849b30b8735538
commit: 830720cbc502457a805dbedf1ebb8b60999f8028 [582/1001] net: xilinx: Ethtool statistics support
config: i386-allmodconfig (https://download.01.org/0day-ci/archive/20240927/202409272015.MBMSOG1Y-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240927/202409272015.MBMSOG1Y-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409272015.MBMSOG1Y-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/net/ethernet/xilinx/xilinx_axienet_main.c:2613:5: warning: no previous prototype for 'axienet_ethtools_sset_count' [-Wmissing-prototypes]
    2613 | int axienet_ethtools_sset_count(struct net_device *ndev, int sset)
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/net/ethernet/xilinx/xilinx_axienet_main.c:2636:6: warning: no previous prototype for 'axienet_ethtools_get_stats' [-Wmissing-prototypes]
    2636 | void axienet_ethtools_get_stats(struct net_device *ndev,
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/net/ethernet/xilinx/xilinx_axienet_main.c:2663:6: warning: no previous prototype for 'axienet_ethtools_strings' [-Wmissing-prototypes]
    2663 | void axienet_ethtools_strings(struct net_device *ndev, u32 sset, u8 *data)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~


vim +/axienet_ethtools_sset_count +2613 drivers/net/ethernet/xilinx/xilinx_axienet_main.c

  2603	
  2604	/**
  2605	 * axienet_ethtools_sset_count - Get number of strings that
  2606	 *				 get_strings will write.
  2607	 * @ndev:	Pointer to net_device structure
  2608	 * @sset:	Get the set strings
  2609	 *
  2610	 * Return: number of strings, on success, Non-zero error value on
  2611	 *	   failure.
  2612	 */
> 2613	int axienet_ethtools_sset_count(struct net_device *ndev, int sset)
  2614	{
  2615		switch (sset) {
  2616		case ETH_SS_STATS:
  2617	#ifdef CONFIG_AXIENET_HAS_MCDMA
  2618			return axienet_sset_count(ndev, sset);
  2619	#else
  2620			return AXIENET_ETHTOOLS_SSTATS_LEN;
  2621	#endif
  2622		default:
  2623			return -EOPNOTSUPP;
  2624		}
  2625	}
  2626	
  2627	/**
  2628	 * axienet_ethtools_get_stats - Get the extended statistics
  2629	 *				about the device.
  2630	 * @ndev:	Pointer to net_device structure
  2631	 * @stats:	Pointer to ethtool_stats structure
  2632	 * @data:	To store the statistics values
  2633	 *
  2634	 * Return: None.
  2635	 */
> 2636	void axienet_ethtools_get_stats(struct net_device *ndev,
  2637					struct ethtool_stats *stats,
  2638					u64 *data)
  2639	{
  2640		unsigned int i = 0;
  2641	
  2642		data[i++] = ndev->stats.tx_packets;
  2643		data[i++] = ndev->stats.rx_packets;
  2644		data[i++] = ndev->stats.tx_bytes;
  2645		data[i++] = ndev->stats.rx_bytes;
  2646		data[i++] = ndev->stats.tx_errors;
  2647		data[i++] = ndev->stats.rx_missed_errors + ndev->stats.rx_frame_errors;
  2648	
  2649	#ifdef CONFIG_AXIENET_HAS_MCDMA
  2650		axienet_get_stats(ndev, stats, data);
  2651	#endif
  2652	}
  2653	
  2654	/**
  2655	 * axienet_ethtools_strings - Set of strings that describe
  2656	 *			 the requested objects.
  2657	 * @ndev:	Pointer to net_device structure
  2658	 * @sset:	Get the set strings
  2659	 * @data:	Data of Transmit and Receive statistics
  2660	 *
  2661	 * Return: None.
  2662	 */
> 2663	void axienet_ethtools_strings(struct net_device *ndev, u32 sset, u8 *data)
  2664	{
  2665		int i;
  2666	
  2667		for (i = 0; i < AXIENET_ETHTOOLS_SSTATS_LEN; i++) {
  2668			if (sset == ETH_SS_STATS)
  2669				memcpy(data + i * ETH_GSTRING_LEN,
  2670				       axienet_get_ethtools_strings_stats[i].name,
  2671				       ETH_GSTRING_LEN);
  2672		}
  2673	#ifdef CONFIG_AXIENET_HAS_MCDMA
  2674		axienet_strings(ndev, sset, data);
  2675	#endif
  2676	}
  2677	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2024-09-27 12:18 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202409272015.MBMSOG1Y-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=git@amd.com \
    --cc=monstr@monstr.eu \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=radhey.shyam.pandey@amd.com \
    --cc=shravya.kumbham@xilinx.com \
    --cc=suraj.gupta2@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.