From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: [asahilinux:asahi-wip 574/1039] drivers/gpu/drm/drm_gpuvm.c:2706 drm_gpuvm_bo_unmap() error: uninitialized symbol 'ret'.
Date: Sat, 28 Sep 2024 05:06:20 +0800 [thread overview]
Message-ID: <202409280451.cOhPsAHm-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
TO: Asahi Lina <lina@asahilina.net>
CC: Janne Grunau <j@jannau.net>
tree: https://github.com/AsahiLinux/linux asahi-wip
head: de1c5a8be0ee99602e472f3ca861cc2d249597da
commit: 3071faed85b4c2fc9d6de681d2059c02d56388ef [574/1039] drm/gpuvm: Add drm_gpuvm_bo_unmap()
:::::: branch date: 3 days ago
:::::: commit date: 12 days ago
config: x86_64-randconfig-161-20240927 (https://download.01.org/0day-ci/archive/20240928/202409280451.cOhPsAHm-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-12) 11.3.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202409280451.cOhPsAHm-lkp@intel.com/
New smatch warnings:
drivers/gpu/drm/drm_gpuvm.c:2706 drm_gpuvm_bo_unmap() error: uninitialized symbol 'ret'.
Old smatch warnings:
drivers/gpu/drm/drm_gpuvm.c:1354 drm_gpuvm_exec_lock_range() error: uninitialized symbol 'ret'.
vim +/ret +2706 drivers/gpu/drm/drm_gpuvm.c
e6303f323b1ad9 drivers/gpu/drm/drm_gpuva_mgr.c Danilo Krummrich 2023-07-20 2666
3071faed85b4c2 drivers/gpu/drm/drm_gpuvm.c Asahi Lina 2024-05-08 2667 /**
3071faed85b4c2 drivers/gpu/drm/drm_gpuvm.c Asahi Lina 2024-05-08 2668 * drm_gpuvm_bo_unmap() - unmaps a GEM
3071faed85b4c2 drivers/gpu/drm/drm_gpuvm.c Asahi Lina 2024-05-08 2669 * @vm_bo: the &drm_gpuvm_bo abstraction
3071faed85b4c2 drivers/gpu/drm/drm_gpuvm.c Asahi Lina 2024-05-08 2670 *
3071faed85b4c2 drivers/gpu/drm/drm_gpuvm.c Asahi Lina 2024-05-08 2671 * This function calls the unmap callback for every GPUVA attached to a GEM.
3071faed85b4c2 drivers/gpu/drm/drm_gpuvm.c Asahi Lina 2024-05-08 2672 *
3071faed85b4c2 drivers/gpu/drm/drm_gpuvm.c Asahi Lina 2024-05-08 2673 * It is the callers responsibility to protect the GEMs GPUVA list against
3071faed85b4c2 drivers/gpu/drm/drm_gpuvm.c Asahi Lina 2024-05-08 2674 * concurrent access using the GEMs dma_resv lock.
3071faed85b4c2 drivers/gpu/drm/drm_gpuvm.c Asahi Lina 2024-05-08 2675 *
3071faed85b4c2 drivers/gpu/drm/drm_gpuvm.c Asahi Lina 2024-05-08 2676 * Returns: a pointer to the &drm_gpuva_ops on success, an ERR_PTR on failure
3071faed85b4c2 drivers/gpu/drm/drm_gpuvm.c Asahi Lina 2024-05-08 2677 */
3071faed85b4c2 drivers/gpu/drm/drm_gpuvm.c Asahi Lina 2024-05-08 2678 int
3071faed85b4c2 drivers/gpu/drm/drm_gpuvm.c Asahi Lina 2024-05-08 2679 drm_gpuvm_bo_unmap(struct drm_gpuvm_bo *vm_bo, void *priv)
3071faed85b4c2 drivers/gpu/drm/drm_gpuvm.c Asahi Lina 2024-05-08 2680 {
3071faed85b4c2 drivers/gpu/drm/drm_gpuvm.c Asahi Lina 2024-05-08 2681 struct drm_gpuva_op *op;
3071faed85b4c2 drivers/gpu/drm/drm_gpuvm.c Asahi Lina 2024-05-08 2682 int ret;
3071faed85b4c2 drivers/gpu/drm/drm_gpuvm.c Asahi Lina 2024-05-08 2683
3071faed85b4c2 drivers/gpu/drm/drm_gpuvm.c Asahi Lina 2024-05-08 2684 if (unlikely(!vm_bo->vm))
3071faed85b4c2 drivers/gpu/drm/drm_gpuvm.c Asahi Lina 2024-05-08 2685 return -EINVAL;
3071faed85b4c2 drivers/gpu/drm/drm_gpuvm.c Asahi Lina 2024-05-08 2686
3071faed85b4c2 drivers/gpu/drm/drm_gpuvm.c Asahi Lina 2024-05-08 2687 const struct drm_gpuvm_ops *vm_ops = vm_bo->vm->ops;
3071faed85b4c2 drivers/gpu/drm/drm_gpuvm.c Asahi Lina 2024-05-08 2688
3071faed85b4c2 drivers/gpu/drm/drm_gpuvm.c Asahi Lina 2024-05-08 2689 if (unlikely(!(vm_ops && vm_ops->sm_step_unmap)))
3071faed85b4c2 drivers/gpu/drm/drm_gpuvm.c Asahi Lina 2024-05-08 2690 return -EINVAL;
3071faed85b4c2 drivers/gpu/drm/drm_gpuvm.c Asahi Lina 2024-05-08 2691
3071faed85b4c2 drivers/gpu/drm/drm_gpuvm.c Asahi Lina 2024-05-08 2692 struct drm_gpuva_ops *ops = drm_gpuvm_bo_unmap_ops_create(vm_bo);
3071faed85b4c2 drivers/gpu/drm/drm_gpuvm.c Asahi Lina 2024-05-08 2693 if (IS_ERR(ops))
3071faed85b4c2 drivers/gpu/drm/drm_gpuvm.c Asahi Lina 2024-05-08 2694 return PTR_ERR(ops);
3071faed85b4c2 drivers/gpu/drm/drm_gpuvm.c Asahi Lina 2024-05-08 2695
3071faed85b4c2 drivers/gpu/drm/drm_gpuvm.c Asahi Lina 2024-05-08 2696 drm_gpuva_for_each_op(op, ops) {
3071faed85b4c2 drivers/gpu/drm/drm_gpuvm.c Asahi Lina 2024-05-08 2697 drm_WARN_ON(vm_bo->vm->drm, op->op != DRM_GPUVA_OP_UNMAP);
3071faed85b4c2 drivers/gpu/drm/drm_gpuvm.c Asahi Lina 2024-05-08 2698
3071faed85b4c2 drivers/gpu/drm/drm_gpuvm.c Asahi Lina 2024-05-08 2699 ret = op_unmap_cb(vm_ops, priv, op->unmap.va, false);
3071faed85b4c2 drivers/gpu/drm/drm_gpuvm.c Asahi Lina 2024-05-08 2700 if (ret)
3071faed85b4c2 drivers/gpu/drm/drm_gpuvm.c Asahi Lina 2024-05-08 2701 goto cleanup;
3071faed85b4c2 drivers/gpu/drm/drm_gpuvm.c Asahi Lina 2024-05-08 2702 }
3071faed85b4c2 drivers/gpu/drm/drm_gpuvm.c Asahi Lina 2024-05-08 2703
3071faed85b4c2 drivers/gpu/drm/drm_gpuvm.c Asahi Lina 2024-05-08 2704 cleanup:
3071faed85b4c2 drivers/gpu/drm/drm_gpuvm.c Asahi Lina 2024-05-08 2705 drm_gpuva_ops_free(vm_bo->vm, ops);
3071faed85b4c2 drivers/gpu/drm/drm_gpuvm.c Asahi Lina 2024-05-08 @2706 return ret;
3071faed85b4c2 drivers/gpu/drm/drm_gpuvm.c Asahi Lina 2024-05-08 2707 }
3071faed85b4c2 drivers/gpu/drm/drm_gpuvm.c Asahi Lina 2024-05-08 2708 EXPORT_SYMBOL_GPL(drm_gpuvm_bo_unmap);
3071faed85b4c2 drivers/gpu/drm/drm_gpuvm.c Asahi Lina 2024-05-08 2709
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2024-09-27 21:06 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202409280451.cOhPsAHm-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.