All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: [android-common:android-mainline 2402/5421] fs/incfs/data_mgmt.c:510 log_read_one_record() error: uninitialized symbol 'record_size'.
Date: Sat, 28 Sep 2024 11:55:53 +0800	[thread overview]
Message-ID: <202409281145.FPOHPs8c-lkp@intel.com> (raw)

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
TO: cros-kernel-buildreports@googlegroups.com

tree:   https://android.googlesource.com/kernel/common android-mainline
head:   da0c10aefaf6089b483a9c679b7151dc316a36c7
commit: fe2917fdb90f6d5513202ed424b446d2dd0f15eb [2402/5421] ANDROID: Incremental fs: Finer readlog compression internally
:::::: branch date: 25 hours ago
:::::: commit date: 3 years, 7 months ago
config: i386-randconfig-141-20240928 (https://download.01.org/0day-ci/archive/20240928/202409281145.FPOHPs8c-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202409281145.FPOHPs8c-lkp@intel.com/

smatch warnings:
fs/incfs/data_mgmt.c:510 log_read_one_record() error: uninitialized symbol 'record_size'.

vim +/record_size +510 fs/incfs/data_mgmt.c

c6819dd77861f2 Eugene Zemtsov 2019-11-18  457  
b6b4a3a404ccd9 Paul Lawrence  2020-04-22  458  static void log_read_one_record(struct read_log *rl, struct read_log_state *rs)
b6b4a3a404ccd9 Paul Lawrence  2020-04-22  459  {
b6b4a3a404ccd9 Paul Lawrence  2020-04-22  460  	union log_record *record =
b6b4a3a404ccd9 Paul Lawrence  2020-04-22  461  		(union log_record *)((u8 *)rl->rl_ring_buf + rs->next_offset);
b6b4a3a404ccd9 Paul Lawrence  2020-04-22  462  	size_t record_size;
b6b4a3a404ccd9 Paul Lawrence  2020-04-22  463  
b6b4a3a404ccd9 Paul Lawrence  2020-04-22  464  	switch (record->full_record.type) {
b6b4a3a404ccd9 Paul Lawrence  2020-04-22  465  	case FULL:
b6b4a3a404ccd9 Paul Lawrence  2020-04-22  466  		rs->base_record = record->full_record;
b6b4a3a404ccd9 Paul Lawrence  2020-04-22  467  		record_size = sizeof(record->full_record);
b6b4a3a404ccd9 Paul Lawrence  2020-04-22  468  		break;
b6b4a3a404ccd9 Paul Lawrence  2020-04-22  469  
b6b4a3a404ccd9 Paul Lawrence  2020-04-22  470  	case SAME_FILE:
b6b4a3a404ccd9 Paul Lawrence  2020-04-22  471  		rs->base_record.block_index =
fe2917fdb90f6d Paul Lawrence  2021-03-08  472  			record->same_file.block_index;
b6b4a3a404ccd9 Paul Lawrence  2020-04-22  473  		rs->base_record.absolute_ts_us +=
fe2917fdb90f6d Paul Lawrence  2021-03-08  474  			record->same_file.relative_ts_us;
fe2917fdb90f6d Paul Lawrence  2021-03-08  475  		rs->base_record.uid = record->same_file.uid;
fe2917fdb90f6d Paul Lawrence  2021-03-08  476  		record_size = sizeof(record->same_file);
fe2917fdb90f6d Paul Lawrence  2021-03-08  477  		break;
fe2917fdb90f6d Paul Lawrence  2021-03-08  478  
fe2917fdb90f6d Paul Lawrence  2021-03-08  479  	case SAME_FILE_CLOSE_BLOCK:
fe2917fdb90f6d Paul Lawrence  2021-03-08  480  		rs->base_record.block_index +=
fe2917fdb90f6d Paul Lawrence  2021-03-08  481  			record->same_file_close_block.block_index_delta;
fe2917fdb90f6d Paul Lawrence  2021-03-08  482  		rs->base_record.absolute_ts_us +=
fe2917fdb90f6d Paul Lawrence  2021-03-08  483  			record->same_file_close_block.relative_ts_us;
fe2917fdb90f6d Paul Lawrence  2021-03-08  484  		record_size = sizeof(record->same_file_close_block);
fe2917fdb90f6d Paul Lawrence  2021-03-08  485  		break;
fe2917fdb90f6d Paul Lawrence  2021-03-08  486  
fe2917fdb90f6d Paul Lawrence  2021-03-08  487  	case SAME_FILE_CLOSE_BLOCK_SHORT:
fe2917fdb90f6d Paul Lawrence  2021-03-08  488  		rs->base_record.block_index +=
fe2917fdb90f6d Paul Lawrence  2021-03-08  489  			record->same_file_close_block_short.block_index_delta;
fe2917fdb90f6d Paul Lawrence  2021-03-08  490  		rs->base_record.absolute_ts_us +=
fe2917fdb90f6d Paul Lawrence  2021-03-08  491  		   record->same_file_close_block_short.relative_ts_tens_us * 10;
fe2917fdb90f6d Paul Lawrence  2021-03-08  492  		record_size = sizeof(record->same_file_close_block_short);
b6b4a3a404ccd9 Paul Lawrence  2020-04-22  493  		break;
b6b4a3a404ccd9 Paul Lawrence  2020-04-22  494  
b6b4a3a404ccd9 Paul Lawrence  2020-04-22  495  	case SAME_FILE_NEXT_BLOCK:
b6b4a3a404ccd9 Paul Lawrence  2020-04-22  496  		++rs->base_record.block_index;
b6b4a3a404ccd9 Paul Lawrence  2020-04-22  497  		rs->base_record.absolute_ts_us +=
b6b4a3a404ccd9 Paul Lawrence  2020-04-22  498  			record->same_file_next_block.relative_ts_us;
b6b4a3a404ccd9 Paul Lawrence  2020-04-22  499  		record_size = sizeof(record->same_file_next_block);
b6b4a3a404ccd9 Paul Lawrence  2020-04-22  500  		break;
b6b4a3a404ccd9 Paul Lawrence  2020-04-22  501  
b6b4a3a404ccd9 Paul Lawrence  2020-04-22  502  	case SAME_FILE_NEXT_BLOCK_SHORT:
b6b4a3a404ccd9 Paul Lawrence  2020-04-22  503  		++rs->base_record.block_index;
b6b4a3a404ccd9 Paul Lawrence  2020-04-22  504  		rs->base_record.absolute_ts_us +=
fe2917fdb90f6d Paul Lawrence  2021-03-08  505  		    record->same_file_next_block_short.relative_ts_tens_us * 10;
b6b4a3a404ccd9 Paul Lawrence  2020-04-22  506  		record_size = sizeof(record->same_file_next_block_short);
b6b4a3a404ccd9 Paul Lawrence  2020-04-22  507  		break;
b6b4a3a404ccd9 Paul Lawrence  2020-04-22  508  	}
b6b4a3a404ccd9 Paul Lawrence  2020-04-22  509  
b6b4a3a404ccd9 Paul Lawrence  2020-04-22 @510  	rs->next_offset += record_size;
b6b4a3a404ccd9 Paul Lawrence  2020-04-22  511  	if (rs->next_offset > rl->rl_size - sizeof(*record)) {
b6b4a3a404ccd9 Paul Lawrence  2020-04-22  512  		rs->next_offset = 0;
b6b4a3a404ccd9 Paul Lawrence  2020-04-22  513  		++rs->current_pass_no;
b6b4a3a404ccd9 Paul Lawrence  2020-04-22  514  	}
b6b4a3a404ccd9 Paul Lawrence  2020-04-22  515  	++rs->current_record_no;
b6b4a3a404ccd9 Paul Lawrence  2020-04-22  516  }
b6b4a3a404ccd9 Paul Lawrence  2020-04-22  517  

:::::: The code at line 510 was first introduced by commit
:::::: b6b4a3a404ccd9c62347e27c4fc7883d776c2cbb ANDROID: Incremental fs: Use simple compression in log buffer

:::::: TO: Paul Lawrence <paullawrence@google.com>
:::::: CC: Paul Lawrence <paullawrence@google.com>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2024-09-28  3:56 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202409281145.FPOHPs8c-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=error27@gmail.com \
    --cc=oe-kbuild@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.