From: Johannes Weiner <hannes@cmpxchg.org>
To: Kanchana P Sridhar <kanchana.p.sridhar@intel.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
yosryahmed@google.com, nphamcs@gmail.com,
chengming.zhou@linux.dev, usamaarif642@gmail.com,
shakeel.butt@linux.dev, ryan.roberts@arm.com,
ying.huang@intel.com, 21cnbao@gmail.com,
akpm@linux-foundation.org, nanhai.zou@intel.com,
wajdi.k.feghali@intel.com, vinodh.gopal@intel.com
Subject: Re: [PATCH v8 3/8] mm: zswap: Rename zswap_pool_get() to zswap_pool_tryget().
Date: Sat, 28 Sep 2024 09:47:36 -0400 [thread overview]
Message-ID: <20240928134736.GC957841@cmpxchg.org> (raw)
In-Reply-To: <20240928021620.8369-4-kanchana.p.sridhar@intel.com>
On Fri, Sep 27, 2024 at 07:16:15PM -0700, Kanchana P Sridhar wrote:
> Modify the name of the existing zswap_pool_get() to zswap_pool_tryget()
> to be representative of the call it makes to percpu_ref_tryget().
> A subsequent patch will introduce a new zswap_pool_get() that calls
> percpu_ref_get().
>
> The intent behind this change is for higher level zswap API such as
> zswap_store() to call zswap_pool_tryget() to check upfront if the pool's
> refcount is "0" (which means it could be getting destroyed) and to handle
> this as an error condition. zswap_store() would proceed only if
> zswap_pool_tryget() returns success, and any additional pool refcounts that
> need to be obtained for compressing sub-pages in a large folio could simply
> call zswap_pool_get().
>
> Signed-off-by: Kanchana P Sridhar <kanchana.p.sridhar@intel.com>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
next prev parent reply other threads:[~2024-09-28 13:47 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-28 2:16 [PATCH v8 0/8] mm: zswap swap-out of large folios Kanchana P Sridhar
2024-09-28 2:16 ` [PATCH v8 1/8] mm: Define obj_cgroup_get() if CONFIG_MEMCG is not defined Kanchana P Sridhar
2024-09-28 2:30 ` Yosry Ahmed
2024-09-28 5:39 ` Chengming Zhou
2024-09-28 13:46 ` Johannes Weiner
2024-09-28 2:16 ` [PATCH v8 2/8] mm: zswap: Modify zswap_compress() to accept a page instead of a folio Kanchana P Sridhar
2024-09-28 5:41 ` Chengming Zhou
2024-09-28 13:46 ` Johannes Weiner
2024-09-28 2:16 ` [PATCH v8 3/8] mm: zswap: Rename zswap_pool_get() to zswap_pool_tryget() Kanchana P Sridhar
2024-09-28 2:29 ` Yosry Ahmed
2024-09-28 5:43 ` Chengming Zhou
2024-09-29 21:01 ` Sridhar, Kanchana P
2024-09-28 13:47 ` Johannes Weiner [this message]
2024-09-28 23:26 ` Nhat Pham
2024-09-29 21:04 ` Sridhar, Kanchana P
2024-09-28 2:16 ` [PATCH v8 4/8] mm: Provide a new count_objcg_events() API for batch event updates Kanchana P Sridhar
2024-09-28 3:02 ` Yosry Ahmed
2024-09-28 5:46 ` Chengming Zhou
2024-09-29 21:00 ` Sridhar, Kanchana P
2024-09-28 2:16 ` [PATCH v8 5/8] mm: zswap: Modify zswap_stored_pages to be atomic_long_t Kanchana P Sridhar
2024-09-28 2:57 ` Yosry Ahmed
2024-09-28 4:50 ` Matthew Wilcox
2024-09-28 8:12 ` Yosry Ahmed
2024-09-28 8:13 ` Yosry Ahmed
2024-09-29 21:04 ` Sridhar, Kanchana P
2024-09-28 13:53 ` Johannes Weiner
2024-09-29 21:03 ` Sridhar, Kanchana P
2024-09-28 23:27 ` Nhat Pham
2024-09-28 2:16 ` [PATCH v8 6/8] mm: zswap: Support large folios in zswap_store() Kanchana P Sridhar
2024-09-28 3:42 ` Yosry Ahmed
2024-09-28 14:15 ` Johannes Weiner
2024-09-28 18:11 ` Yosry Ahmed
2024-09-29 21:15 ` Sridhar, Kanchana P
2024-09-30 17:55 ` Sridhar, Kanchana P
2024-09-29 21:24 ` Sridhar, Kanchana P
2024-09-28 6:05 ` Chengming Zhou
2024-09-28 2:16 ` [PATCH v8 7/8] mm: swap: Count successful large folio zswap stores in hugepage zswpout stats Kanchana P Sridhar
2024-09-28 2:16 ` [PATCH v8 8/8] mm: Document the newly added sysfs large folios " Kanchana P Sridhar
2024-09-29 22:34 ` Nhat Pham
2024-09-30 0:56 ` Sridhar, Kanchana P
2024-09-28 2:25 ` [PATCH v8 0/8] mm: zswap swap-out of large folios Yosry Ahmed
2024-09-28 2:36 ` Sridhar, Kanchana P
2024-09-28 3:00 ` Yosry Ahmed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240928134736.GC957841@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=21cnbao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=chengming.zhou@linux.dev \
--cc=kanchana.p.sridhar@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nanhai.zou@intel.com \
--cc=nphamcs@gmail.com \
--cc=ryan.roberts@arm.com \
--cc=shakeel.butt@linux.dev \
--cc=usamaarif642@gmail.com \
--cc=vinodh.gopal@intel.com \
--cc=wajdi.k.feghali@intel.com \
--cc=ying.huang@intel.com \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.