From: kernel test robot <lkp@intel.com>
To: Otavio Salvador <otavio@ossystems.com.br>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [freescale-fslc:6.6-2.0.x-imx 34/16788] arch/arm/mach-imx/common.c:22:15: warning: no previous prototype for 'save_ttbr1'
Date: Sat, 28 Sep 2024 17:37:52 +0800 [thread overview]
Message-ID: <202409281712.dmlhp3fc-lkp@intel.com> (raw)
tree: https://github.com/Freescale/linux-fslc 6.6-2.0.x-imx
head: ac32ba5fe66266329914d2020570364afe217bec
commit: 4c3e8cf9f9519b5341c4bd58a692a92e63450464 [34/16788] ARM: imx: add i.MX7D bus-freq support
config: arm-randconfig-001-20240928 (https://download.01.org/0day-ci/archive/20240928/202409281712.dmlhp3fc-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240928/202409281712.dmlhp3fc-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409281712.dmlhp3fc-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> arch/arm/mach-imx/common.c:22:15: warning: no previous prototype for 'save_ttbr1' [-Wmissing-prototypes]
22 | unsigned long save_ttbr1(void)
| ^~~~~~~~~~
>> arch/arm/mach-imx/common.c:33:6: warning: no previous prototype for 'restore_ttbr1' [-Wmissing-prototypes]
33 | void restore_ttbr1(unsigned long ttbr1)
| ^~~~~~~~~~~~~
>> arch/arm/mach-imx/common.c:44:13: warning: no previous prototype for 'imx6_enet_mac_init' [-Wmissing-prototypes]
44 | void __init imx6_enet_mac_init(const char *enet_compat, const char *ocotp_compat)
| ^~~~~~~~~~~~~~~~~~
arch/arm/mach-imx/common.c: In function 'imx6_enet_mac_init':
arch/arm/mach-imx/common.c:62:21: error: too few arguments to function 'of_get_mac_address'
62 | if (of_get_mac_address(enet_np))
| ^~~~~~~~~~~~~~~~~~
In file included from arch/arm/mach-imx/common.c:14:
include/linux/of_net.h:27:19: note: declared here
27 | static inline int of_get_mac_address(struct device_node *np, u8 *mac)
| ^~~~~~~~~~~~~~~~~~
arch/arm/mach-imx/common.c: At top level:
>> arch/arm/mach-imx/common.c:126:5: warning: no previous prototype for 'imx_gpc_mf_request_on' [-Wmissing-prototypes]
126 | int imx_gpc_mf_request_on(unsigned int irq, unsigned int on) { return 0; }
| ^~~~~~~~~~~~~~~~~~~~~
>> arch/arm/mach-imx/common.c:132:6: warning: no previous prototype for 'mx6_lpddr2_freq_change' [-Wmissing-prototypes]
132 | void mx6_lpddr2_freq_change(u32 freq, int bus_freq_mode) {}
| ^~~~~~~~~~~~~~~~~~~~~~
>> arch/arm/mach-imx/common.c:136:6: warning: no previous prototype for 'imx6sll_lpddr2_freq_change' [-Wmissing-prototypes]
136 | void imx6sll_lpddr2_freq_change(u32 freq, int bus_freq_mode) {}
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
>> arch/arm/mach-imx/common.c:143:6: warning: no previous prototype for 'imx6_up_ddr3_freq_change' [-Wmissing-prototypes]
143 | void imx6_up_ddr3_freq_change(struct imx6_busfreq_info *busfreq_info) {}
| ^~~~~~~~~~~~~~~~~~~~~~~~
>> arch/arm/mach-imx/common.c:144:6: warning: no previous prototype for 'imx6_up_lpddr2_freq_change' [-Wmissing-prototypes]
144 | void imx6_up_lpddr2_freq_change(u32 freq, int bus_freq_mode) {}
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
arch/arm/mach-imx/common.c:149:6: warning: no previous prototype for 'imx6ull_low_power_idle' [-Wmissing-prototypes]
149 | void imx6ull_low_power_idle(void) {}
| ^~~~~~~~~~~~~~~~~~~~~~
>> arch/arm/mach-imx/common.c:156:6: warning: no previous prototype for 'mx6_ddr3_freq_change' [-Wmissing-prototypes]
156 | void mx6_ddr3_freq_change(u32 freq, void *ddr_settings,
| ^~~~~~~~~~~~~~~~~~~~
>> arch/arm/mach-imx/common.c:158:6: warning: no previous prototype for 'mx6q_lpddr2_freq_change' [-Wmissing-prototypes]
158 | void mx6q_lpddr2_freq_change(u32 freq, void *ddr_settings) {}
| ^~~~~~~~~~~~~~~~~~~~~~~
>> arch/arm/mach-imx/common.c:159:6: warning: no previous prototype for 'wfe_smp_freq_change' [-Wmissing-prototypes]
159 | void wfe_smp_freq_change(u32 cpuid, u32 *ddr_freq_change_done) {}
| ^~~~~~~~~~~~~~~~~~~
>> arch/arm/mach-imx/common.c:163:6: warning: no previous prototype for 'imx7_smp_wfe' [-Wmissing-prototypes]
163 | void imx7_smp_wfe(u32 cpuid, u32 ocram_base) {}
| ^~~~~~~~~~~~
>> arch/arm/mach-imx/common.c:164:6: warning: no previous prototype for 'imx7d_ddr3_freq_change' [-Wmissing-prototypes]
164 | void imx7d_ddr3_freq_change(u32 freq) {}
| ^~~~~~~~~~~~~~~~~~~~~~
--
>> arch/arm/mach-imx/busfreq_ddr3.c:111:5: warning: no previous prototype for 'can_change_ddr_freq' [-Wmissing-prototypes]
111 | int can_change_ddr_freq(void)
| ^~~~~~~~~~~~~~~~~~~
>> arch/arm/mach-imx/busfreq_ddr3.c:148:5: warning: no previous prototype for 'update_ddr_freq_imx_smp' [-Wmissing-prototypes]
148 | int update_ddr_freq_imx_smp(int ddr_rate)
| ^~~~~~~~~~~~~~~~~~~~~~~
>> arch/arm/mach-imx/busfreq_ddr3.c:241:5: warning: no previous prototype for 'init_ddrc_ddr_settings' [-Wmissing-prototypes]
241 | int init_ddrc_ddr_settings(struct platform_device *busfreq_pdev)
| ^~~~~~~~~~~~~~~~~~~~~~
arch/arm/mach-imx/busfreq_ddr3.c:78:22: warning: 'gic_dist_base' defined but not used [-Wunused-variable]
78 | static void __iomem *gic_dist_base;
| ^~~~~~~~~~~~~
arch/arm/mach-imx/busfreq_ddr3.c:76:24: warning: 'iram_iomux_settings' defined but not used [-Wunused-variable]
76 | static unsigned long (*iram_iomux_settings)[2];
| ^~~~~~~~~~~~~~~~~~~
In file included from arch/arm/mach-imx/busfreq_ddr3.c:48:
arch/arm/mach-imx/common.h:102:18: warning: 'imx53_suspend_sz' defined but not used [-Wunused-const-variable=]
102 | static const u32 imx53_suspend_sz;
| ^~~~~~~~~~~~~~~~
vim +/save_ttbr1 +22 arch/arm/mach-imx/common.c
21
> 22 unsigned long save_ttbr1(void)
23 {
24 unsigned long lttbr1;
25 asm volatile(
26 ".align 4\n"
27 "mrc p15, 0, %0, c2, c0, 1\n"
28 : "=r" (lttbr1)
29 );
30 return lttbr1;
31 }
32
> 33 void restore_ttbr1(unsigned long ttbr1)
34 {
35 asm volatile(
36 ".align 4\n"
37 "mcr p15, 0, %0, c2, c0, 1\n"
38 : : "r" (ttbr1)
39 );
40 }
41
42 #define OCOTP_MAC_OFF (cpu_is_imx7d() ? 0x640 : 0x620)
43 #define OCOTP_MACn(n) (OCOTP_MAC_OFF + (n) * 0x10)
> 44 void __init imx6_enet_mac_init(const char *enet_compat, const char *ocotp_compat)
45 {
46 struct device_node *ocotp_np, *enet_np, *from = NULL;
47 void __iomem *base;
48 struct property *newmac;
49 u32 macaddr_low;
50 u32 macaddr_high = 0;
51 u32 macaddr1_high = 0;
52 u8 *macaddr;
53 int i, id;
54
55 for (i = 0; i < 2; i++) {
56 enet_np = of_find_compatible_node(from, NULL, enet_compat);
57 if (!enet_np)
58 return;
59
60 from = enet_np;
61
62 if (of_get_mac_address(enet_np))
63 goto put_enet_node;
64
65 id = of_alias_get_id(enet_np, "ethernet");
66 if (id < 0)
67 id = i;
68
69 ocotp_np = of_find_compatible_node(NULL, NULL, ocotp_compat);
70 if (!ocotp_np) {
71 pr_warn("failed to find ocotp node\n");
72 goto put_enet_node;
73 }
74
75 base = of_iomap(ocotp_np, 0);
76 if (!base) {
77 pr_warn("failed to map ocotp\n");
78 goto put_ocotp_node;
79 }
80
81 macaddr_low = readl_relaxed(base + OCOTP_MACn(1));
82 if (id)
83 macaddr1_high = readl_relaxed(base + OCOTP_MACn(2));
84 else
85 macaddr_high = readl_relaxed(base + OCOTP_MACn(0));
86
87 newmac = kzalloc(sizeof(*newmac) + 6, GFP_KERNEL);
88 if (!newmac)
89 goto put_ocotp_node;
90
91 newmac->value = newmac + 1;
92 newmac->length = 6;
93 newmac->name = kstrdup("local-mac-address", GFP_KERNEL);
94 if (!newmac->name) {
95 kfree(newmac);
96 goto put_ocotp_node;
97 }
98
99 macaddr = newmac->value;
100 if (id) {
101 macaddr[5] = (macaddr_low >> 16) & 0xff;
102 macaddr[4] = (macaddr_low >> 24) & 0xff;
103 macaddr[3] = macaddr1_high & 0xff;
104 macaddr[2] = (macaddr1_high >> 8) & 0xff;
105 macaddr[1] = (macaddr1_high >> 16) & 0xff;
106 macaddr[0] = (macaddr1_high >> 24) & 0xff;
107 } else {
108 macaddr[5] = macaddr_high & 0xff;
109 macaddr[4] = (macaddr_high >> 8) & 0xff;
110 macaddr[3] = (macaddr_high >> 16) & 0xff;
111 macaddr[2] = (macaddr_high >> 24) & 0xff;
112 macaddr[1] = macaddr_low & 0xff;
113 macaddr[0] = (macaddr_low >> 8) & 0xff;
114 }
115
116 of_update_property(enet_np, newmac);
117
118 put_ocotp_node:
119 of_node_put(ocotp_np);
120 put_enet_node:
121 of_node_put(enet_np);
122 }
123 }
124
125 #ifndef CONFIG_HAVE_IMX_GPC
> 126 int imx_gpc_mf_request_on(unsigned int irq, unsigned int on) { return 0; }
127 EXPORT_SYMBOL_GPL(imx_gpc_mf_request_on);
128 #endif
129
130 #if !defined(CONFIG_SOC_IMX6SL)
131 u32 imx6_lpddr2_freq_change_start, imx6_lpddr2_freq_change_end;
> 132 void mx6_lpddr2_freq_change(u32 freq, int bus_freq_mode) {}
133 #endif
134
135 #if !defined(CONFIG_SOC_IMX6SLL)
> 136 void imx6sll_lpddr2_freq_change(u32 freq, int bus_freq_mode) {}
137 #endif
138
139 #if !defined(CONFIG_SOC_IMX6SX) && !defined(CONFIG_SOC_IMX6UL)
140 u32 imx6_up_ddr3_freq_change_start, imx6_up_ddr3_freq_change_end;
141 struct imx6_busfreq_info {
142 } __aligned(8);
> 143 void imx6_up_ddr3_freq_change(struct imx6_busfreq_info *busfreq_info) {}
> 144 void imx6_up_lpddr2_freq_change(u32 freq, int bus_freq_mode) {}
145 #endif
146
147 #if !defined(CONFIG_SOC_IMX6ULL)
148 u32 mx6ull_lpm_wfi_start, mx6ull_lpm_wfi_end;
149 void imx6ull_low_power_idle(void) {}
150 #endif
151
152 #if !defined(CONFIG_SOC_IMX6Q)
153 u32 mx6_ddr3_freq_change_start, mx6_ddr3_freq_change_end;
154 u32 mx6q_lpddr2_freq_change_start, mx6q_lpddr2_freq_change_end;
155 u32 wfe_smp_freq_change_start, wfe_smp_freq_change_end;
> 156 void mx6_ddr3_freq_change(u32 freq, void *ddr_settings,
157 bool dll_mode, void *iomux_offsets) {}
> 158 void mx6q_lpddr2_freq_change(u32 freq, void *ddr_settings) {}
> 159 void wfe_smp_freq_change(u32 cpuid, u32 *ddr_freq_change_done) {}
160 #endif
161
162 #if !defined(CONFIG_SOC_IMX7D)
> 163 void imx7_smp_wfe(u32 cpuid, u32 ocram_base) {}
> 164 void imx7d_ddr3_freq_change(u32 freq) {}
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2024-09-28 9:38 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202409281712.dmlhp3fc-lkp@intel.com \
--to=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=otavio@ossystems.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.