All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Otavio Salvador <otavio@ossystems.com.br>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [freescale-fslc:6.6-2.0.x-imx 5875/16788] drivers/clk/imx/clk-imx8mm.c:731:23: warning: 'pll_setting_fops' defined but not used
Date: Sat, 28 Sep 2024 18:30:00 +0800	[thread overview]
Message-ID: <202409281817.76SrrpmP-lkp@intel.com> (raw)

tree:   https://github.com/Freescale/linux-fslc 6.6-2.0.x-imx
head:   ac32ba5fe66266329914d2020570364afe217bec
commit: 8edc700dd52e0961f046aa8e47e812efc10ae588 [5875/16788] Merge branch 'clock/next' into next
config: arc-randconfig-002-20240928 (https://download.01.org/0day-ci/archive/20240928/202409281817.76SrrpmP-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240928/202409281817.76SrrpmP-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409281817.76SrrpmP-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from include/linux/debugfs.h:16,
                    from drivers/clk/imx/clk-imx8mm.c:9:
>> drivers/clk/imx/clk-imx8mm.c:731:23: warning: 'pll_setting_fops' defined but not used [-Wunused-const-variable=]
     731 | DEFINE_SHOW_ATTRIBUTE(pll_setting);
         |                       ^~~~~~~~~~~
   include/linux/seq_file.h:202:37: note: in definition of macro 'DEFINE_SHOW_ATTRIBUTE'
     202 | static const struct file_operations __name ## _fops = {                 \
         |                                     ^~~~~~
>> drivers/clk/imx/clk-imx8mm.c:710:26: warning: 'delta_k_fops' defined but not used [-Wunused-const-variable=]
     710 | DEFINE_DEBUGFS_ATTRIBUTE(delta_k_fops, NULL, pll_delta_k_set, "%lld\n");
         |                          ^~~~~~~~~~~~
   include/linux/debugfs.h:54:37: note: in definition of macro 'DEFINE_DEBUGFS_ATTRIBUTE_XSIGNED'
      54 | static const struct file_operations __fops = {                          \
         |                                     ^~~~~~
   drivers/clk/imx/clk-imx8mm.c:710:1: note: in expansion of macro 'DEFINE_DEBUGFS_ATTRIBUTE'
     710 | DEFINE_DEBUGFS_ATTRIBUTE(delta_k_fops, NULL, pll_delta_k_set, "%lld\n");
         | ^~~~~~~~~~~~~~~~~~~~~~~~


vim +/pll_setting_fops +731 drivers/clk/imx/clk-imx8mm.c

f2a9d6d7aea21e Jacky Bai 2020-04-07  696  
f2a9d6d7aea21e Jacky Bai 2020-04-07  697  static int pll_delta_k_set(void *data, u64 val)
f2a9d6d7aea21e Jacky Bai 2020-04-07  698  {
f2a9d6d7aea21e Jacky Bai 2020-04-07  699  	struct clk_hw *hw;
f2a9d6d7aea21e Jacky Bai 2020-04-07  700  	short int delta_k;
f2a9d6d7aea21e Jacky Bai 2020-04-07  701  
f2a9d6d7aea21e Jacky Bai 2020-04-07  702  	hw = data;
f2a9d6d7aea21e Jacky Bai 2020-04-07  703  	delta_k = (short int) (val & KDIV_MASK);
f2a9d6d7aea21e Jacky Bai 2020-04-07  704  
f2a9d6d7aea21e Jacky Bai 2020-04-07  705  	clk_set_delta_k(hw, val);
f2a9d6d7aea21e Jacky Bai 2020-04-07  706  
f2a9d6d7aea21e Jacky Bai 2020-04-07  707  	pr_debug("the delta k is %d\n", delta_k);
f2a9d6d7aea21e Jacky Bai 2020-04-07  708  	return 0;
f2a9d6d7aea21e Jacky Bai 2020-04-07  709  }
f2a9d6d7aea21e Jacky Bai 2020-04-07 @710  DEFINE_DEBUGFS_ATTRIBUTE(delta_k_fops, NULL, pll_delta_k_set, "%lld\n");
f2a9d6d7aea21e Jacky Bai 2020-04-07  711  
f2a9d6d7aea21e Jacky Bai 2020-04-07  712  static int pll_setting_show(struct seq_file *s, void *data)
f2a9d6d7aea21e Jacky Bai 2020-04-07  713  {
f2a9d6d7aea21e Jacky Bai 2020-04-07  714  	struct clk_hw *hw;
f2a9d6d7aea21e Jacky Bai 2020-04-07  715  	u32 pll_div_ctrl0, pll_div_ctrl1;
f2a9d6d7aea21e Jacky Bai 2020-04-07  716  	u32 mdiv, pdiv, sdiv, kdiv;
f2a9d6d7aea21e Jacky Bai 2020-04-07  717  
f2a9d6d7aea21e Jacky Bai 2020-04-07  718  	hw = s->private;;
f2a9d6d7aea21e Jacky Bai 2020-04-07  719  
f2a9d6d7aea21e Jacky Bai 2020-04-07  720  	clk_get_pll_setting(hw, &pll_div_ctrl0, &pll_div_ctrl1);
f2a9d6d7aea21e Jacky Bai 2020-04-07  721  	mdiv = (pll_div_ctrl0 & MDIV_MASK) >> MDIV_SHIFT;
f2a9d6d7aea21e Jacky Bai 2020-04-07  722  	pdiv = (pll_div_ctrl0 & PDIV_MASK) >> PDIV_SHIFT;
f2a9d6d7aea21e Jacky Bai 2020-04-07  723  	sdiv = (pll_div_ctrl0 & SDIV_MASK) >> SDIV_SHIFT;
f2a9d6d7aea21e Jacky Bai 2020-04-07  724  	kdiv = (pll_div_ctrl1 & KDIV_MASK);
f2a9d6d7aea21e Jacky Bai 2020-04-07  725  
f2a9d6d7aea21e Jacky Bai 2020-04-07  726  	seq_printf(s, "Mdiv: 0x%x; Pdiv: 0x%x; Sdiv: 0x%x; Kdiv: 0x%x\n",
f2a9d6d7aea21e Jacky Bai 2020-04-07  727  		mdiv, pdiv, sdiv, kdiv);
f2a9d6d7aea21e Jacky Bai 2020-04-07  728  
f2a9d6d7aea21e Jacky Bai 2020-04-07  729  	return 0;
f2a9d6d7aea21e Jacky Bai 2020-04-07  730  }
f2a9d6d7aea21e Jacky Bai 2020-04-07 @731  DEFINE_SHOW_ATTRIBUTE(pll_setting);
f2a9d6d7aea21e Jacky Bai 2020-04-07  732  

:::::: The code at line 731 was first introduced by commit
:::::: f2a9d6d7aea21e1aaa348eb588bc8022babe83c7 MLK-23751 clk: imx: Add audio PLL debug fs for K-divider monitor control

:::::: TO: Jacky Bai <ping.bai@nxp.com>
:::::: CC: Dong Aisheng <aisheng.dong@nxp.com>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2024-09-28 10:30 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202409281817.76SrrpmP-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=otavio@ossystems.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.