All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Otavio Salvador <otavio@ossystems.com.br>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [freescale-fslc:6.6-2.0.x-imx 13/16788] drivers/base/power/domain.c:257:6: warning: no previous prototype for function 'pm_genpd_disable_clks'
Date: Sat, 28 Sep 2024 22:11:06 +0800	[thread overview]
Message-ID: <202409282235.sh5aezAF-lkp@intel.com> (raw)

tree:   https://github.com/Freescale/linux-fslc 6.6-2.0.x-imx
head:   ac32ba5fe66266329914d2020570364afe217bec
commit: 311faeaf28ab464f78586f417d5b7c6a8928c281 [13/16788] LF-4713-1 PM: domains: add pm domain clocks support
config: i386-buildonly-randconfig-001-20240928 (https://download.01.org/0day-ci/archive/20240928/202409282235.sh5aezAF-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240928/202409282235.sh5aezAF-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409282235.sh5aezAF-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/base/power/domain.c:257:6: warning: no previous prototype for function 'pm_genpd_disable_clks' [-Wmissing-prototypes]
     257 | void pm_genpd_disable_clks(struct generic_pm_domain *genpd)
         |      ^
   drivers/base/power/domain.c:257:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
     257 | void pm_genpd_disable_clks(struct generic_pm_domain *genpd)
         | ^
         | static 
>> drivers/base/power/domain.c:263:5: warning: no previous prototype for function 'pm_genpd_enable_clks' [-Wmissing-prototypes]
     263 | int pm_genpd_enable_clks(struct generic_pm_domain *genpd)
         |     ^
   drivers/base/power/domain.c:263:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
     263 | int pm_genpd_enable_clks(struct generic_pm_domain *genpd)
         | ^
         | static 
   2 warnings generated.


vim +/pm_genpd_disable_clks +257 drivers/base/power/domain.c

   256	
 > 257	void pm_genpd_disable_clks(struct generic_pm_domain *genpd)
   258	{
   259		if (genpd->flags & GENPD_FLAG_PM_PD_CLK && genpd->num_clks > 0)
   260			clk_bulk_disable_unprepare(genpd->num_clks, genpd->clks);
   261	}
   262	
 > 263	int pm_genpd_enable_clks(struct generic_pm_domain *genpd)
   264	{
   265		int ret;
   266	
   267		if (genpd->flags & GENPD_FLAG_PM_PD_CLK && genpd->num_clks > 0) {
   268			ret = clk_bulk_prepare_enable(genpd->num_clks, genpd->clks);
   269			if (ret) {
   270				dev_err(&genpd->dev, "failed to enable clocks\n");
   271				return ret;
   272			}
   273		}
   274	
   275		return 0;
   276	}
   277	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2024-09-28 14:11 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202409282235.sh5aezAF-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=otavio@ossystems.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.