All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ryan Walklin <ryan@testtoast.com>
To: Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Samuel Holland <samuel@sholland.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>
Cc: Andre Przywara <andre.przywara@arm.com>,
	Chris Morgan <macroalpha82@gmail.com>,
	dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org,
	linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org,
	linux-clk@vger.kernel.org, Ryan Walklin <ryan@testtoast.com>
Subject: [PATCH v5 08/26] drm: sun4i: de3: add YUV support to the DE3 mixer
Date: Sun, 29 Sep 2024 22:04:40 +1300	[thread overview]
Message-ID: <20240929091107.838023-9-ryan@testtoast.com> (raw)
In-Reply-To: <20240929091107.838023-1-ryan@testtoast.com>

From: Jernej Skrabec <jernej.skrabec@gmail.com>

The mixer in the DE3 display engine supports YUV 8 and 10 bit
formats in addition to 8-bit RGB. Add the required register
configuration and format enumeration callback functions to the mixer,
and store the in-use output format (defaulting to RGB) and color
encoding in engine variables.

Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Signed-off-by: Ryan Walklin <ryan@testtoast.com>

---
Changelog v4..v5:
- Remove trailing whitespace
---
 drivers/gpu/drm/sun4i/sun8i_mixer.c  | 53 ++++++++++++++++++++++++++--
 drivers/gpu/drm/sun4i/sunxi_engine.h |  5 +++
 2 files changed, 55 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/sun4i/sun8i_mixer.c b/drivers/gpu/drm/sun4i/sun8i_mixer.c
index 252827715de1d..a50c583852edf 100644
--- a/drivers/gpu/drm/sun4i/sun8i_mixer.c
+++ b/drivers/gpu/drm/sun4i/sun8i_mixer.c
@@ -23,7 +23,10 @@
 #include <drm/drm_gem_dma_helper.h>
 #include <drm/drm_probe_helper.h>
 
+#include <uapi/linux/media-bus-format.h>
+
 #include "sun4i_drv.h"
+#include "sun50i_fmt.h"
 #include "sun8i_mixer.h"
 #include "sun8i_ui_layer.h"
 #include "sun8i_vi_layer.h"
@@ -390,12 +393,52 @@ static void sun8i_mixer_mode_set(struct sunxi_engine *engine,
 
 	DRM_DEBUG_DRIVER("Switching display mixer interlaced mode %s\n",
 			 interlaced ? "on" : "off");
+
+	if (engine->format == MEDIA_BUS_FMT_RGB888_1X24)
+		val = SUN8I_MIXER_BLEND_COLOR_BLACK;
+	else
+		val = 0xff108080;
+
+	regmap_write(mixer->engine.regs,
+		     SUN8I_MIXER_BLEND_BKCOLOR(bld_base), val);
+	regmap_write(mixer->engine.regs,
+		     SUN8I_MIXER_BLEND_ATTR_FCOLOR(bld_base, 0), val);
+
+	if (mixer->cfg->has_formatter)
+		sun50i_fmt_setup(mixer, mode->hdisplay,
+				 mode->vdisplay, mixer->engine.format);
+}
+
+static u32 *sun8i_mixer_get_supported_fmts(struct sunxi_engine *engine, u32 *num)
+{
+	struct sun8i_mixer *mixer = engine_to_sun8i_mixer(engine);
+	u32 *formats, count;
+
+	count = 0;
+
+	formats = kcalloc(5, sizeof(*formats), GFP_KERNEL);
+	if (!formats)
+		return NULL;
+
+	if (mixer->cfg->has_formatter) {
+		formats[count++] = MEDIA_BUS_FMT_UYYVYY10_0_5X30;
+		formats[count++] = MEDIA_BUS_FMT_YUV8_1X24;
+		formats[count++] = MEDIA_BUS_FMT_UYVY8_1X16;
+		formats[count++] = MEDIA_BUS_FMT_UYYVYY8_0_5X24;
+	}
+
+	formats[count++] = MEDIA_BUS_FMT_RGB888_1X24;
+
+	*num = count;
+
+	return formats;
 }
 
 static const struct sunxi_engine_ops sun8i_engine_ops = {
-	.commit		= sun8i_mixer_commit,
-	.layers_init	= sun8i_layers_init,
-	.mode_set	= sun8i_mixer_mode_set,
+	.commit			= sun8i_mixer_commit,
+	.layers_init		= sun8i_layers_init,
+	.mode_set		= sun8i_mixer_mode_set,
+	.get_supported_fmts	= sun8i_mixer_get_supported_fmts,
 };
 
 static const struct regmap_config sun8i_mixer_regmap_config = {
@@ -456,6 +499,10 @@ static int sun8i_mixer_bind(struct device *dev, struct device *master,
 	dev_set_drvdata(dev, mixer);
 	mixer->engine.ops = &sun8i_engine_ops;
 	mixer->engine.node = dev->of_node;
+	/* default output format, supported by all mixers */
+	mixer->engine.format = MEDIA_BUS_FMT_RGB888_1X24;
+	/* default color encoding, ignored with RGB I/O */
+	mixer->engine.encoding = DRM_COLOR_YCBCR_BT601;
 
 	if (of_property_present(dev->of_node, "iommus")) {
 		/*
diff --git a/drivers/gpu/drm/sun4i/sunxi_engine.h b/drivers/gpu/drm/sun4i/sunxi_engine.h
index c48cbc1aceb80..ffafc29b3a0c3 100644
--- a/drivers/gpu/drm/sun4i/sunxi_engine.h
+++ b/drivers/gpu/drm/sun4i/sunxi_engine.h
@@ -6,6 +6,8 @@
 #ifndef _SUNXI_ENGINE_H_
 #define _SUNXI_ENGINE_H_
 
+#include <drm/drm_color_mgmt.h>
+
 struct drm_plane;
 struct drm_crtc;
 struct drm_device;
@@ -151,6 +153,9 @@ struct sunxi_engine {
 
 	int id;
 
+	u32				format;
+	enum drm_color_encoding		encoding;
+
 	/* Engine list management */
 	struct list_head		list;
 };
-- 
2.46.1


  parent reply	other threads:[~2024-09-29  9:12 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-29  9:04 [PATCH v5 00/26] drm: sun4i: add Display Engine 3.3 (DE33) support Ryan Walklin
2024-09-29  9:04 ` [PATCH v5 01/26] drm: sun4i: de2/de3: Change CSC argument Ryan Walklin
2024-10-19 14:11   ` Dmitry Baryshkov
2025-02-15  1:17     ` Ryan Walklin
2024-09-29  9:04 ` [PATCH v5 02/26] drm: sun4i: de2/de3: Merge CSC functions into one Ryan Walklin
2024-09-29  9:04 ` [PATCH v5 03/26] drm: sun4i: de2/de3: call csc setup also for UI layer Ryan Walklin
2024-09-29  9:04 ` [PATCH v5 04/26] drm: sun4i: de2: Initialize layer fields earlier Ryan Walklin
2024-09-29  9:04 ` [PATCH v5 05/26] drm: sun4i: de3: Add YUV formatter module Ryan Walklin
2024-09-29  9:04 ` [PATCH v5 06/26] drm: sun4i: de3: add format enumeration function to engine Ryan Walklin
2024-09-29  9:04 ` [PATCH v5 07/26] drm: sun4i: de3: add formatter flag to mixer config Ryan Walklin
2024-09-29  9:04 ` Ryan Walklin [this message]
2024-10-19 14:14   ` [PATCH v5 08/26] drm: sun4i: de3: add YUV support to the DE3 mixer Dmitry Baryshkov
2025-02-15  1:18     ` Ryan Walklin
2025-02-15  3:48       ` Ryan Walklin
2024-09-29  9:04 ` [PATCH v5 09/26] drm: sun4i: de3: pass engine reference to ccsc setup function Ryan Walklin
2024-09-29  9:04 ` [PATCH v5 10/26] drm: sun4i: de3: add YUV support to the color space correction module Ryan Walklin
2024-09-29  9:04 ` [PATCH v5 11/26] drm: sun4i: de3: add YUV support to the TCON Ryan Walklin
2024-09-29  9:04 ` [PATCH v5 12/26] drm: sun4i: support YUV formats in VI scaler Ryan Walklin
2024-09-29  9:04 ` [PATCH v5 13/26] drm: sun4i: de2/de3: add mixer version enum Ryan Walklin
2024-09-29  9:04 ` [PATCH v5 14/26] drm: sun4i: de2/de3: refactor mixer initialisation Ryan Walklin
2024-09-29  9:04 ` [PATCH v5 15/26] drm: sun4i: vi_scaler refactor vi_scaler enablement Ryan Walklin
2024-09-29  9:04 ` [PATCH v5 16/26] drm: sun4i: de2/de3: add generic blender register reference function Ryan Walklin
2024-09-29  9:04 ` [PATCH v5 17/26] drm: sun4i: de2/de3: use generic register reference function for layer configuration Ryan Walklin
2024-09-29  9:04 ` [PATCH v5 18/26] drm: sun4i: de3: Implement AFBC support Ryan Walklin
2024-09-29  9:04 ` [PATCH v5 19/26] dt-bindings: allwinner: add H616 DE33 bus binding Ryan Walklin
2025-02-12 17:27   ` Chris Morgan
2024-09-29  9:04 ` [PATCH v5 20/26] dt-bindings: allwinner: add H616 DE33 clock binding Ryan Walklin
2024-09-29  9:04 ` [PATCH v5 21/26] dt-bindings: allwinner: add H616 DE33 mixer binding Ryan Walklin
2025-02-12 17:31   ` Chris Morgan
2024-09-29  9:04 ` [PATCH v5 22/26] clk: sunxi-ng: ccu: add Display Engine 3.3 (DE33) support Ryan Walklin
2024-09-29  9:04 ` [PATCH v5 23/26] drm: sun4i: de33: mixer: " Ryan Walklin
2024-09-29  9:04 ` [PATCH v5 24/26] drm: sun4i: de33: vi_scaler: " Ryan Walklin
2024-09-29  9:04 ` [PATCH v5 25/26] drm: sun4i: de33: fmt: " Ryan Walklin
2024-09-29  9:04 ` [PATCH v5 26/26] drm: sun4i: de33: csc: " Ryan Walklin
2024-09-30 13:30 ` [PATCH v5 00/26] drm: sun4i: " Philippe Simons
2025-02-12 17:25   ` Chris Morgan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240929091107.838023-9-ryan@testtoast.com \
    --to=ryan@testtoast.com \
    --cc=airlied@gmail.com \
    --cc=andre.przywara@arm.com \
    --cc=conor+dt@kernel.org \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=macroalpha82@gmail.com \
    --cc=mripard@kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=robh@kernel.org \
    --cc=samuel@sholland.org \
    --cc=sboyd@kernel.org \
    --cc=tzimmermann@suse.de \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.