All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: linux-iio@vger.kernel.org
Cc: Petar Stoykov <pd.pstoykov@gmail.com>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] iio: pressure: sdp500: Add missing select CRC8
Date: Sun, 29 Sep 2024 18:23:31 +0100	[thread overview]
Message-ID: <20240929182331.2d532cd9@jic23-huawei> (raw)
In-Reply-To: <20240929172105.1819259-1-jic23@kernel.org>

On Sun, 29 Sep 2024 18:21:05 +0100
Jonathan Cameron <jic23@kernel.org> wrote:

> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> Fix:
>    sh4-linux-ld: drivers/iio/pressure/sdp500.o: in function `sdp500_probe':
> >> drivers/iio/pressure/sdp500.c:130:(.text+0xe8): undefined reference to `crc8_populate_msb'  
>    sh4-linux-ld: drivers/iio/pressure/sdp500.o: in function `sdp500_read_raw':
> >> drivers/iio/pressure/sdp500.c:74:(.text+0x200): undefined reference to `crc8'  
> 
> by adding missing select.

I've applied this one to the fixes-togreg branch of iio.git so the build issue
stops occuring in linux-next.

I'll be rebasing that on rc1 shortly anyway so if anyone wants to review that
would be ideal!

Jonathan

> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202409271341.0dhpXk7G-lkp@intel.com/
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
>  drivers/iio/pressure/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/pressure/Kconfig b/drivers/iio/pressure/Kconfig
> index ce369dbb17fc..df65438c771e 100644
> --- a/drivers/iio/pressure/Kconfig
> +++ b/drivers/iio/pressure/Kconfig
> @@ -253,6 +253,7 @@ config MS5637
>  config SDP500
>  	tristate "Sensirion SDP500 differential pressure sensor I2C driver"
>  	depends on I2C
> +	select CRC8
>  	help
>  	  Say Y here to build support for Sensirion SDP500 differential pressure
>  	  sensor I2C driver.


  reply	other threads:[~2024-09-29 17:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-29 17:21 [PATCH] iio: pressure: sdp500: Add missing select CRC8 Jonathan Cameron
2024-09-29 17:23 ` Jonathan Cameron [this message]
2024-09-29 17:27 ` Javier Carrasco
2024-09-30  8:56   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240929182331.2d532cd9@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=pd.pstoykov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.