From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B108018EAB; Sun, 29 Sep 2024 18:55:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727636106; cv=none; b=jwpCGMKHWVQQ+//KsTgRLJnfF0Xx5l/ch3HBg15IyZPX1OHLNPY8W6K9zSAp0CuqnaCES00m0VkO++FAfOZanmfz1BzhRE8vRwAvHs7ugoNHCRktLTYlC41RVDd3mtf2CB0UbiJUzrAznx8++Zx5kF6f3ybRoqw5nAzYZZxY0NU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727636106; c=relaxed/simple; bh=jAulFupwHSoaUi/6sQaBbxwLwD4EQjNV6hWdaK3VMeM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=i5Xw1GjtGlV34dEH1ZMSjiD/oC01mMGBsnTQ6YaWlOPIJ2+rS5FrsbOSgMxQ5TSQUuTYf6Ixk/bmrUT+XRRedOSjGtsmZzTLa0E8ZKl2huGdf079s8PwhQWzIOpE2IxB4nBhINxUBu9i6ojiBFwSokYFQwKeaCQcwx2odvPYPvY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fr9kzvy9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fr9kzvy9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75091C4CEC7; Sun, 29 Sep 2024 18:55:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727636106; bh=jAulFupwHSoaUi/6sQaBbxwLwD4EQjNV6hWdaK3VMeM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fr9kzvy9ZvXrAyv2UllxHifNu6IjR55if6yiVZdFsqEDWM8KeUI0i2OOazz1sJWgv C7FEhIX+Kv8rKL4HR2qbLhRniIw90m53J/xKlPjSUHTvLxQzmeHsOQfGpPe7zNPydx igiQKwOCunehcDRZ98DPEJvFwnQX6F+64GRE+zGIQbZUCsERuI8uzf7wQWQyYH/LgQ IYBhLr3Up0Y5MYZrivJNKR+oquf3PaSy3JHujxIAywf0gC6wdBK0Vp5oFNxKDhmmaA kX0Ijo0JsbL2WuHZ8K+T60FaR2mcFykzg5maIOHz5Do5MOUwczMMHqH9pe8OEFonhF Rq5ezJWx1L3ug== Date: Sun, 29 Sep 2024 21:55:01 +0300 From: Leon Romanovsky To: Eduard Zingerman , David Howells Cc: Christian Brauner , Manu Bretelle , asmadeus@codewreck.org, ceph-devel@vger.kernel.org, christian@brauner.io, ericvh@kernel.org, hsiangkao@linux.alibaba.com, idryomov@gmail.com, jlayton@kernel.org, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-nfs@vger.kernel.org, marc.dionne@auristor.com, netdev@vger.kernel.org, netfs@lists.linux.dev, pc@manguebit.com, smfrench@gmail.com, sprasad@microsoft.com, tom@talpey.com, v9fs@lists.linux.dev, willy@infradead.org Subject: Re: [PATCH v2 19/25] netfs: Speed up buffered reading Message-ID: <20240929185501.GA218692@unreal> References: <20240925103118.GE967758@unreal> <20240923183432.1876750-1-chantr4@gmail.com> <20240814203850.2240469-20-dhowells@redhat.com> <1279816.1727220013@warthog.procyon.org.uk> <4b5621958a758da830c1cf09c6f6893aed371f9d.camel@gmail.com> <2808175.1727601153@warthog.procyon.org.uk> Precedence: bulk X-Mailing-List: ceph-devel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: On Sun, Sep 29, 2024 at 02:37:44AM -0700, Eduard Zingerman wrote: > On Sun, 2024-09-29 at 10:12 +0100, David Howells wrote: > > Can you try the attached? I've also put it on my branch here: > >=20 > > https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/l= og/?h=3Dnetfs-fixes >=20 > Used your branch: > fc22830c5a07 ("9p: Don't revert the I/O iterator after reading") >=20 > dmesg is here: > https://gist.github.com/eddyz87/4cd50c2cf01323641999dc386e2d41eb >=20 > Still see null-ptr-deref. I tried it too and I can confirm that the issue is still there. Thanks >=20 > [...] >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 20E66CF6497 for ; Sun, 29 Sep 2024 18:55:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lists.ozlabs.org; s=201707; t=1727636114; bh=bGJCXemhC9dAtd5JgEfyPJDtjJnxzGiGPrBvY6sj9XI=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=OG9CZ5S1lnzwQp+UvEIK0zc24zTtdCTLtGtKUi4MMi8dHV1A6S7J+FvT2ob+4iegU Fq4S0xZ2RnOH1Pj4MnDjT9mMTQoDPeiEkOzFNNJegRppcjYjTilWDwTpQ2BGOnqVCh uBFfLX7uxcfROzuyoOYnpFbJZ1EjoniqzgVHELf0M8xiLES4vHe/HD9bXOBrdb39Sv ygKAVEh6mhajTW5J3SwJ3WoHrp+qy3rHGMRhvwdp6CP/azRh9y7XETKTIhUCY6kdME o7WGsuSlR3rvZBubXES95MmEkGUrXIduAVHkTfg0odsUVQ/YsaZWJwLlkPstK+dyqp IeRWkQwdV4+mw== Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4XGtgQ0RLyz2yRZ for ; Mon, 30 Sep 2024 04:55:14 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=139.178.84.217 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1727636110; cv=none; b=KDsPdEkrlDYDTivk2rY9lJ4S84M+eMgdSn3v8Kc5T1rzlVbChZUZLRR/puXqdFw3FKzYv3qbjr9H7Y4hSzR2s310Bxj8iNoO4YefuVRHQf5e2g8dqQ/puOSlsF8ZP0msAvXoKufd+wDB1TBT81ufUob6fQlZeQ82DEmNGtHBnkoQuuz7aBtgyynSqMM1OSIry/eyzkQ8s8bxHmO2qewY6IUZNhraSW560LEm0ITFrNf7+zTN02Wfs5FWhfkC0YOUT0eVaRZ4Ewh8lt72M4Ye8Ck1ZcKg8LdPGXeY1XL//6+fyDrtq77w7bHEuJmQ7+ARPTtGPJU2yf0hPtQubghQpQ== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1727636110; c=relaxed/relaxed; bh=bGJCXemhC9dAtd5JgEfyPJDtjJnxzGiGPrBvY6sj9XI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QkhzOA5gwWKYwcTK2Tn4tmQNRpO3vRqaVF9OcFIw894Ln9vilDF5+zAcQMqpCH3qnCnff0V7uWb8yu3oVX/dzxcVdcBCOos+KIf+Yu9XQiMqQqQ8pWAqjvuAbHlOSA2965pZE3jk1aG2DAKcmI185NY8TS7PHgR8GAmt6n5Ezn2+qCf9Y9cAl5fBWHn98/nfnEacYZgWVlOQaSBgHpCh0Nb3vOaPcf7auWPupmpcGJ7PkZR0aL/fwOBH14P7jhD7RPiSec4Z3qw81iLVsv3QKB7lKWDVZAiln811fD9uCax9faY++fJq0/jxlG4g4Mb3B2zvTCWnuiyot0swLqk0fg== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=fr9kzvy9; dkim-atps=neutral; spf=pass (client-ip=139.178.84.217; helo=dfw.source.kernel.org; envelope-from=leon@kernel.org; receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org Authentication-Results: lists.ozlabs.org; dmarc=pass (p=quarantine dis=none) header.from=kernel.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=fr9kzvy9; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=139.178.84.217; helo=dfw.source.kernel.org; envelope-from=leon@kernel.org; receiver=lists.ozlabs.org) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4XGtgK53Lrz2xfR for ; Mon, 30 Sep 2024 04:55:09 +1000 (AEST) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 935CD5C0709; Sun, 29 Sep 2024 18:55:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 75091C4CEC7; Sun, 29 Sep 2024 18:55:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727636106; bh=jAulFupwHSoaUi/6sQaBbxwLwD4EQjNV6hWdaK3VMeM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fr9kzvy9ZvXrAyv2UllxHifNu6IjR55if6yiVZdFsqEDWM8KeUI0i2OOazz1sJWgv C7FEhIX+Kv8rKL4HR2qbLhRniIw90m53J/xKlPjSUHTvLxQzmeHsOQfGpPe7zNPydx igiQKwOCunehcDRZ98DPEJvFwnQX6F+64GRE+zGIQbZUCsERuI8uzf7wQWQyYH/LgQ IYBhLr3Up0Y5MYZrivJNKR+oquf3PaSy3JHujxIAywf0gC6wdBK0Vp5oFNxKDhmmaA kX0Ijo0JsbL2WuHZ8K+T60FaR2mcFykzg5maIOHz5Do5MOUwczMMHqH9pe8OEFonhF Rq5ezJWx1L3ug== Date: Sun, 29 Sep 2024 21:55:01 +0300 To: Eduard Zingerman , David Howells Subject: Re: [PATCH v2 19/25] netfs: Speed up buffered reading Message-ID: <20240929185501.GA218692@unreal> References: <20240925103118.GE967758@unreal> <20240923183432.1876750-1-chantr4@gmail.com> <20240814203850.2240469-20-dhowells@redhat.com> <1279816.1727220013@warthog.procyon.org.uk> <4b5621958a758da830c1cf09c6f6893aed371f9d.camel@gmail.com> <2808175.1727601153@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Leon Romanovsky via Linux-erofs Reply-To: Leon Romanovsky Cc: asmadeus@codewreck.org, linux-mm@kvack.org, marc.dionne@auristor.com, linux-afs@lists.infradead.org, pc@manguebit.com, linux-cifs@vger.kernel.org, Manu Bretelle , willy@infradead.org, smfrench@gmail.com, hsiangkao@linux.alibaba.com, idryomov@gmail.com, sprasad@microsoft.com, linux-nfs@vger.kernel.org, tom@talpey.com, ceph-devel@vger.kernel.org, ericvh@kernel.org, christian@brauner.io, Christian Brauner , netdev@vger.kernel.org, v9fs@lists.linux.dev, jlayton@kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, netfs@lists.linux.dev, linux-erofs@lists.ozlabs.org Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" On Sun, Sep 29, 2024 at 02:37:44AM -0700, Eduard Zingerman wrote: > On Sun, 2024-09-29 at 10:12 +0100, David Howells wrote: > > Can you try the attached? I've also put it on my branch here: > >=20 > > https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/l= og/?h=3Dnetfs-fixes >=20 > Used your branch: > fc22830c5a07 ("9p: Don't revert the I/O iterator after reading") >=20 > dmesg is here: > https://gist.github.com/eddyz87/4cd50c2cf01323641999dc386e2d41eb >=20 > Still see null-ptr-deref. I tried it too and I can confirm that the issue is still there. Thanks >=20 > [...] >=20