From: kernel test robot <lkp@intel.com>
To: Otavio Salvador <otavio@ossystems.com.br>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [freescale-fslc:6.6-2.0.x-imx 3650/16788] drivers/rpmsg/imx_rpmsg.c:371:6: warning: no previous prototype for 'imx_rpmsg_restore'
Date: Sun, 29 Sep 2024 23:19:15 +0800 [thread overview]
Message-ID: <202409292304.O0065cFS-lkp@intel.com> (raw)
tree: https://github.com/Freescale/linux-fslc 6.6-2.0.x-imx
head: ac32ba5fe66266329914d2020570364afe217bec
commit: a388cfc5b5001e76c8c3b9866d6e9abf44d03c58 [3650/16788] rpmsg: imx_rpmsg: add partition reset notify
config: i386-buildonly-randconfig-004-20240928 (https://download.01.org/0day-ci/archive/20240929/202409292304.O0065cFS-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240929/202409292304.O0065cFS-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409292304.O0065cFS-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/rpmsg/imx_rpmsg.c:371:6: warning: no previous prototype for 'imx_rpmsg_restore' [-Wmissing-prototypes]
371 | void imx_rpmsg_restore(struct imx_rpmsg_vproc *rpdev)
| ^~~~~~~~~~~~~~~~~
vim +/imx_rpmsg_restore +371 drivers/rpmsg/imx_rpmsg.c
369
370 #ifdef CONFIG_IMX_SCU
> 371 void imx_rpmsg_restore(struct imx_rpmsg_vproc *rpdev)
372 {
373 int i;
374 int vdev_nums = rpdev->vdev_nums;
375
376 for (i = 0; i < vdev_nums; i++) {
377 unregister_virtio_device(&rpdev->ivdev[i]->vdev);
378 kfree(rpdev->ivdev[i]);
379 }
380
381 /* Make a double check that remote processor is ready or not */
382 for (i = 0; i < REMOTE_READY_WAIT_MAX_RETRIES; i++) {
383 if (rpdev->flags & REMOTE_IS_READY)
384 break;
385 udelay(100);
386 }
387 if (unlikely((rpdev->flags & REMOTE_IS_READY) == 0)) {
388 pr_err("Wait for remote ready timeout, assume it's dead.\n");
389 /*
390 * In order to make the codes to be robust and back compatible.
391 * When wait remote ready timeout, use the MU_SendMessageTimeout
392 * to send the first kick-off message when register the vdev.
393 */
394 rpdev->first_notify = rpdev->vdev_nums;
395 }
396
397 /* Allocate and setup ivdev again to register virtio devices */
398 if (set_vring_phy_buf(rpdev->pdev, rpdev, rpdev->vdev_nums))
399 pr_err("No vring buffer.\n");
400
401 for (i = 0; i < vdev_nums; i++) {
402 rpdev->ivdev[i]->vdev.id.device = VIRTIO_ID_RPMSG;
403 rpdev->ivdev[i]->vdev.config = &imx_rpmsg_config_ops;
404 rpdev->ivdev[i]->vdev.dev.parent = &rpdev->pdev->dev;
405 rpdev->ivdev[i]->vdev.dev.release = imx_rpmsg_vproc_release;
406 rpdev->ivdev[i]->base_vq_id = i * 2;
407 rpdev->ivdev[i]->rpdev = rpdev;
408
409 if (register_virtio_device(&rpdev->ivdev[i]->vdev))
410 pr_err("%s failed to register rpdev.\n", __func__);
411 }
412 }
413
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2024-09-29 15:19 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202409292304.O0065cFS-lkp@intel.com \
--to=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=otavio@ossystems.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.