From: Conor Dooley <conor@kernel.org>
To: pierre-henry.moussay@microchip.com
Cc: Linux4Microchip@microchip.com,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Samuel Holland <samuel.holland@sifive.com>,
linux-riscv@lists.infradead.org
Subject: Re: [linux][PATCH v2 00/20] Add support for Microchip PIC64GX Curiosity Kit
Date: Mon, 30 Sep 2024 15:03:31 +0100 [thread overview]
Message-ID: <20240930-anointer-pork-ff98fd24bb2f@spud> (raw)
In-Reply-To: <20240930095449.1813195-1-pierre-henry.moussay@microchip.com>
[-- Attachment #1.1: Type: text/plain, Size: 1241 bytes --]
On Mon, Sep 30, 2024 at 10:54:29AM +0100, pierre-henry.moussay@microchip.com wrote:
> From: Pierre-Henry Moussay <pierre-henry.moussay@microchip.com>
>
> Changes since v1:
> - Limit sdhci to HS (High Speed, 50MHz at 3.3V) mode max
> - Fix I2C dt-bindings, remove microchip,mpfs-i2c fallback
> - remove duplicated pic64gx-clock.h
> - Update Microchip dts Makefile
> - Update PIC64GX dts and dtsi (fix model, sort node)
> - Remove microchip,pic64gx-clock.h present in previous patchset
> - Reword commits messages
>
> Hi all,
>
> This V2 patchset is incomplete and doesn't address all the
> comments from the V1 patchset. More precisely the request on the following
> commit have not been addressed:
> [PATCH 08/17] dt-bindings: clock: mpfs-clkcfg: Add PIC64GX compatibility
> This will be fix in a V3 coming in due time.
It's not really clear from this comment that there are other problems
that were in the v1 that have remained in the v2 - the mailbox and
system controller feedback that I gave on v1. I've pointed all three out
again here against the relevant patches, and will hopefully have a
non-RFC implementation of what I want the pic64gx based on w.r.t
clock/mailbox sent this week.
Cheers,
Conor.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2024-09-30 14:17 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 9:54 [linux][PATCH v2 00/20] Add support for Microchip PIC64GX Curiosity Kit pierre-henry.moussay
2024-09-30 9:54 ` [linux][PATCH v2 01/20] dt-bindings: can: mpfs: add PIC64GX CAN compatibility pierre-henry.moussay
2024-09-30 9:54 ` pierre-henry.moussay
2024-09-30 13:41 ` Conor Dooley
2024-09-30 13:41 ` Conor Dooley
2024-09-30 16:32 ` Marc Kleine-Budde
2024-09-30 16:32 ` Marc Kleine-Budde
2024-09-30 16:37 ` Conor Dooley
2024-09-30 16:37 ` Conor Dooley
2024-09-30 16:51 ` Marc Kleine-Budde
2024-09-30 16:51 ` Marc Kleine-Budde
2024-09-30 9:54 ` [linux][PATCH v2 02/20] dt-bindings: usb: add PIC64GX compatibility to mpfs-musb driver pierre-henry.moussay
2024-09-30 9:54 ` pierre-henry.moussay
2024-09-30 13:41 ` Conor Dooley
2024-09-30 13:41 ` Conor Dooley
2024-09-30 9:54 ` [linux][PATCH v2 03/20] dt-bindings: mbox: add PIC64GX mailbox compatibility to MPFS mailbox pierre-henry.moussay
2024-09-30 9:54 ` pierre-henry.moussay
2024-09-30 13:44 ` Conor Dooley
2024-09-30 13:44 ` Conor Dooley
2024-09-30 9:54 ` [linux][PATCH v2 04/20] dt-bindings: spi: add PIC64GX SPI/QSPI compatibility to MPFS SPI/QSPI bindings pierre-henry.moussay
2024-09-30 9:54 ` pierre-henry.moussay
2024-09-30 13:45 ` Conor Dooley
2024-09-30 13:45 ` Conor Dooley
2024-09-30 13:52 ` Mark Brown
2024-09-30 13:52 ` Mark Brown
2024-09-30 13:55 ` Conor Dooley
2024-09-30 13:55 ` Conor Dooley
2024-09-30 13:53 ` Mark Brown
2024-09-30 13:53 ` Mark Brown
2024-09-30 9:54 ` [linux][PATCH v2 05/20] dt-bindings: gpio: mpfs-gpio: Add PIC64GX GPIO compatibility pierre-henry.moussay
2024-09-30 9:54 ` pierre-henry.moussay
2024-09-30 13:46 ` Conor Dooley
2024-09-30 13:46 ` Conor Dooley
2024-09-30 9:54 ` [linux][PATCH v2 06/20] dt-bindings: cache: sifive,ccache0: add a PIC64GX compatible pierre-henry.moussay
2024-09-30 9:54 ` pierre-henry.moussay
2024-09-30 13:47 ` Conor Dooley
2024-09-30 13:47 ` Conor Dooley
2024-09-30 9:54 ` [linux][PATCH v2 07/20] dt-bindings: clock: mpfs-ccc: Add PIC64GX compatibility pierre-henry.moussay
2024-09-30 9:54 ` pierre-henry.moussay
2024-09-30 13:47 ` Conor Dooley
2024-09-30 13:47 ` Conor Dooley
2024-09-30 9:54 ` [linux][PATCH v2 08/20] dt-bindings: clock: mpfs-clkcfg: " pierre-henry.moussay
2024-09-30 9:54 ` pierre-henry.moussay
2024-09-30 13:47 ` Conor Dooley
2024-09-30 13:47 ` Conor Dooley
2024-09-30 9:54 ` [linux][PATCH v2 09/20] dt-bindings: dma: sifive pdma: Add PIC64GX to compatibles pierre-henry.moussay
2024-09-30 9:54 ` pierre-henry.moussay
2024-09-30 13:48 ` Conor Dooley
2024-09-30 13:48 ` Conor Dooley
2024-09-30 9:54 ` [linux][PATCH v2 10/20] dt-bindings: i2c: microchip: corei2c: Add PIC64GX as compatible with driver pierre-henry.moussay
2024-09-30 9:54 ` pierre-henry.moussay
2024-09-30 13:48 ` Conor Dooley
2024-09-30 13:48 ` Conor Dooley
2024-10-02 10:40 ` Andi Shyti
2024-10-02 10:40 ` Andi Shyti
2024-09-30 9:54 ` [linux][PATCH v2 11/20] dt-bindings: mmc: cdns: document Microchip PIC64GX MMC/SDHCI controller pierre-henry.moussay
2024-09-30 13:49 ` Conor Dooley
2024-10-08 14:36 ` Ulf Hansson
2024-09-30 9:54 ` [linux][PATCH v2 12/20] dt-bindings: net: cdns,macb: Add PIC64GX compatibility pierre-henry.moussay
2024-09-30 13:52 ` Conor Dooley
2024-09-30 9:54 ` [linux][PATCH v2 13/20] dt-bindings: rtc: mfps-rtc: " pierre-henry.moussay
2024-09-30 13:53 ` Conor Dooley
2024-10-11 10:10 ` (subset) " Alexandre Belloni
2024-09-30 9:54 ` [linux][PATCH v2 14/20] dt-bindings: soc: microchip: mpfs-sys-controller: " pierre-henry.moussay
2024-09-30 9:54 ` pierre-henry.moussay
2024-09-30 13:53 ` Conor Dooley
2024-09-30 13:53 ` Conor Dooley
2024-09-30 9:54 ` [linux][PATCH v2 15/20] dt-bindings: riscv: microchip: document the PIC64GX curiosity kit pierre-henry.moussay
2024-09-30 9:54 ` pierre-henry.moussay
2024-09-30 13:54 ` Conor Dooley
2024-09-30 13:54 ` Conor Dooley
2024-09-30 9:54 ` [linux][PATCH v2 16/20] dt-bindings: mmc: cdns,sdhci: ref sdhci-common.yaml pierre-henry.moussay
2024-10-08 14:36 ` Ulf Hansson
2024-09-30 9:54 ` [linux][PATCH v2 17/20] dt-bindings: timer: sifive,clint: add PIC64GX compatibility pierre-henry.moussay
2024-09-30 9:54 ` pierre-henry.moussay
2024-09-30 13:56 ` Conor Dooley
2024-09-30 13:56 ` Conor Dooley
2024-09-30 9:54 ` [linux][PATCH v2 18/20] dt-bindings: interrupt-controller: sifive,plic: Add " pierre-henry.moussay
2024-09-30 9:54 ` pierre-henry.moussay
2024-09-30 13:56 ` Conor Dooley
2024-09-30 13:56 ` Conor Dooley
2024-09-30 9:54 ` [linux][PATCH v2 19/20] riscv: dts: microchip: add PIC64GX Curiosity Kit dts pierre-henry.moussay
2024-09-30 9:54 ` pierre-henry.moussay
2024-09-30 9:54 ` [linux][PATCH v2 20/20] riscv: dts: microchip: remove POLARFIRE mention in Makefile pierre-henry.moussay
2024-09-30 9:54 ` pierre-henry.moussay
2024-09-30 14:03 ` Conor Dooley [this message]
2024-10-22 5:33 ` (subset) [linux][PATCH v2 00/20] Add support for Microchip PIC64GX Curiosity Kit Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240930-anointer-pork-ff98fd24bb2f@spud \
--to=conor@kernel.org \
--cc=Linux4Microchip@microchip.com \
--cc=aou@eecs.berkeley.edu \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=pierre-henry.moussay@microchip.com \
--cc=samuel.holland@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.