From: Bjorn Helgaas <helgaas@kernel.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: "Krishna chaitanya chundru" <quic_krichai@quicinc.com>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
quic_vbadigan@quicinc.com, quic_ramkri@quicinc.com,
quic_nitegupt@quicinc.com, quic_skananth@quicinc.com,
quic_vpernami@quicinc.com, quic_mrana@quicinc.com,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v2 1/2] PCI: qcom: Skip wait for link up if global IRQ handler is present
Date: Mon, 30 Sep 2024 12:01:29 -0500 [thread overview]
Message-ID: <20240930170129.GA179772@bhelgaas> (raw)
In-Reply-To: <20240930074910.yeuujpwqyq32lehw@thinkpad>
On Mon, Sep 30, 2024 at 09:49:10AM +0200, Manivannan Sadhasivam wrote:
> On Fri, Sep 20, 2024 at 03:47:59PM +0530, Krishna chaitanya chundru wrote:
>
> Subject should be modified to reflect the fact that the link up is skipped in
> the dwc driver.
>
> PCI: dwc: Skip waiting for link up if vendor drivers can detect Link up event
>
> > In cases where a global IRQ handler is present to manage link up
> > interrupts, it may not be necessary to wait for the link to be up
> > during PCI initialization which optimizes the bootup time.
>
> How about,
>
> "If the vendor drivers can detect the Link up event using mechanisms
> such as Link up IRQ, then waiting for Link up during probe is not
> needed. So let's skip waiting for link to be up if the driver
> supports 'linkup_irq'.
I avoid the "let's do X" structure because "let's do" is a proposal.
The patch actually *does* it, so it's more than a proposal.
Also, it would be helpful to extend this with a note about *why* we
can avoid waiting, i.e., if we can be notified when the link comes up,
we can enumerate downstream devices then instead of waiting here.
I suppose the "global" name is already set by DTs, but the name seems
far too general to me.
Bjorn
next prev parent reply other threads:[~2024-09-30 17:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-20 10:17 [PATCH v2 0/2] PCI: qcom: Skip wait for link up if global IRQ handler is present Krishna chaitanya chundru
2024-09-20 10:17 ` [PATCH v2 1/2] " Krishna chaitanya chundru
2024-09-30 7:49 ` Manivannan Sadhasivam
2024-09-30 17:01 ` Bjorn Helgaas [this message]
2024-09-20 10:18 ` [PATCH v2 2/2] PCI: qcom: Update ICC and OPP values during link up event Krishna chaitanya chundru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240930170129.GA179772@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=jingoohan1@gmail.com \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=quic_krichai@quicinc.com \
--cc=quic_mrana@quicinc.com \
--cc=quic_nitegupt@quicinc.com \
--cc=quic_ramkri@quicinc.com \
--cc=quic_skananth@quicinc.com \
--cc=quic_vbadigan@quicinc.com \
--cc=quic_vpernami@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.