All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rosen Penev <rosenp@gmail.com>
To: netdev@vger.kernel.org
Cc: andrew@lunn.ch, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com, linux-kernel@vger.kernel.org,
	jacob.e.keller@intel.com, horms@kernel.org, sd@queasysnail.net,
	chunkeey@gmail.com
Subject: [PATCH net-next 08/13] net: ibm: emac: rgmii: use devm for kzalloc
Date: Mon, 30 Sep 2024 11:00:31 -0700	[thread overview]
Message-ID: <20240930180036.87598-9-rosenp@gmail.com> (raw)
In-Reply-To: <20240930180036.87598-1-rosenp@gmail.com>

Simplifies the probe function by removing gotos.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 drivers/net/ethernet/ibm/emac/rgmii.c | 21 ++++++---------------
 1 file changed, 6 insertions(+), 15 deletions(-)

diff --git a/drivers/net/ethernet/ibm/emac/rgmii.c b/drivers/net/ethernet/ibm/emac/rgmii.c
index 52f080661f87..8c646a5e5c56 100644
--- a/drivers/net/ethernet/ibm/emac/rgmii.c
+++ b/drivers/net/ethernet/ibm/emac/rgmii.c
@@ -219,28 +219,25 @@ static int rgmii_probe(struct platform_device *ofdev)
 	struct device_node *np = ofdev->dev.of_node;
 	struct rgmii_instance *dev;
 	struct resource regs;
-	int rc;
 
-	rc = -ENOMEM;
-	dev = kzalloc(sizeof(struct rgmii_instance), GFP_KERNEL);
-	if (dev == NULL)
-		goto err_gone;
+	dev = devm_kzalloc(&ofdev->dev, sizeof(struct rgmii_instance),
+			   GFP_KERNEL);
+	if (!dev)
+		return -ENOMEM;
 
 	mutex_init(&dev->lock);
 	dev->ofdev = ofdev;
 
-	rc = -ENXIO;
 	if (of_address_to_resource(np, 0, &regs)) {
 		printk(KERN_ERR "%pOF: Can't get registers address\n", np);
-		goto err_free;
+		return -ENXIO;
 	}
 
-	rc = -ENOMEM;
 	dev->base = (struct rgmii_regs __iomem *)ioremap(regs.start,
 						 sizeof(struct rgmii_regs));
 	if (dev->base == NULL) {
 		printk(KERN_ERR "%pOF: Can't map device registers!\n", np);
-		goto err_free;
+		return -ENOMEM;
 	}
 
 	/* Check for RGMII flags */
@@ -266,11 +263,6 @@ static int rgmii_probe(struct platform_device *ofdev)
 	platform_set_drvdata(ofdev, dev);
 
 	return 0;
-
- err_free:
-	kfree(dev);
- err_gone:
-	return rc;
 }
 
 static void rgmii_remove(struct platform_device *ofdev)
@@ -280,7 +272,6 @@ static void rgmii_remove(struct platform_device *ofdev)
 	WARN_ON(dev->users != 0);
 
 	iounmap(dev->base);
-	kfree(dev);
 }
 
 static const struct of_device_id rgmii_match[] =
-- 
2.46.2


  parent reply	other threads:[~2024-09-30 18:00 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-30 18:00 [PATCH net-next 00/13] ibm: emac: more cleanups Rosen Penev
2024-09-30 18:00 ` [PATCH net-next 01/13] net: ibm: emac: remove custom init/exit functions Rosen Penev
2024-09-30 18:00 ` [PATCH net-next 02/13] net: ibm: emac: use module_platform_driver for modules Rosen Penev
2024-09-30 18:00 ` [PATCH net-next 03/13] net: ibm: emac: use devm_platform_ioremap_resource Rosen Penev
2024-09-30 18:00 ` [PATCH net-next 04/13] net: ibm: emac: use platform_get_irq Rosen Penev
2024-09-30 18:00 ` [PATCH net-next 05/13] net: ibm: emac: remove bootlist support Rosen Penev
2024-09-30 18:00 ` [PATCH net-next 06/13] net: ibm: emac: tah: use devm for kzalloc Rosen Penev
2024-09-30 18:00 ` [PATCH net-next 07/13] net: ibm: emac: tah: devm_platform_get_resources Rosen Penev
2024-09-30 18:00 ` Rosen Penev [this message]
2024-09-30 18:00 ` [PATCH net-next 09/13] net: ibm: emac: rgmii: devm_platform_get_resource Rosen Penev
2024-10-01  8:24   ` kernel test robot
2024-10-01 13:25     ` Simon Horman
2024-10-01 19:35       ` Rosen Penev
2024-10-01  9:06   ` kernel test robot
2024-09-30 18:00 ` [PATCH net-next 10/13] net: ibm: emac: zmii: use devm for kzalloc Rosen Penev
2024-09-30 18:00 ` [PATCH net-next 11/13] net: ibm: emac: zmii: devm_platform_get_resource Rosen Penev
2024-09-30 18:00 ` [PATCH net-next 12/13] net: ibm: emac: mal: use devm for kzalloc Rosen Penev
2024-09-30 18:00 ` [PATCH net-next 13/13] net: ibm: emac: mal: use devm for request_irq Rosen Penev
2024-10-01 13:32   ` Simon Horman
2024-10-01 19:35     ` Rosen Penev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240930180036.87598-9-rosenp@gmail.com \
    --to=rosenp@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=chunkeey@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=jacob.e.keller@intel.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sd@queasysnail.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.