From: Simon Horman <horms@kernel.org>
To: Nick Child <nnac123@linux.ibm.com>
Cc: netdev@vger.kernel.org, haren@linux.ibm.com, ricklind@us.ibm.com
Subject: Re: [PATCH net 2/2] ibmvnic: Inspect header requirements before using scrq direct
Date: Tue, 1 Oct 2024 12:07:21 +0100 [thread overview]
Message-ID: <20241001110721.GN1310185@kernel.org> (raw)
In-Reply-To: <20240930175635.1670111-2-nnac123@linux.ibm.com>
On Mon, Sep 30, 2024 at 12:56:35PM -0500, Nick Child wrote:
> Previously, the TX header requirement for standard frames was ignored.
> This requirement is a bitstring sent from the VIOS which maps to the
> type of header information needed during TX. If no header information,
> is needed then send subcrq direct can be used (which can be more
> performant).
>
> This bitstring was previously ignored for standard packets (AKA non LSO,
> non CSO) due to the belief that the bitstring was over-cautionary. It
> turns out that there are some configurations where the backing device
> does need header information for transmission of standard packets. If
> the information is not supplied then this causes continuous "Adapter
> error" transport events. Therefore, this bitstring should be respected
> and observed before considering the use of send subcrq direct.
>
> Fixes: 1c33e29245cc ("ibmvnic: Only record tx completed bytes once per handler")
>
nit: No blank line between Fixes and other tags please.
Slightly more importantly, perhaps naively, I would have thought this
Fixes: 076ae667be9f ("net: netconsole: do not pass userdata up to the tail")
> Signed-off-by: Nick Child <nnac123@linux.ibm.com>
...
next prev parent reply other threads:[~2024-10-01 11:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 17:56 [PATCH net 1/2] ibmvnic: Add stat for tx direct vs tx batched Nick Child
2024-09-30 17:56 ` [PATCH net 2/2] ibmvnic: Inspect header requirements before using scrq direct Nick Child
2024-10-01 11:07 ` Simon Horman [this message]
2024-10-01 11:08 ` [PATCH net 1/2] ibmvnic: Add stat for tx direct vs tx batched Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241001110721.GN1310185@kernel.org \
--to=horms@kernel.org \
--cc=haren@linux.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=nnac123@linux.ibm.com \
--cc=ricklind@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.