From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 12EBBCE7CE7 for ; Tue, 1 Oct 2024 09:12:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JOzKU1DLxwpEqSzeEP4Bmffo3NCWPga/QAZwmaUTSEA=; b=HFuVk+xjtHJngd DkTOBnIq2oMwyJCUt0LBmi5ciSzp3YPvA8Wo/TXYvFqiH9PvB8XQmS75ujBJb5P8mmc5QboQGFJ76 c4GT9j5FccG92HyXFy30r1NlER/cQFgDBcEX4XYzXEg44L928D2Xsdj3LNJ21T7tBHbjNydo/0y4l C8kkWNZR5/HhbXsLmLfzCWxAwpQdti9Xm6OEL1S49Wroqxvjof41aHbCea3wF27A2KPnjyggZg2Lj ZiJNvZjS59imzSOnlJuV9AUrDovMcBwkP6tJlFnMUDwWzRxEtYxF28ZZP1mrjs3oCy9+3IMwDZs5f 7SCSi/p2t5KyBZupKG1A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1svYvu-00000002C4b-0cbL; Tue, 01 Oct 2024 09:12:38 +0000 Received: from relay3-d.mail.gandi.net ([2001:4b98:dc4:8::223]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1svYvq-00000002C3p-16OJ for linux-mtd@lists.infradead.org; Tue, 01 Oct 2024 09:12:36 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id 3ECFE6000D; Tue, 1 Oct 2024 09:12:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1727773950; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L8e0/MF0EAHqslKXTtTfPt+/H8jOhZk2+bky0/VQZJg=; b=igZKjK1KY646cAPTO0FysAwddUJvKu3bVXfv9xU3id6yEp21t72YdRsB8QQYSLAuuQ549O DrAdgdhlcY5w1DY+zs0ia9MhSivk5sWnF1bBn43Ca8VhFpT/IKhhJ56puImFGo77KaYuJF 3BzboTz6hQi8DxwuFxSvCbpUk8c8Tl7VdNQHaAn6Zy5f8GYJJYsGppDMiHm5TLOz0/t+Gr Ssz+GGlUu+2AP2phfOapXW0mDV1nxppT+8MvHjtpWf0bzNsxlQJvfL+EqMFrklWEnzkU2a OV4LHtFhm7WZ/zkE8BNWtOvd6mrFR23Ak+F58VaoCfcfEqLX9KMbG+DXAowWww== Date: Tue, 1 Oct 2024 11:12:25 +0200 From: Miquel Raynal To: Martin Kurbanov Cc: Richard Weinberger , Vignesh Raghavendra , Mika Westerberg , Michael Walle , "Mark Brown" , Chia-Lin Kao , "Md Sadre Alam" , Ezra Buehler , Sridharan S N , Frieder Schrempf , Alexey Romanov , , , Subject: Re: [PATCH v2 2/5] mtd: spinand: add OTP support Message-ID: <20241001111225.36cb9701@xps-13> In-Reply-To: <20240827174920.316756-3-mmkurbanov@salutedevices.com> References: <20240827174920.316756-1-mmkurbanov@salutedevices.com> <20240827174920.316756-3-mmkurbanov@salutedevices.com> Organization: Bootlin X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-GND-Sasl: miquel.raynal@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241001_021234_951530_FCA798CB X-CRM114-Status: GOOD ( 33.33 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgTWFydGluLAoKbW1rdXJiYW5vdkBzYWx1dGVkZXZpY2VzLmNvbSB3cm90ZSBvbiBUdWUsIDI3 IEF1ZyAyMDI0IDIwOjQ5OjAwICswMzAwOgoKPiBUaGUgTVREIHN1YnN5c3RlbSBhbHJlYWR5IHN1 cHBvcnRzIGFjY2Vzc2luZyB0d28gT1RQIGFyZWFzOiB1c2VyIGFuZAo+IGZhY3RvcnkuIFVzZXIg YXJlYXMgY2FuIGJlIHdyaXR0ZW4gYnkgdGhlIHVzZXIuIFRoaXMgcGF0Y2ggb25seSBhZGRzCj4g c3VwcG9ydCBmb3IgdGhlIHVzZXIgYXJlYXMuCj4gCj4gSW4gdGhpcyBwYXRjaCB0aGUgT1RQX0lO Rk8gbWFjcm8gaXMgcHJvdmlkZWQgdG8gYWRkIHBhcmFtZXRlcnMgdG8KPiBzcGluYW5kX2luZm8u Cj4gVG8gaW1wbGVtZW50IE9UUCBvcGVyYXRpb25zLCB0aGUgY2xpZW50IChmbGFzaCBkcml2ZXIp IGlzIHByb3ZpZGVkIHdpdGgKPiA1IGNhbGxiYWNrczogLnJlYWQoKSwgLndyaXRlKCksIC5pbmZv KCksIC5sb2NrKCksIC5lcmFzZSgpLgoKT3ZlcmFsbCB0aGlzIGxvb2tzIGdvb2QsIEkgaGF2ZSBt aW5vciBjaGFuZ2VzIHRvIHJlcXVlc3QuIEknbSBub3QgeWV0CmRvbmUgZG93biB0byB0aGUgbGFz dCBwYXRjaCwgYnV0IEkgdGhpbmsgdGhlIGltcGxlbWVudGF0aW9uIGlzIG5lYXQuCgo+IFNpZ25l ZC1vZmYtYnk6IE1hcnRpbiBLdXJiYW5vdiA8bW1rdXJiYW5vdkBzYWx1dGVkZXZpY2VzLmNvbT4K PiAtLS0KPiAgZHJpdmVycy9tdGQvbmFuZC9zcGkvTWFrZWZpbGUgfCAgIDMgKy0KPiAgZHJpdmVy cy9tdGQvbmFuZC9zcGkvY29yZS5jICAgfCAgIDMgKwo+ICBkcml2ZXJzL210ZC9uYW5kL3NwaS9v dHAuYyAgICB8IDIzMiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gIGluY2x1 ZGUvbGludXgvbXRkL3NwaW5hbmQuaCAgIHwgIDU2ICsrKysrKysrCj4gIDQgZmlsZXMgY2hhbmdl ZCwgMjkzIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPiAgY3JlYXRlIG1vZGUgMTAwNjQ0 IGRyaXZlcnMvbXRkL25hbmQvc3BpL290cC5jCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbXRk L25hbmQvc3BpL01ha2VmaWxlIGIvZHJpdmVycy9tdGQvbmFuZC9zcGkvTWFrZWZpbGUKPiBpbmRl eCAxOWNjNzcyODhlYmJjLi42MGQyZTgzMGZmYzZiIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvbXRk L25hbmQvc3BpL01ha2VmaWxlCj4gKysrIGIvZHJpdmVycy9tdGQvbmFuZC9zcGkvTWFrZWZpbGUK PiBAQCAtMSw0ICsxLDUgQEAKPiAgIyBTUERYLUxpY2Vuc2UtSWRlbnRpZmllcjogR1BMLTIuMAo+ IC1zcGluYW5kLW9ianMgOj0gY29yZS5vIGFsbGlhbmNlbWVtb3J5Lm8gYXRvLm8gZXNtdC5vIGZv cmVzZWUubyBnaWdhZGV2aWNlLm8gbWFjcm9uaXgubwo+ICtzcGluYW5kLW9ianMgOj0gY29yZS5v IG90cC5vCj4gK3NwaW5hbmQtb2JqcyArPSBhbGxpYW5jZW1lbW9yeS5vIGF0by5vIGVzbXQubyBm b3Jlc2VlLm8gZ2lnYWRldmljZS5vIG1hY3Jvbml4Lm8KPiAgc3BpbmFuZC1vYmpzICs9IG1pY3Jv bi5vIHBhcmFnb24ubyB0b3NoaWJhLm8gd2luYm9uZC5vIHh0eC5vCj4gIG9iai0kKENPTkZJR19N VERfU1BJX05BTkQpICs9IHNwaW5hbmQubwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL210ZC9uYW5k L3NwaS9jb3JlLmMgYi9kcml2ZXJzL210ZC9uYW5kL3NwaS9jb3JlLmMKPiBpbmRleCA4MDdjMjRi MGM3YzRmLi4yY2I4MjVlZGQ0OWQwIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvbXRkL25hbmQvc3Bp L2NvcmUuYwo+ICsrKyBiL2RyaXZlcnMvbXRkL25hbmQvc3BpL2NvcmUuYwo+IEBAIC0xMTExLDYg KzExMTEsNyBAQCBpbnQgc3BpbmFuZF9tYXRjaF9hbmRfaW5pdChzdHJ1Y3Qgc3BpbmFuZF9kZXZp Y2UgKnNwaW5hbmQsCj4gIAkJc3BpbmFuZC0+ZmxhZ3MgPSB0YWJsZVtpXS5mbGFnczsKPiAgCQlz cGluYW5kLT5pZC5sZW4gPSAxICsgdGFibGVbaV0uZGV2aWQubGVuOwo+ICAJCXNwaW5hbmQtPnNl bGVjdF90YXJnZXQgPSB0YWJsZVtpXS5zZWxlY3RfdGFyZ2V0Owo+ICsJCXNwaW5hbmQtPm90cCA9 ICZ0YWJsZVtpXS5vdHA7Cj4gIAo+ICAJCW9wID0gc3BpbmFuZF9zZWxlY3Rfb3BfdmFyaWFudChz cGluYW5kLAo+ICAJCQkJCSAgICAgICBpbmZvLT5vcF92YXJpYW50cy5yZWFkX2NhY2hlKTsKPiBA QCAtMTI5Miw2ICsxMjkzLDggQEAgc3RhdGljIGludCBzcGluYW5kX2luaXQoc3RydWN0IHNwaW5h bmRfZGV2aWNlICpzcGluYW5kKQo+ICAJbXRkLT5fbWF4X2JhZF9ibG9ja3MgPSBuYW5kZGV2X210 ZF9tYXhfYmFkX2Jsb2NrczsKPiAgCW10ZC0+X3Jlc3VtZSA9IHNwaW5hbmRfbXRkX3Jlc3VtZTsK PiAgCj4gKwlzcGluYW5kX3NldF9tdGRfb3RwX29wcyhzcGluYW5kKTsKPiArCj4gIAlpZiAobmFu ZC0+ZWNjLmVuZ2luZSkgewo+ICAJCXJldCA9IG10ZF9vb2JsYXlvdXRfY291bnRfZnJlZWJ5dGVz KG10ZCk7Cj4gIAkJaWYgKHJldCA8IDApCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbXRkL25hbmQv c3BpL290cC5jIGIvZHJpdmVycy9tdGQvbmFuZC9zcGkvb3RwLmMKPiBuZXcgZmlsZSBtb2RlIDEw MDY0NAo+IGluZGV4IDAwMDAwMDAwMDAwMDAuLmQ0NTlmODExZjljMDQKPiAtLS0gL2Rldi9udWxs Cj4gKysrIGIvZHJpdmVycy9tdGQvbmFuZC9zcGkvb3RwLmMKPiBAQCAtMCwwICsxLDIzMiBAQAo+ ICsvLyBTUERYLUxpY2Vuc2UtSWRlbnRpZmllcjogR1BMLTIuMAo+ICsvKgo+ICsgKiBDb3B5cmln aHQgKGMpIDIwMjQsIFNhbHV0ZURldmljZXMuIEFsbCBSaWdodHMgUmVzZXJ2ZWQuCj4gKyAqCj4g KyAqIEF1dGhvcjogTWFydGluIEt1cmJhbm92IDxtbWt1cmJhbm92QHNhbHV0ZWRldmljZXMuY29t Pgo+ICsgKi8KPiArCj4gKyNpbmNsdWRlIDxsaW51eC9tdGQvbXRkLmg+Cj4gKyNpbmNsdWRlIDxs aW51eC9tdGQvc3BpbmFuZC5oPgo+ICsKPiArc3RhdGljIHVuc2lnbmVkIGludCBzcGluYW5kX290 cF9ucGFnZXMoY29uc3Qgc3RydWN0IHNwaW5hbmRfZGV2aWNlICpzcGluYW5kKQo+ICt7Cj4gKwly ZXR1cm4gc3BpbmFuZC0+b3RwLT5sYXlvdXQubnBhZ2VzOwo+ICt9Cj4gKwo+ICtzdGF0aWMgc2l6 ZV90IHNwaW5hbmRfb3RwX3NpemUoc3RydWN0IHNwaW5hbmRfZGV2aWNlICpzcGluYW5kKQo+ICt7 Cj4gKwlzdHJ1Y3QgbmFuZF9kZXZpY2UgKm5hbmQgPSBzcGluYW5kX3RvX25hbmQoc3BpbmFuZCk7 Cj4gKwlzaXplX3Qgb3RwX3BhZ2VzaXplID0gbmFuZGRldl9wYWdlX3NpemUobmFuZCkgKwo+ICsJ CQkgICAgICBuYW5kZGV2X3Blcl9wYWdlX29vYnNpemUobmFuZCk7Cj4gKwo+ICsJcmV0dXJuIHNw aW5hbmRfb3RwX25wYWdlcyhzcGluYW5kKSAqIG90cF9wYWdlc2l6ZTsKPiArfQo+ICsKPiArc3Rh dGljIGludCBzcGluYW5kX290cF9ydyhzdHJ1Y3Qgc3BpbmFuZF9kZXZpY2UgKnNwaW5hbmQsIGxv ZmZfdCBvZnMsCj4gKwkJCSAgc2l6ZV90IGxlbiwgdTggKmJ1Ziwgc2l6ZV90ICpyZXRsZW4sIGJv b2wgaXNfd3JpdGUpCj4gK3sKPiArCXN0cnVjdCBuYW5kX2RldmljZSAqbmFuZCA9IHNwaW5hbmRf dG9fbmFuZChzcGluYW5kKTsKPiArCXN0cnVjdCBuYW5kX3BhZ2VfaW9fcmVxIHJlcSA9IHsgMCB9 OwoKCQkJCQk9IHt9OyBpcyBlbm91Z2gKCj4gKwl1bnNpZ25lZCBsb25nIGxvbmcgcGFnZTsKPiAr CXNpemVfdCBjb3BpZWQgPSAwOwo+ICsJc2l6ZV90IG90cF9wYWdlc2l6ZSA9IG5hbmRkZXZfcGFn ZV9zaXplKG5hbmQpICsKPiArCQkJICAgICAgbmFuZGRldl9wZXJfcGFnZV9vb2JzaXplKG5hbmQp Owo+ICsJaW50IHJldCA9IDA7Cj4gKwo+ICsJcGFnZSA9IG9mczsKPiArCXJlcS5kYXRhb2ZmcyA9 IGRvX2RpdihwYWdlLCBvdHBfcGFnZXNpemUpOwo+ICsJcmVxLnBvcy5wYWdlID0gcGFnZTsKPiAr CXJlcS50eXBlID0gaXNfd3JpdGUgPyBOQU5EX1BBR0VfV1JJVEUgOiBOQU5EX1BBR0VfUkVBRDsK PiArCXJlcS5tb2RlID0gTVREX09QU19SQVc7Cj4gKwlyZXEuZGF0YWJ1Zi5pbiA9IGJ1ZjsKPiAr Cj4gKwl3aGlsZSAoY29waWVkIDwgbGVuICYmIHJlcS5wb3MucGFnZSA8IHNwaW5hbmRfb3RwX25w YWdlcyhzcGluYW5kKSkgewo+ICsJCXJlcS5kYXRhbGVuID0gbWluX3QodW5zaWduZWQgaW50LAo+ ICsJCQkJICAgIG90cF9wYWdlc2l6ZSAtIHJlcS5kYXRhb2ZmcywKPiArCQkJCSAgICBsZW4gLSBj b3BpZWQpOwo+ICsKPiArCQlpZiAoaXNfd3JpdGUpCj4gKwkJCXJldCA9IHNwaW5hbmRfd3JpdGVf cGFnZShzcGluYW5kLCAmcmVxKTsKPiArCQllbHNlCj4gKwkJCXJldCA9IHNwaW5hbmRfcmVhZF9w YWdlKHNwaW5hbmQsICZyZXEpOwo+ICsKPiArCQlpZiAocmV0IDwgMCkKPiArCQkJYnJlYWs7Cj4g Kwo+ICsJCXJlcS5kYXRhb2ZmcyA9IDA7Cj4gKwkJY29waWVkICs9IHJlcS5kYXRhbGVuOwo+ICsJ CXJlcS5wb3MucGFnZSsrOwo+ICsJfQo+ICsKPiArCSpyZXRsZW4gPSBjb3BpZWQ7Cj4gKwo+ICsJ cmV0dXJuIHJldDsKPiArfQo+ICsKPiArLyoqCj4gKyAqIHNwaW5hbmRfb3RwX3JlYWQoKSAtIFJl YWQgZnJvbSBPVFAgYXJlYQo+ICsgKiBAc3BpbmFuZDogdGhlIHNwaW5hbmQgZGV2aWNlCj4gKyAq IEBvZnM6IHRoZSBvZmZzZXQgdG8gcmVhZAo+ICsgKiBAbGVuOiB0aGUgbnVtYmVyIG9mIGRhdGEg Ynl0ZXMgdG8gcmVhZAo+ICsgKiBAYnVmOiB0aGUgYnVmZmVyIHRvIHN0b3JlIHRoZSByZWFkIGRh dGEKPiArICogQHJldGxlbjogdGhlIHBvaW50ZXIgdG8gdmFyaWFibGUgdG8gc3RvcmUgdGhlIG51 bWJlciBvZiByZWFkIGJ5dGVzCj4gKyAqCj4gKyAqIFJldHVybjogMCBvbiBzdWNjZXNzLCBhbiBl cnJvciBjb2RlIG90aGVyd2lzZS4KPiArICovCj4gK2ludCBzcGluYW5kX290cF9yZWFkKHN0cnVj dCBzcGluYW5kX2RldmljZSAqc3BpbmFuZCwgbG9mZl90IG9mcywgc2l6ZV90IGxlbiwKPiArCQkg ICAgIHU4ICpidWYsIHNpemVfdCAqcmV0bGVuKQo+ICt7Cj4gKwlyZXR1cm4gc3BpbmFuZF9vdHBf cncoc3BpbmFuZCwgb2ZzLCBsZW4sIGJ1ZiwgcmV0bGVuLCBmYWxzZSk7Cj4gK30KPiArCj4gKy8q Kgo+ICsgKiBzcGluYW5kX290cF93cml0ZSgpIC0gV3JpdGUgdG8gT1RQIGFyZWEKPiArICogQHNw aW5hbmQ6ICB0aGUgc3BpbmFuZCBkZXZpY2UKPiArICogQG9mczogdGhlIG9mZnNldCB0byB3cml0 ZSB0bwo+ICsgKiBAbGVuOiB0aGUgbnVtYmVyIG9mIGJ5dGVzIHRvIHdyaXRlCj4gKyAqIEBidWY6 IHRoZSBidWZmZXIgd2l0aCBkYXRhIHRvIHdyaXRlCj4gKyAqIEByZXRsZW46IHRoZSBwb2ludGVy IHRvIHZhcmlhYmxlIHRvIHN0b3JlIHRoZSBudW1iZXIgb2Ygd3JpdHRlbiBieXRlcwo+ICsgKgo+ ICsgKiBSZXR1cm46IDAgb24gc3VjY2VzcywgYW4gZXJyb3IgY29kZSBvdGhlcndpc2UuCj4gKyAq Lwo+ICtpbnQgc3BpbmFuZF9vdHBfd3JpdGUoc3RydWN0IHNwaW5hbmRfZGV2aWNlICpzcGluYW5k LCBsb2ZmX3Qgb2ZzLCBzaXplX3QgbGVuLAo+ICsJCSAgICAgIGNvbnN0IHU4ICpidWYsIHNpemVf dCAqcmV0bGVuKQo+ICt7Cj4gKwlyZXR1cm4gc3BpbmFuZF9vdHBfcncoc3BpbmFuZCwgb2ZzLCBs ZW4sICh1OCAqKWJ1ZiwgcmV0bGVuLCB0cnVlKTsKPiArfQoKVGhlc2Ugc3BpbmFuZF9vdHBfeHh4 KCkgaGVscGVycyBhcmUgbm90IHlldCB1c2VkLCBhbmQgdGh1cyBzaG91bGQgYmUKaW50cm9kdWNl ZCBsYXRlciwgd2hlbiB0aGV5IGFyZSB1c2VmdWwuCgo+ICsKPiArc3RhdGljIGludCBzcGluYW5k X290cF9jaGVja19ib3VuZHMoc3RydWN0IHNwaW5hbmRfZGV2aWNlICpzcGluYW5kLCBsb2ZmX3Qg b2ZzLAo+ICsJCQkJICAgIHNpemVfdCBsZW4pCj4gK3sKPiArCWlmIChvZnMgPCAwIHx8IG9mcyAr IGxlbiA+IHNwaW5hbmRfb3RwX3NpemUoc3BpbmFuZCkpCj4gKwkJcmV0dXJuIC1FSU5WQUw7Cj4g Kwo+ICsJcmV0dXJuIDA7Cj4gK30KPiArCj4gK3N0YXRpYyBpbnQgc3BpbmFuZF9tdGRfb3RwX2lu Zm8oc3RydWN0IG10ZF9pbmZvICptdGQsIHNpemVfdCBsZW4sCj4gKwkJCQlzaXplX3QgKnJldGxl biwgc3RydWN0IG90cF9pbmZvICpidWYpCj4gK3sKPiArCXN0cnVjdCBzcGluYW5kX2RldmljZSAq c3BpbmFuZCA9IG10ZF90b19zcGluYW5kKG10ZCk7Cj4gKwljb25zdCBzdHJ1Y3Qgc3BpbmFuZF9v dHBfb3BzICpvcHMgPSBzcGluYW5kLT5vdHAtPm9wczsKPiArCWludCByZXQ7Cj4gKwo+ICsJbXV0 ZXhfbG9jaygmc3BpbmFuZC0+bG9jayk7Cj4gKwlyZXQgPSBvcHMtPmluZm8oc3BpbmFuZCwgbGVu LCBidWYsIHJldGxlbik7Cj4gKwltdXRleF91bmxvY2soJnNwaW5hbmQtPmxvY2spOwo+ICsKPiAr CXJldHVybiByZXQ7Cj4gK30KPiArCj4gK3N0YXRpYyBpbnQgc3BpbmFuZF9tdGRfb3RwX3J3KHN0 cnVjdCBtdGRfaW5mbyAqbXRkLCBsb2ZmX3Qgb2ZzLCBzaXplX3QgbGVuLAo+ICsJCQkgICAgICBz aXplX3QgKnJldGxlbiwgdTggKmJ1ZiwgYm9vbCBpc193cml0ZSkKPiArewo+ICsJc3RydWN0IHNw aW5hbmRfZGV2aWNlICpzcGluYW5kID0gbXRkX3RvX3NwaW5hbmQobXRkKTsKPiArCWNvbnN0IHN0 cnVjdCBzcGluYW5kX290cF9vcHMgKm9wcyA9IHNwaW5hbmQtPm90cC0+b3BzOwo+ICsJaW50IHJl dDsKPiArCj4gKwlpZiAoIWxlbikKPiArCQlyZXR1cm4gMDsKPiArCj4gKwlyZXQgPSBzcGluYW5k X290cF9jaGVja19ib3VuZHMoc3BpbmFuZCwgb2ZzLCBsZW4pOwo+ICsJaWYgKHJldCkKPiArCQly ZXR1cm4gcmV0Owo+ICsKPiArCW11dGV4X2xvY2soJnNwaW5hbmQtPmxvY2spOwo+ICsKPiArCXJl dCA9IHNwaW5hbmRfdXBkX2NmZyhzcGluYW5kLCBDRkdfT1RQX0VOQUJMRSwgQ0ZHX09UUF9FTkFC TEUpOwo+ICsJaWYgKHJldCkKPiArCQlnb3RvIG91dF91bmxvY2s7Cj4gKwo+ICsJaWYgKGlzX3dy aXRlKQo+ICsJCXJldCA9IG9wcy0+d3JpdGUoc3BpbmFuZCwgb2ZzLCBsZW4sIGJ1ZiwgcmV0bGVu KTsKPiArCWVsc2UKPiArCQlyZXQgPSBvcHMtPnJlYWQoc3BpbmFuZCwgb2ZzLCBsZW4sIGJ1Ziwg cmV0bGVuKTsKPiArCj4gKwlpZiAoc3BpbmFuZF91cGRfY2ZnKHNwaW5hbmQsIENGR19PVFBfRU5B QkxFLCAwKSkgewo+ICsJCXByX3dhcm4oMSwgIkNhbiBub3QgZGlzYWJsZSBPVFAgbW9kZVxuIik7 CgpkZXZfd2Fybj8KCj4gKwkJcmV0ID0gLUVJTzsKPiArCX0KPiArCj4gK291dF91bmxvY2s6Cj4g KwltdXRleF91bmxvY2soJnNwaW5hbmQtPmxvY2spOwo+ICsJcmV0dXJuIHJldDsKPiArfQo+ICsK PiArc3RhdGljIGludCBzcGluYW5kX210ZF9vdHBfcmVhZChzdHJ1Y3QgbXRkX2luZm8gKm10ZCwg bG9mZl90IG9mcywgc2l6ZV90IGxlbiwKPiArCQkJCXNpemVfdCAqcmV0bGVuLCB1OCAqYnVmKQo+ ICt7Cj4gKwlyZXR1cm4gc3BpbmFuZF9tdGRfb3RwX3J3KG10ZCwgb2ZzLCBsZW4sIHJldGxlbiwg YnVmLCBmYWxzZSk7Cj4gK30KPiArCj4gK3N0YXRpYyBpbnQgc3BpbmFuZF9tdGRfb3RwX3dyaXRl KHN0cnVjdCBtdGRfaW5mbyAqbXRkLCBsb2ZmX3Qgb2ZzLCBzaXplX3QgbGVuLAo+ICsJCQkJIHNp emVfdCAqcmV0bGVuLCBjb25zdCB1OCAqYnVmKQo+ICt7Cj4gKwlyZXR1cm4gc3BpbmFuZF9tdGRf b3RwX3J3KG10ZCwgb2ZzLCBsZW4sIHJldGxlbiwgKHU4ICopYnVmLCB0cnVlKTsKPiArfQo+ICsK PiArc3RhdGljIGludCBzcGluYW5kX210ZF9vdHBfZXJhc2Uoc3RydWN0IG10ZF9pbmZvICptdGQs IGxvZmZfdCBvZnMsIHNpemVfdCBsZW4pCj4gK3sKPiArCXN0cnVjdCBzcGluYW5kX2RldmljZSAq c3BpbmFuZCA9IG10ZF90b19zcGluYW5kKG10ZCk7Cj4gKwljb25zdCBzdHJ1Y3Qgc3BpbmFuZF9v dHBfb3BzICpvcHMgPSBzcGluYW5kLT5vdHAtPm9wczsKPiArCWludCByZXQ7Cj4gKwo+ICsJaWYg KCFvcHMtPmVyYXNlKQo+ICsJCXJldHVybiAtRU9QTk9UU1VQUDsKPiArCj4gKwlpZiAoIWxlbikK PiArCQlyZXR1cm4gMDsKPiArCj4gKwlyZXQgPSBzcGluYW5kX290cF9jaGVja19ib3VuZHMoc3Bp bmFuZCwgb2ZzLCBsZW4pOwo+ICsJaWYgKHJldCkKPiArCQlyZXR1cm4gcmV0Owo+ICsKPiArCW11 dGV4X2xvY2soJnNwaW5hbmQtPmxvY2spOwo+ICsJcmV0ID0gb3BzLT5lcmFzZShzcGluYW5kLCBv ZnMsIGxlbik7Cj4gKwltdXRleF91bmxvY2soJnNwaW5hbmQtPmxvY2spOwo+ICsKPiArCXJldHVy biByZXQ7Cj4gK30KPiArCj4gK3N0YXRpYyBpbnQgc3BpbmFuZF9tdGRfb3RwX2xvY2soc3RydWN0 IG10ZF9pbmZvICptdGQsIGxvZmZfdCBvZnMsIHNpemVfdCBsZW4pCj4gK3sKPiArCXN0cnVjdCBz cGluYW5kX2RldmljZSAqc3BpbmFuZCA9IG10ZF90b19zcGluYW5kKG10ZCk7Cj4gKwljb25zdCBz dHJ1Y3Qgc3BpbmFuZF9vdHBfb3BzICpvcHMgPSBzcGluYW5kLT5vdHAtPm9wczsKPiArCWludCBy ZXQ7Cj4gKwo+ICsJaWYgKCFvcHMtPmxvY2spCj4gKwkJcmV0dXJuIC1FT1BOT1RTVVBQOwo+ICsK PiArCWlmICghbGVuKQo+ICsJCXJldHVybiAwOwo+ICsKPiArCXJldCA9IHNwaW5hbmRfb3RwX2No ZWNrX2JvdW5kcyhzcGluYW5kLCBvZnMsIGxlbik7Cj4gKwlpZiAocmV0KQo+ICsJCXJldHVybiBy ZXQ7Cj4gKwo+ICsJbXV0ZXhfbG9jaygmc3BpbmFuZC0+bG9jayk7Cj4gKwlyZXQgPSBvcHMtPmxv Y2soc3BpbmFuZCwgb2ZzLCBsZW4pOwo+ICsJbXV0ZXhfdW5sb2NrKCZzcGluYW5kLT5sb2NrKTsK PiArCj4gKwlyZXR1cm4gcmV0Owo+ICt9Cj4gKwo+ICsvKioKPiArICogc3BpbmFuZF9zZXRfbXRk X290cF9vcHMoKSAtIFNldCB1cCBPVFAgbWV0aG9kcwo+ICsgKiBAc3BpbmFuZDogdGhlIHNwaW5h bmQgZGV2aWNlCj4gKyAqCj4gKyAqIFNldCB1cCBPVFAgbWV0aG9kcy4KPiArICovCj4gK3ZvaWQg c3BpbmFuZF9zZXRfbXRkX290cF9vcHMoc3RydWN0IHNwaW5hbmRfZGV2aWNlICpzcGluYW5kKQo+ ICt7Cj4gKwlzdHJ1Y3QgbXRkX2luZm8gKm10ZCA9IHNwaW5hbmRfdG9fbXRkKHNwaW5hbmQpOwo+ ICsKPiArCWlmICghc3BpbmFuZC0+b3RwLT5vcHMpCgpDb3VsZCB3ZSB1c2Ugc29tZXRoaW5nIGVs c2UgYXMgY2hlY2s/IEl0IGZlZWxzIG9kZCB0byBjaGVjayBmb3Igb3RwIG9wcwphbmQgdGhlbiBq dXN0IGlnbm9yZSB0aGUgZmFjdCB0aGF0IHRoZXkgYXJlIGhlcmUuIE1heWJlIGNoZWNrIG5wYWdl cyBvcgpvdHBfc2l6ZSgpID8KCj4gKwkJcmV0dXJuOwo+ICsKPiArCW10ZC0+X2dldF91c2VyX3By b3RfaW5mbyA9IHNwaW5hbmRfbXRkX290cF9pbmZvOwo+ICsJbXRkLT5fcmVhZF91c2VyX3Byb3Rf cmVnID0gc3BpbmFuZF9tdGRfb3RwX3JlYWQ7Cj4gKwltdGQtPl93cml0ZV91c2VyX3Byb3RfcmVn ID0gc3BpbmFuZF9tdGRfb3RwX3dyaXRlOwo+ICsJbXRkLT5fbG9ja191c2VyX3Byb3RfcmVnID0g c3BpbmFuZF9tdGRfb3RwX2xvY2s7Cj4gKwltdGQtPl9lcmFzZV91c2VyX3Byb3RfcmVnID0gc3Bp bmFuZF9tdGRfb3RwX2VyYXNlOwo+ICt9Cj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvbGludXgvbXRk L3NwaW5hbmQuaCBiL2luY2x1ZGUvbGludXgvbXRkL3NwaW5hbmQuaAo+IGluZGV4IDU1NTg0NjUx N2ZhZjYuLjgwOTlmMzVmMGUwNTEgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVkZS9saW51eC9tdGQvc3Bp bmFuZC5oCj4gKysrIGIvaW5jbHVkZS9saW51eC9tdGQvc3BpbmFuZC5oCj4gQEAgLTMyMiw2ICsz MjIsNDMgQEAgc3RydWN0IHNwaW5hbmRfb25kaWVfZWNjX2NvbmYgewo+ICAJdTggc3RhdHVzOwo+ ICB9OwoKVGhhbmtzLApNaXF1w6hsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KTGludXggTVREIGRpc2N1c3Npb24gbWFpbGluZyBsaXN0Cmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtbXRkLwo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31D7319D090 for ; Tue, 1 Oct 2024 09:12:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727773958; cv=none; b=rMTD6NNPr8Bq/uRFfNq4CVTclVVFAAbjOMZU/aN2QEiXrnxty9YEKAxypbZbNm+6FU0oo+Hlg0OXtchS3lr7Bbjkg9l35DvSFuBD/CrU8lMmY+CKMZjyWRYRjIID+iB27xffMLLPzIeRr0fOLKQOylb++fnqOwiXtUSl1kFvFgo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727773958; c=relaxed/simple; bh=1B6wHs3i1LAve3450/x0qkEQTXwCiB4C7r3gEz/9hh8=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=GzdU3rFq28zI7XId6fBOQOKg6bEI3aYLkB74nhXSJvEFMZwAFox0wI3Vk4u2Ojrvg/l+Ebcv819O1EYkhCFthVM3bI7leWw1+Mg3FeH8HQhJD5zMXAEWnt14mG2gp2zWie7b8e4jHaTesCMQlro+Y0j1vxt9I5a6Ie6tqeH9FL8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=igZKjK1K; arc=none smtp.client-ip=217.70.183.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="igZKjK1K" Received: by mail.gandi.net (Postfix) with ESMTPSA id 3ECFE6000D; Tue, 1 Oct 2024 09:12:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1727773950; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L8e0/MF0EAHqslKXTtTfPt+/H8jOhZk2+bky0/VQZJg=; b=igZKjK1KY646cAPTO0FysAwddUJvKu3bVXfv9xU3id6yEp21t72YdRsB8QQYSLAuuQ549O DrAdgdhlcY5w1DY+zs0ia9MhSivk5sWnF1bBn43Ca8VhFpT/IKhhJ56puImFGo77KaYuJF 3BzboTz6hQi8DxwuFxSvCbpUk8c8Tl7VdNQHaAn6Zy5f8GYJJYsGppDMiHm5TLOz0/t+Gr Ssz+GGlUu+2AP2phfOapXW0mDV1nxppT+8MvHjtpWf0bzNsxlQJvfL+EqMFrklWEnzkU2a OV4LHtFhm7WZ/zkE8BNWtOvd6mrFR23Ak+F58VaoCfcfEqLX9KMbG+DXAowWww== Date: Tue, 1 Oct 2024 11:12:25 +0200 From: Miquel Raynal To: Martin Kurbanov Cc: Richard Weinberger , Vignesh Raghavendra , Mika Westerberg , Michael Walle , "Mark Brown" , Chia-Lin Kao , "Md Sadre Alam" , Ezra Buehler , Sridharan S N , Frieder Schrempf , Alexey Romanov , , , Subject: Re: [PATCH v2 2/5] mtd: spinand: add OTP support Message-ID: <20241001111225.36cb9701@xps-13> In-Reply-To: <20240827174920.316756-3-mmkurbanov@salutedevices.com> References: <20240827174920.316756-1-mmkurbanov@salutedevices.com> <20240827174920.316756-3-mmkurbanov@salutedevices.com> Organization: Bootlin X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: miquel.raynal@bootlin.com Hi Martin, mmkurbanov@salutedevices.com wrote on Tue, 27 Aug 2024 20:49:00 +0300: > The MTD subsystem already supports accessing two OTP areas: user and > factory. User areas can be written by the user. This patch only adds > support for the user areas. >=20 > In this patch the OTP_INFO macro is provided to add parameters to > spinand_info. > To implement OTP operations, the client (flash driver) is provided with > 5 callbacks: .read(), .write(), .info(), .lock(), .erase(). Overall this looks good, I have minor changes to request. I'm not yet done down to the last patch, but I think the implementation is neat. > Signed-off-by: Martin Kurbanov > --- > drivers/mtd/nand/spi/Makefile | 3 +- > drivers/mtd/nand/spi/core.c | 3 + > drivers/mtd/nand/spi/otp.c | 232 ++++++++++++++++++++++++++++++++++ > include/linux/mtd/spinand.h | 56 ++++++++ > 4 files changed, 293 insertions(+), 1 deletion(-) > create mode 100644 drivers/mtd/nand/spi/otp.c >=20 > diff --git a/drivers/mtd/nand/spi/Makefile b/drivers/mtd/nand/spi/Makefile > index 19cc77288ebbc..60d2e830ffc6b 100644 > --- a/drivers/mtd/nand/spi/Makefile > +++ b/drivers/mtd/nand/spi/Makefile > @@ -1,4 +1,5 @@ > # SPDX-License-Identifier: GPL-2.0 > -spinand-objs :=3D core.o alliancememory.o ato.o esmt.o foresee.o gigadev= ice.o macronix.o > +spinand-objs :=3D core.o otp.o > +spinand-objs +=3D alliancememory.o ato.o esmt.o foresee.o gigadevice.o m= acronix.o > spinand-objs +=3D micron.o paragon.o toshiba.o winbond.o xtx.o > obj-$(CONFIG_MTD_SPI_NAND) +=3D spinand.o > diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c > index 807c24b0c7c4f..2cb825edd49d0 100644 > --- a/drivers/mtd/nand/spi/core.c > +++ b/drivers/mtd/nand/spi/core.c > @@ -1111,6 +1111,7 @@ int spinand_match_and_init(struct spinand_device *s= pinand, > spinand->flags =3D table[i].flags; > spinand->id.len =3D 1 + table[i].devid.len; > spinand->select_target =3D table[i].select_target; > + spinand->otp =3D &table[i].otp; > =20 > op =3D spinand_select_op_variant(spinand, > info->op_variants.read_cache); > @@ -1292,6 +1293,8 @@ static int spinand_init(struct spinand_device *spin= and) > mtd->_max_bad_blocks =3D nanddev_mtd_max_bad_blocks; > mtd->_resume =3D spinand_mtd_resume; > =20 > + spinand_set_mtd_otp_ops(spinand); > + > if (nand->ecc.engine) { > ret =3D mtd_ooblayout_count_freebytes(mtd); > if (ret < 0) > diff --git a/drivers/mtd/nand/spi/otp.c b/drivers/mtd/nand/spi/otp.c > new file mode 100644 > index 0000000000000..d459f811f9c04 > --- /dev/null > +++ b/drivers/mtd/nand/spi/otp.c > @@ -0,0 +1,232 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (c) 2024, SaluteDevices. All Rights Reserved. > + * > + * Author: Martin Kurbanov > + */ > + > +#include > +#include > + > +static unsigned int spinand_otp_npages(const struct spinand_device *spin= and) > +{ > + return spinand->otp->layout.npages; > +} > + > +static size_t spinand_otp_size(struct spinand_device *spinand) > +{ > + struct nand_device *nand =3D spinand_to_nand(spinand); > + size_t otp_pagesize =3D nanddev_page_size(nand) + > + nanddev_per_page_oobsize(nand); > + > + return spinand_otp_npages(spinand) * otp_pagesize; > +} > + > +static int spinand_otp_rw(struct spinand_device *spinand, loff_t ofs, > + size_t len, u8 *buf, size_t *retlen, bool is_write) > +{ > + struct nand_device *nand =3D spinand_to_nand(spinand); > + struct nand_page_io_req req =3D { 0 }; =3D {}; is enough > + unsigned long long page; > + size_t copied =3D 0; > + size_t otp_pagesize =3D nanddev_page_size(nand) + > + nanddev_per_page_oobsize(nand); > + int ret =3D 0; > + > + page =3D ofs; > + req.dataoffs =3D do_div(page, otp_pagesize); > + req.pos.page =3D page; > + req.type =3D is_write ? NAND_PAGE_WRITE : NAND_PAGE_READ; > + req.mode =3D MTD_OPS_RAW; > + req.databuf.in =3D buf; > + > + while (copied < len && req.pos.page < spinand_otp_npages(spinand)) { > + req.datalen =3D min_t(unsigned int, > + otp_pagesize - req.dataoffs, > + len - copied); > + > + if (is_write) > + ret =3D spinand_write_page(spinand, &req); > + else > + ret =3D spinand_read_page(spinand, &req); > + > + if (ret < 0) > + break; > + > + req.dataoffs =3D 0; > + copied +=3D req.datalen; > + req.pos.page++; > + } > + > + *retlen =3D copied; > + > + return ret; > +} > + > +/** > + * spinand_otp_read() - Read from OTP area > + * @spinand: the spinand device > + * @ofs: the offset to read > + * @len: the number of data bytes to read > + * @buf: the buffer to store the read data > + * @retlen: the pointer to variable to store the number of read bytes > + * > + * Return: 0 on success, an error code otherwise. > + */ > +int spinand_otp_read(struct spinand_device *spinand, loff_t ofs, size_t = len, > + u8 *buf, size_t *retlen) > +{ > + return spinand_otp_rw(spinand, ofs, len, buf, retlen, false); > +} > + > +/** > + * spinand_otp_write() - Write to OTP area > + * @spinand: the spinand device > + * @ofs: the offset to write to > + * @len: the number of bytes to write > + * @buf: the buffer with data to write > + * @retlen: the pointer to variable to store the number of written bytes > + * > + * Return: 0 on success, an error code otherwise. > + */ > +int spinand_otp_write(struct spinand_device *spinand, loff_t ofs, size_t= len, > + const u8 *buf, size_t *retlen) > +{ > + return spinand_otp_rw(spinand, ofs, len, (u8 *)buf, retlen, true); > +} These spinand_otp_xxx() helpers are not yet used, and thus should be introduced later, when they are useful. > + > +static int spinand_otp_check_bounds(struct spinand_device *spinand, loff= _t ofs, > + size_t len) > +{ > + if (ofs < 0 || ofs + len > spinand_otp_size(spinand)) > + return -EINVAL; > + > + return 0; > +} > + > +static int spinand_mtd_otp_info(struct mtd_info *mtd, size_t len, > + size_t *retlen, struct otp_info *buf) > +{ > + struct spinand_device *spinand =3D mtd_to_spinand(mtd); > + const struct spinand_otp_ops *ops =3D spinand->otp->ops; > + int ret; > + > + mutex_lock(&spinand->lock); > + ret =3D ops->info(spinand, len, buf, retlen); > + mutex_unlock(&spinand->lock); > + > + return ret; > +} > + > +static int spinand_mtd_otp_rw(struct mtd_info *mtd, loff_t ofs, size_t l= en, > + size_t *retlen, u8 *buf, bool is_write) > +{ > + struct spinand_device *spinand =3D mtd_to_spinand(mtd); > + const struct spinand_otp_ops *ops =3D spinand->otp->ops; > + int ret; > + > + if (!len) > + return 0; > + > + ret =3D spinand_otp_check_bounds(spinand, ofs, len); > + if (ret) > + return ret; > + > + mutex_lock(&spinand->lock); > + > + ret =3D spinand_upd_cfg(spinand, CFG_OTP_ENABLE, CFG_OTP_ENABLE); > + if (ret) > + goto out_unlock; > + > + if (is_write) > + ret =3D ops->write(spinand, ofs, len, buf, retlen); > + else > + ret =3D ops->read(spinand, ofs, len, buf, retlen); > + > + if (spinand_upd_cfg(spinand, CFG_OTP_ENABLE, 0)) { > + pr_warn(1, "Can not disable OTP mode\n"); dev_warn? > + ret =3D -EIO; > + } > + > +out_unlock: > + mutex_unlock(&spinand->lock); > + return ret; > +} > + > +static int spinand_mtd_otp_read(struct mtd_info *mtd, loff_t ofs, size_t= len, > + size_t *retlen, u8 *buf) > +{ > + return spinand_mtd_otp_rw(mtd, ofs, len, retlen, buf, false); > +} > + > +static int spinand_mtd_otp_write(struct mtd_info *mtd, loff_t ofs, size_= t len, > + size_t *retlen, const u8 *buf) > +{ > + return spinand_mtd_otp_rw(mtd, ofs, len, retlen, (u8 *)buf, true); > +} > + > +static int spinand_mtd_otp_erase(struct mtd_info *mtd, loff_t ofs, size_= t len) > +{ > + struct spinand_device *spinand =3D mtd_to_spinand(mtd); > + const struct spinand_otp_ops *ops =3D spinand->otp->ops; > + int ret; > + > + if (!ops->erase) > + return -EOPNOTSUPP; > + > + if (!len) > + return 0; > + > + ret =3D spinand_otp_check_bounds(spinand, ofs, len); > + if (ret) > + return ret; > + > + mutex_lock(&spinand->lock); > + ret =3D ops->erase(spinand, ofs, len); > + mutex_unlock(&spinand->lock); > + > + return ret; > +} > + > +static int spinand_mtd_otp_lock(struct mtd_info *mtd, loff_t ofs, size_t= len) > +{ > + struct spinand_device *spinand =3D mtd_to_spinand(mtd); > + const struct spinand_otp_ops *ops =3D spinand->otp->ops; > + int ret; > + > + if (!ops->lock) > + return -EOPNOTSUPP; > + > + if (!len) > + return 0; > + > + ret =3D spinand_otp_check_bounds(spinand, ofs, len); > + if (ret) > + return ret; > + > + mutex_lock(&spinand->lock); > + ret =3D ops->lock(spinand, ofs, len); > + mutex_unlock(&spinand->lock); > + > + return ret; > +} > + > +/** > + * spinand_set_mtd_otp_ops() - Set up OTP methods > + * @spinand: the spinand device > + * > + * Set up OTP methods. > + */ > +void spinand_set_mtd_otp_ops(struct spinand_device *spinand) > +{ > + struct mtd_info *mtd =3D spinand_to_mtd(spinand); > + > + if (!spinand->otp->ops) Could we use something else as check? It feels odd to check for otp ops and then just ignore the fact that they are here. Maybe check npages or otp_size() ? > + return; > + > + mtd->_get_user_prot_info =3D spinand_mtd_otp_info; > + mtd->_read_user_prot_reg =3D spinand_mtd_otp_read; > + mtd->_write_user_prot_reg =3D spinand_mtd_otp_write; > + mtd->_lock_user_prot_reg =3D spinand_mtd_otp_lock; > + mtd->_erase_user_prot_reg =3D spinand_mtd_otp_erase; > +} > diff --git a/include/linux/mtd/spinand.h b/include/linux/mtd/spinand.h > index 555846517faf6..8099f35f0e051 100644 > --- a/include/linux/mtd/spinand.h > +++ b/include/linux/mtd/spinand.h > @@ -322,6 +322,43 @@ struct spinand_ondie_ecc_conf { > u8 status; > }; Thanks, Miqu=C3=A8l