All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Otavio Salvador <otavio@ossystems.com.br>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [freescale-fslc:6.6-2.0.x-imx 1032/16788] drivers/mfd/maxim_serdes.c:63:5: warning: no previous prototype for 'maxim_serdes_chain_register_remote'
Date: Tue, 1 Oct 2024 16:24:40 +0800	[thread overview]
Message-ID: <202410011623.4FcsrjOb-lkp@intel.com> (raw)

tree:   https://github.com/Freescale/linux-fslc 6.6-2.0.x-imx
head:   ac32ba5fe66266329914d2020570364afe217bec
commit: 56ce69ebbbda4ee59d85f91435eba92cc671e6f3 [1032/16788] LF-10269-5: mfd: add Maxim SerDes link manager layer
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20241001/202410011623.4FcsrjOb-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241001/202410011623.4FcsrjOb-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410011623.4FcsrjOb-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/mfd/maxim_serdes.c:63:5: warning: no previous prototype for 'maxim_serdes_chain_register_remote' [-Wmissing-prototypes]
      63 | int maxim_serdes_chain_register_remote(struct device *dev, int link, void (*cb)(void *), void *data)
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/mfd/maxim_serdes.c:109:5: warning: no previous prototype for 'maxim_serdes_chain_register_local' [-Wmissing-prototypes]
     109 | int maxim_serdes_chain_register_local(struct device *dev, int remote_links_used,
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
--
>> drivers/mfd/max96752-core.c:145:5: warning: no previous prototype for 'max96752_set_link_params' [-Wmissing-prototypes]
     145 | int max96752_set_link_params(struct max96752 *max96752)
         |     ^~~~~~~~~~~~~~~~~~~~~~~~


vim +/maxim_serdes_chain_register_remote +63 drivers/mfd/maxim_serdes.c

    62	
  > 63	int maxim_serdes_chain_register_remote(struct device *dev, int link, void (*cb)(void *), void *data)
    64	{
    65		struct maxim_serdes_chain *serdes_chain;
    66		struct device_node *dn;
    67		int i;
    68	
    69		dn = of_node_get(dev->of_node);
    70	
    71		while (dn) {
    72			serdes_chain = maxim_serdes_get_chain(dn);
    73			if (serdes_chain) {
    74				of_node_put(dn);
    75				break;
    76			}
    77	
    78			dn = of_get_next_parent(dn);
    79		}
    80	
    81		if (!dn) {
    82			dev_err(dev, "could not find the local device of_node in the chains list\n");
    83			return -ENODEV;
    84		}
    85	
    86		if (link > serdes_chain->remotes_no - 1) {
    87			dev_err(dev, "invalid remote link id provided\n");
    88			return -EINVAL;
    89		}
    90	
    91		serdes_chain->remote_late_setup[link].cb = cb;
    92		serdes_chain->remote_late_setup[link].data = data;
    93	
    94		/* let's find out if all remotes registered their late setup routines */
    95		for (i = 0; i < serdes_chain->remotes_no; i++) {
    96			if (!serdes_chain->remote_late_setup[i].cb)
    97				return 0;
    98		}
    99	
   100		/* we're good to go, let's queue the late setup work */
   101		INIT_WORK(&serdes_chain->late_setup_work, maxim_serdes_worker);
   102	
   103		queue_work(system_unbound_wq, &serdes_chain->late_setup_work);
   104	
   105		return 0;
   106	};
   107	EXPORT_SYMBOL(maxim_serdes_chain_register_remote);
   108	
 > 109	int maxim_serdes_chain_register_local(struct device *dev, int remote_links_used,
   110					      void (*cb)(void *), void *data)
   111	{
   112		struct maxim_serdes_chain *chain;
   113		int extra_space;
   114	
   115		extra_space = remote_links_used * sizeof(struct maxim_serdes_late_setup);
   116		chain = devm_kzalloc(dev, sizeof(*chain) + extra_space, GFP_KERNEL);
   117		if (!chain)
   118			return -ENOMEM;
   119	
   120		chain->local_dev_node = dev->of_node;
   121		chain->local_late_setup.cb = cb;
   122		chain->local_late_setup.data = data;
   123		chain->remotes_no = remote_links_used;
   124	
   125		list_add_tail(&chain->entry, &maxim_serdes_chains_list);
   126	
   127		return 0;
   128	}
   129	EXPORT_SYMBOL(maxim_serdes_chain_register_local);
   130	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2024-10-01  8:25 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202410011623.4FcsrjOb-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=otavio@ossystems.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.