From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 169E2CEACFB for ; Tue, 1 Oct 2024 19:19:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ync2YqL83Ti1/03r6F1+z3iqK/jNEsxjllkEFbrF83Q=; b=T9GJlBxShFMmvLLqJ/wEz+bAUr r8xfDp6uTO56wXqCHV/J1EsZ0Qempt2cR/Jslt2McDAV+Aogoz+YFjyAHKAMEEwDVbHNQHC59OYpt Nq9O4ugWts6ad5MRwpR1r7ECoCed7pQ2ddcwQO94WLXwXEVWZpAvDCJ8MDMjLTMKi0CsDdszecTN7 0nD+Z+lhsAtHM4zzc8ot3c11+o8Uw2rD1RfgRJHAxHVMPtLNptHRrnMM0IUwE0NEDI38kmhT7aVov ssYxDR+4gWoytqGmTvlwWllWJBgFgUvGQiBOcCeUJjsMxXCzvemtXva4igkc2/A7SjU3c22fvImCP LxEJqHtA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sviP3-00000003sCm-2Dup; Tue, 01 Oct 2024 19:19:21 +0000 Received: from mail-qk1-x72e.google.com ([2607:f8b0:4864:20::72e]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sviNn-00000003ruX-2xrt for linux-arm-kernel@lists.infradead.org; Tue, 01 Oct 2024 19:18:05 +0000 Received: by mail-qk1-x72e.google.com with SMTP id af79cd13be357-7a9aec89347so382501285a.0 for ; Tue, 01 Oct 2024 12:18:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1727810282; x=1728415082; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ync2YqL83Ti1/03r6F1+z3iqK/jNEsxjllkEFbrF83Q=; b=SnzAPakyTONog//ckGznRydt87BaMhVYcKEOnjSpuDGOuiBJ4fvcZxvJoTHVLM2yjt xs9uMj0HGTn3O+NrDuhCHklcH5e1yb+uIe5lSptUCEAllBJ9pZT8x5AGR31ZRNez4Fn4 9yNt7pDtJe5P2RYS53lkJeeRMDfUkO5tJoqnJdnU7Nu21Pkb5IkUpLtPEx+Gn5IHUrCV h7p7ZAUMCOkIfKuYdCpQJeIURxZ2M6OYfRAkbKvP9MgY8ssbs22VqWnjkxiMjrUrecYD Q9grMrUtRhFtptZLrFdxE1+VmntlW2J+M/1e0k+qE9Y4yDIpsNumvIUr+1oPqyd1dRvy h5bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727810282; x=1728415082; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ync2YqL83Ti1/03r6F1+z3iqK/jNEsxjllkEFbrF83Q=; b=G3XiheOyTJLY0QkJst+EUqaKMSuXIpnSKqdRUt+s0WL3vJdkdLwbosm+/kPv3+k5Rh PvcTL9gVwin2xfZkF22osLXTaeoGaLO092jUtmQXGrPiQyKDuFPnO953qD1GjGctqhF5 inPBS4oVvHvw+VDFrEQ7cnAkHSawwtS3zAZLlAvHWj25ZzsTEtISMNw6iNTyh3G8kI0e /VU6DAVUtsVCdGRRVy8u/RQ+stfboVOmgFVvWghUkdzgj6mtxSL33K3ewLIZpFJEDhse teFafc9btdA4hIOGIyJAmY98J6wmAAIzEgvGqmZTNiImnYWnNUODPNwls+6fEBfFD1PP VUvg== X-Forwarded-Encrypted: i=1; AJvYcCUL9nudBfHmG7Xbrk46X2FAIQB8ctRJpPALbngCRMl7BUGz+YItFBPN12QgISlxeyMHpvVgCINOFyOnaSA0uKUu@lists.infradead.org X-Gm-Message-State: AOJu0Yz+2jJc/wTpaJdw+VIXkc15QEzCtQvK2XgWHU2M+OrDKxI081Gz QbQ2bcAIOd1odPgfQqbnVstCt+fd3LheJDyA3/7Fl0XbdXAYG/r+3sq0njqeNjQ= X-Google-Smtp-Source: AGHT+IHtXFnT4ve7jeSEvuD1KpPbHcIiORqAONIeEOBb0g51+u1DkuBd8/Rf+xnqrY7qMBCFoRJm+g== X-Received: by 2002:a05:620a:3711:b0:7a9:dcbc:f82b with SMTP id af79cd13be357-7ae62738fcemr88826585a.54.1727810281578; Tue, 01 Oct 2024 12:18:01 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-128-5.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.128.5]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7ae377db4c5sm528333085a.52.2024.10.01.12.18.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Oct 2024 12:18:00 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1sviNk-0080vT-0C; Tue, 01 Oct 2024 16:18:00 -0300 Date: Tue, 1 Oct 2024 16:18:00 -0300 From: Jason Gunthorpe To: Yang Shi Cc: Nicolin Chen , will@kernel.org, robin.murphy@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iommu/arm-smmu-v3: Fix L1 stream table index calculation for AmpereOne Message-ID: <20241001191800.GA1369530@ziepe.ca> References: <20241001180346.1485194-1-yang@os.amperecomputing.com> <45b97496-29a2-4111-ba38-3c8bcf9f8b4d@os.amperecomputing.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <45b97496-29a2-4111-ba38-3c8bcf9f8b4d@os.amperecomputing.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241001_121803_866264_E30A1638 X-CRM114-Status: GOOD ( 13.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 01, 2024 at 12:09:03PM -0700, Yang Shi wrote: > > Also, there are other places doing "1 << smmu->sid_bits", e.g. > > arm_smmu_init_strtab_linear(). > > The disassembly shows it uses "sbfiz x21, x20, 6, 32" instead of lsl. 1UL > should be used if we want to take extra caution and don't prefer rely on > compiler. Still, we should be fixing them all if sid_bits == 32, all those shifts should be throwing a UBSAN error. It would be crazy to have a 32 bit linear table but I guess it is allowed? Jason