From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4BBDFCF31B7 for ; Wed, 2 Oct 2024 12:51:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=q2M1UncY/ShMFeFvU9PA2GVWUuuVAbr/OxsWC3h12k0=; b=guPbRKxBUILPTpxowEFI5Gslgp sSuxXCy7uZh1jNg2TcmhVKBkBVT3AHLGhUE7jd5PEiX6OxxEhKo/Xe2UI8eXpBnIlQ2qSGgPyjN8q 5nMp735NLTQx1tVRKeZ0zVPY07Wp6HF2SNNGZtphz3qU8ns9zqBo1XyUPWjMWP4kZUQHQ8J+L+Go5 U8JGY99F1gX/jJpNbvQHpbCBnEIrGzrEvP6RecyEiLlLF4i5p2tRAT4SNUEVk1y5EfaH5HMVGCEve npCZpFJBJ0X2SEc6lqnA8lJ5fZFcm6do2X5fExfNG3rw8T3ZTiu0Q8xMpiYsHfsPlGJ7m8IFDea4M HGXhHpkA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1svypI-00000005z1X-3vH6; Wed, 02 Oct 2024 12:51:33 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1svyll-00000005yAk-2qde for linux-arm-kernel@lists.infradead.org; Wed, 02 Oct 2024 12:47:54 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 6B68D5C075E; Wed, 2 Oct 2024 12:47:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9A44FC4CEC5; Wed, 2 Oct 2024 12:47:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727873272; bh=q2M1UncY/ShMFeFvU9PA2GVWUuuVAbr/OxsWC3h12k0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HunxoXgSEFtPrezT/RdHFbl4G/1QU25Ngvu+mCicdZhdqIFy77PsIj9XHvXWMffZm DdoNdZUUvyklPXQ+uQPSJblQxixt9XjZjH6OTWLjzcSL694/vIbX4WaFRrGQob3DWq Qv0d4KCQwCY6WouTZE4mVaZCnNpBxgIthOTutswlNVFv+oO1JlNzRT2iPNSlQwDfwA 95YJgVgFv0krE7AlanUn13PPqKKOWbpcOQN4FhMiAuU/lHBVFpBLlStnR1AAl9Ulr6 cWMdKUDAtTtwbp+4srag8eG6bjeltwgKJK2buhaWnz86BgSrZylbYzI/Upu7/3UPIB /QnJo1baz2hrA== Date: Wed, 2 Oct 2024 05:47:50 -0700 From: Jakub Kicinski To: Daniel Machon Cc: "David S. Miller" , Eric Dumazet , Paolo Abeni , Lars Povlsen , "Steen Hegelund" , , , , Richard Cochran , , , , , , , , Subject: Re: [PATCH net-next 06/15] net: sparx5: add constants to match data Message-ID: <20241002054750.043ac565@kernel.org> In-Reply-To: <20241001-b4-sparx5-lan969x-switch-driver-v1-6-8c6896fdce66@microchip.com> References: <20241001-b4-sparx5-lan969x-switch-driver-v1-0-8c6896fdce66@microchip.com> <20241001-b4-sparx5-lan969x-switch-driver-v1-6-8c6896fdce66@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241002_054753_822504_47D1ED02 X-CRM114-Status: UNSURE ( 7.63 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 1 Oct 2024 15:50:36 +0200 Daniel Machon wrote: > +#define SPX5_CONST(const) sparx5->data->consts->const This is way too ugly too live. Please type the code out, there's no prize for having low LoC count.