From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C9452CF3198 for ; Wed, 2 Oct 2024 06:56:53 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 2BC2E851; Wed, 2 Oct 2024 08:56:41 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 2BC2E851 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1727852211; bh=1x8FsTYKTElgsro6hjXvj/EoIu+83Ck3wv1piHuIC9E=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=JG9BEph8lsCs7CDxoL4uz+ILmg0uGomAxePKl2J1LCKbfvWc+HpvpihJP4d01wGzP IG8yn7u1xit16RDnuy6ln+Mi/NoMWcWTWWABdv8DFrKnB8iX5GBXz4NPzn9e3amIwE iixof8sy7ALczfaJSH1umndJCZci9wW+pt72FhPA= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 92FFEF8059F; Wed, 2 Oct 2024 08:56:21 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id D858DF805B5; Wed, 2 Oct 2024 08:56:20 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 131D2F80517; Wed, 2 Oct 2024 08:56:12 +0200 (CEST) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id CB568F8001E for ; Wed, 2 Oct 2024 08:56:07 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz CB568F8001E Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=OPooQOpK Received: by mail.gandi.net (Postfix) with ESMTPSA id 5141120002; Wed, 2 Oct 2024 06:56:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1727852167; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EHrsnih06kMmn0kAxCYeMqMQc7boKhbn730umSdHFlY=; b=OPooQOpKYrL9KBqvrSgkCbk52UkG1+O8zOtQ+3tYXfY9H3R+7i69jE+OGeWcHDYAycOPwS JcPV1gSkC3Tj4n85gWBX4Pj8aYCq0+oNEkyggb9IQydRDvf8mXuI7UeGuyxyoLFWGOG77w iAIZV0lx45aAabcYA1mkuzXUS2XUdQ+T0m1NfM888QPBVJ3LJfFvNbrF6CUYKqa3nLofmZ fufOhNgx9/5vq7TqH/YaOmraHM6NYuoG6p1qu+VXkSKf1TYOiIEiVdKuqpujKDnE5DZy+z OMZBgRzHzA3LZv3NFuG+O7DD5MDy8dOCE++H+GrBIUIGT4wFnyrjkuH4lbrb3g== Date: Wed, 2 Oct 2024 08:56:04 +0200 From: Miquel Raynal To: Krzysztof Kozlowski Cc: Peter Ujfalusi , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jayesh Choudhary , alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, devicetree@vger.kernel.org, Thomas Petazzoni Subject: Re: [PATCH] ASoC: dt-bindings: davinci-mcasp: Fix interrupts property Message-ID: <20241002085604.277d5006@xps-13> In-Reply-To: <7f5wtbnn32l6l76z2yjjfponrysr55yi7hgfmtdegilg7dcc4h@pkupvwap4up4> References: <20241001204749.390054-1-miquel.raynal@bootlin.com> <7f5wtbnn32l6l76z2yjjfponrysr55yi7hgfmtdegilg7dcc4h@pkupvwap4up4> Organization: Bootlin X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: miquel.raynal@bootlin.com Message-ID-Hash: JWNRDZXY5ZIDCU7YESDUNRYLOHR7LUGV X-Message-ID-Hash: JWNRDZXY5ZIDCU7YESDUNRYLOHR7LUGV X-MailFrom: miquel.raynal@bootlin.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Hi Krzysztof, krzk@kernel.org wrote on Wed, 2 Oct 2024 08:34:44 +0200: > On Tue, Oct 01, 2024 at 10:47:49PM +0200, Miquel Raynal wrote: > > My understanding of the interrupts property is that it can either be: > > 1/ - TX > > 2/ - TX > > - RX > > 3/ - Common/combined. > >=20 > > There are very little chances that either: > > - TX > > - Common/combined > > or even > > - TX > > - RX > > - Common/combined > > could be a thing. > >=20 > > Looking at the interrupt-names definition (which uses oneOf instead of > > anyOf), it makes indeed little sense to use anyOf in the interrupts > > definition. I believe this is just a mistake, hence let's fix it. > >=20 > > Fixes: 8be90641a0bb ("ASoC: dt-bindings: davinci-mcasp: convert McASP b= indings to yaml schema") > > Signed-off-by: Miquel Raynal > > --- > > --- > > .../devicetree/bindings/sound/davinci-mcasp-audio.yaml | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git a/Documentation/devicetree/bindings/sound/davinci-mcasp-audi= o.yaml b/Documentation/devicetree/bindings/sound/davinci-mcasp-audio.yaml > > index 7735e08d35ba..ab3206ffa4af 100644 > > --- a/Documentation/devicetree/bindings/sound/davinci-mcasp-audio.yaml > > +++ b/Documentation/devicetree/bindings/sound/davinci-mcasp-audio.yaml > > @@ -102,7 +102,7 @@ properties: > > default: 2 > > =20 > > interrupts: > > - anyOf: > > + oneOf: =20 >=20 >=20 > You need to change interrupt-names as well. interrupt-names is already using 'oneOf'! The extended diff looks like that: interrupts: - anyOf: + oneOf: - minItems: 1 items: - description: TX interrupt - description: RX interrupt - items: - description: common/combined interrupt =20 interrupt-names: oneOf: - minItems: 1 items: - const: tx - const: rx - const: common Thanks, Miqu=C3=A8l