From: Parker Newman <parker@finest.io>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Parker Newman <pnewman@connecttech.com>
Subject: Re: [PATCH v3 0/5] serial: 8250_exar: Replace custom EEPROM code with eeprom_93cx6
Date: Wed, 2 Oct 2024 10:37:45 -0400 [thread overview]
Message-ID: <20241002103745.261e1922@SWDEV2.connecttech.local> (raw)
In-Reply-To: <Zv1ZOs1u1S8B6szs@smile.fi.intel.com>
On Wed, 2 Oct 2024 17:31:22 +0300
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> On Wed, Oct 02, 2024 at 10:14:06AM -0400, Parker Newman wrote:
> > From: Parker Newman <pnewman@connecttech.com>
> >
> > This series of patches replaces the custom 93cx6 EEPROM read functions in
> > the 8250_exar driver with the eeprom_93cx6 driver. This removes duplicate code
> > and improves code readability.
> >
> > In order to use the eeprom_93cx6 driver a quirk needed to be added to add an
> > extra clock cycle before reading from the EEPROM. This is similar to the
> > quirk in the eeprom_93xx46 driver.
>
> Everything is fine except one minor (in patch 1) and one more serious
> (see patches 3 & 4) issue. I just commented on them. Fix and send a final
> v4, my tags are already there and you may keep them.
>
> Thank you!
>
Thank you, I will fix and resend.
prev parent reply other threads:[~2024-10-02 14:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-02 14:14 [PATCH v3 0/5] serial: 8250_exar: Replace custom EEPROM code with eeprom_93cx6 Parker Newman
2024-10-02 14:14 ` [PATCH v3 1/5] misc: eeprom: eeprom_93cx6: Add quirk for extra read clock cycle Parker Newman
2024-10-02 14:27 ` Andy Shevchenko
2024-10-02 14:14 ` [PATCH v3 2/5] misc: eeprom: eeprom_93cx6: Switch to BIT() macro Parker Newman
2024-10-02 14:14 ` [PATCH v3 3/5] serial: 8250_exar: Replace custom EEPROM read with eeprom_93cx6 Parker Newman
2024-10-02 14:14 ` [PATCH v3 4/5] serial: 8250_exar: Remove old exar_ee_read() and other unneeded code Parker Newman
2024-10-02 14:29 ` Andy Shevchenko
2024-10-02 14:14 ` [PATCH v3 5/5] serial: 8250_exar: Group CTI EEPROM offsets by device Parker Newman
2024-10-02 14:31 ` [PATCH v3 0/5] serial: 8250_exar: Replace custom EEPROM code with eeprom_93cx6 Andy Shevchenko
2024-10-02 14:37 ` Parker Newman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241002103745.261e1922@SWDEV2.connecttech.local \
--to=parker@finest.io \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=pnewman@connecttech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.