From: Lee Jones <lee@kernel.org>
To: Werner Sembach <wse@tuxedocomputers.com>
Cc: bentiss@kernel.org, dri-devel@lists.freedesktop.org,
hdegoede@redhat.com, jelle@vdwaa.nl, jikos@kernel.org,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-leds@vger.kernel.org, miguel.ojeda.sandonis@gmail.com,
ojeda@kernel.org, onitake@gmail.com, pavel@ucw.cz, cs@tuxedo.de
Subject: Re: [PATCH v2 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO
Date: Wed, 2 Oct 2024 13:52:43 +0100 [thread overview]
Message-ID: <20241002125243.GC7504@google.com> (raw)
In-Reply-To: <20240927124152.139099-1-wse@tuxedocomputers.com>
On Fri, 27 Sep 2024, Werner Sembach wrote:
> Hi,
> first revision integrating Armins feedback.
>
> Stuff I did not yet change and did not comment on previously:
> - Still have to ask Christoffer why the mutex is required
> - Still using acpi_size instad of size_t in the util functions, because the value is put directly into a struct using acpi_size
> - Error messages for __wmi_method_acpi_object_out still in that method because they reference method internal variables
>
> Let me know if my reasoning is flawed
Use `git format-patch`'s --annotate and --compose next time please.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2024-10-02 12:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-27 12:41 [PATCH v2 1/1] platform/x86/tuxedo: Add virtual LampArray for TUXEDO Werner Sembach
2024-09-27 12:41 ` Werner Sembach
2024-09-29 0:56 ` kernel test robot
2024-09-29 7:39 ` kernel test robot
2024-10-02 12:52 ` Lee Jones [this message]
2024-10-02 13:31 ` Werner Sembach
2024-10-03 7:59 ` Lee Jones
2024-10-04 14:36 ` Werner Sembach
2024-10-07 12:58 ` Lee Jones
2024-10-07 15:15 ` Werner Sembach
2024-10-08 15:33 ` Lee Jones
2024-10-09 9:53 ` Werner Sembach
-- strict thread matches above, loose matches on Subject: below --
2024-09-28 7:42 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241002125243.GC7504@google.com \
--to=lee@kernel.org \
--cc=bentiss@kernel.org \
--cc=cs@tuxedo.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=jelle@vdwaa.nl \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=onitake@gmail.com \
--cc=pavel@ucw.cz \
--cc=wse@tuxedocomputers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.