Re: [PATCH v2 1/8] iommu: Refactor __iommu_domain_alloc()

[Jason Gunthorpe <jgg@ziepe.ca>]

On Mon, Sep 30, 2024 at 10:55:23AM -0700, Jacob Pan wrote:
> Currently, we have ftrace like this when I do:
> echo DMA > /sys/bus/pci/devices/0000\:38\:00.0/iommu_group/type
> 
>     iommu_setup_default_domain() {
>       __iommu_domain_alloc() {
>         intel_iommu_domain_alloc();
>         iommu_get_dma_cookie();
>       }
>       iommu_domain_free() {
>          iommu_put_dma_cookie();
>         intel_iommu_domain_free();
>        }
> 
> With this change, it will be:
>     iommu_setup_default_domain() {
>         iommu_get_dma_cookie();
> 	__iommu_domain_alloc() {
>         intel_iommu_domain_alloc();
>       }

?

iommu_get_dma_cookie() accepts a domain pointer, how can it be after
intel_iommu_domain_alloc() ? That would be a bug, right?

Jason